Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								4b813bac1c 
								
							 
						 
						
							
							
								
								na  
							
							
							
						 
						
							2021-12-19 12:31:47 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								6a039c2700 
								
							 
						 
						
							
							
								
								Update z3++.h  
							
							... 
							
							
							
							simplify definition 
							
						 
						
							2021-12-19 11:53:01 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Margus Veanes 
								
							 
						 
						
							
							
								
								
							
							
							
								
							
							
								a7b1db611c 
								
							 
						 
						
							
							
								
								State graph dgml update and fixes in condition simplifier ( #5721 )  
							
							... 
							
							
							
							* improved generated dgml graph
* fixed simplification of negated ranges and did some code cleanup
* do not make loops with lower=upper=0, this is epsilon
* do not add loops with lower=upper=1
* bug fix in normalization: forgotten eps case 
							
						 
						
							2021-12-19 11:09:55 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								bee742111a 
								
							 
						 
						
							
							
								
								na  
							
							
							
						 
						
							2021-12-19 11:05:19 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								7441bd706b 
								
							 
						 
						
							
							
								
								na  
							
							
							
						 
						
							2021-12-19 10:57:42 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								c1d5111159 
								
							 
						 
						
							
							
								
								add first test for band  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-18 12:28:59 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								85e362277c 
								
							 
						 
						
							
							
								
								Update z3++.h  
							
							... 
							
							
							
							with bindings for user propagate functions 
							
						 
						
							2021-12-18 11:56:05 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								f0740bdf60 
								
							 
						 
						
							
							
								
								move user propagte declare to context level  
							
							... 
							
							
							
							declaration of user propagate functions are declared at context level instead of at solver scope. 
							
						 
						
							2021-12-18 10:56:42 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								4856581b68 
								
							 
						 
						
							
							
								
								na  
							
							
							
						 
						
							2021-12-17 16:40:19 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								8ca023d541 
								
							 
						 
						
							
							
								
								expose propagate created  
							
							
							
						 
						
							2021-12-17 16:12:47 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								e1ffaa7faf 
								
							 
						 
						
							
							
								
								na  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-17 11:34:57 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								9c8800bdde 
								
							 
						 
						
							
							
								
								adding a new toy for Clemens  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-17 10:45:59 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								6963451704 
								
							 
						 
						
							
							
								
								na  
							
							
							
						 
						
							2021-12-16 20:13:29 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								5974200444 
								
							 
						 
						
							
							
								
								fixes to previous push and streamlining  
							
							
							
						 
						
							2021-12-16 20:06:49 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								4e82a9af5f 
								
							 
						 
						
							
							
								
								pin expressions  
							
							
							
						 
						
							2021-12-16 19:41:32 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								6cc9aa3562 
								
							 
						 
						
							
							
								
								prepare user propagator declared functions for likely Clemens use case  
							
							
							
						 
						
							2021-12-16 19:37:30 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Margus Veanes 
								
							 
						 
						
							
							
								
								
							
							
							
								
							
							
								a288f9048a 
								
							 
						 
						
							
							
								
								Update regex union and intersection to maintain ANF ( #5717 )  
							
							... 
							
							
							
							* added merge for unions and intersections
* added normalization rules to ensure ANF
* fixing PR comments related to merge 
							
						 
						
							2021-12-16 19:19:36 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								db62038845 
								
							 
						 
						
							
							
								
								Update nightly.yaml  
							
							... 
							
							
							
							see if this gets us past the upload to GitHub issue 
							
						 
						
							2021-12-16 14:20:40 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								4641a20f4f 
								
							 
						 
						
							
							
								
								#5700  - Add download x86 as part of release NuGet  
							
							... 
							
							
							
							x86 is part of nightly NuGet but was not added to the release pipeline. 
							
						 
						
							2021-12-16 13:50:31 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								122b0fec0f 
								
							 
						 
						
							
							
								
								fix   #5710  
							
							
							
						 
						
							2021-12-16 12:30:29 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								a099972354 
								
							 
						 
						
							
							
								
								fix   #5714  
							
							... 
							
							
							
							It is not unlike other fuzz bugs: it exercises some behavior that applications are unlikely to expose. In this case, a rule body expanded into a conjunction with more than 1M formulas (with a lot of repetition). The original rule representation assumed silently that the number of constraints in a body would fit within 20 bits, but reality allowed bodies with as many as 2^{32} - 1 constraints.
So "minimizing" the bug as @agurfinkel asks for seems not to make too much sense.
Just running the samples in debug mode  points to the root cause.
Since fuzz bugs are not from applications and fuzz tools have the potential for creating a large number of issues, I find it reasonable to push some basic pro-active asks on filers:
- reproduce bug in debug builds to assess whether a debug assert triggers.
- minimize or keep it simpler when possible (in this case it does not apply)
- perform basic diagnostics/triage. I am basically asking to push this part of the work on to the fuzzer. Otherwise, addressing random bugs doesn't scale. Triaging should have pointed to the root cause.
Now, there tends to be something to learn from bugs. In this case, the question was: "can we avoid constraints with duplications"? In particular, it points to a basic inefficiency of extracting conjunctions (and disjunctions). The function didn't deduplicate. So I added deduplication into this function. It is used throughout z3 code base so could expose latent issues. We will see. 
							
						 
						
							2021-12-16 10:20:53 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								dd6a11b526 
								
							 
						 
						
							
							
								
								fix   #5715  
							
							
							
						 
						
							2021-12-16 09:35:54 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								2caa7e6e45 
								
							 
						 
						
							
							
								
								remove EnumToNative as it drops reference counts,  fixes   #5713  
							
							
							
						 
						
							2021-12-16 03:22:54 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								8f8d88bc9d 
								
							 
						 
						
							
							
								
								ups  
							
							
							
						 
						
							2021-12-15 14:13:01 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								02369647a0 
								
							 
						 
						
							
							
								
								add functionality for bit-wise and  
							
							
							
						 
						
							2021-12-15 14:07:53 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								c9472b01fe 
								
							 
						 
						
							
							
								
								fixes  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-15 11:45:25 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Margus Veanes 
								
							 
						 
						
							
							
								
								
							
							
							
								
							
							
								2be93870c8 
								
							 
						 
						
							
							
								
								Cleanup regex info and some fixes in Derivative code ( #5709 )  
							
							... 
							
							
							
							* removed unused regex info fields
* cleanup of info and fixes in antimirov derivatives
* removed extra qualification on operator 
							
						 
						
							2021-12-15 10:59:34 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								4eb3f5c630 
								
							 
						 
						
							
							
								
								elaborate on narrow  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-15 10:17:42 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								a6684824c1 
								
							 
						 
						
							
							
								
								elaborate on narrow  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-15 10:13:33 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								12fe964ea5 
								
							 
						 
						
							
							
								
								na  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-15 09:32:09 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								a2aa1170f9 
								
							 
						 
						
							
							
								
								rename to op-constraint to give space for other operations  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-15 09:20:11 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								bc1e44ab71 
								
							 
						 
						
							
							
								
								fill in some use cases  
							
							
							
						 
						
							2021-12-14 19:51:30 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								79bc33b88e 
								
							 
						 
						
							
							
								
								na  
							
							
							
						 
						
							2021-12-14 19:42:19 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								134831283f 
								
							 
						 
						
							
							
								
								space  
							
							
							
						 
						
							2021-12-14 19:25:53 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								6eb6eb39a4 
								
							 
						 
						
							
							
								
								more of shr  
							
							
							
						 
						
							2021-12-14 19:23:31 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								842e9234c9 
								
							 
						 
						
							
							
								
								remove pragma  
							
							
							
						 
						
							2021-12-14 14:38:12 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								06f7ba2e78 
								
							 
						 
						
							
							
								
								add stubs for shr  
							
							
							
						 
						
							2021-12-14 14:35:08 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								3b58f548f7 
								
							 
						 
						
							
							
								
								remove dead code  
							
							
							
						 
						
							2021-12-14 13:42:52 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								03b5380a20 
								
							 
						 
						
							
							
								
								na  
							
							
							
						 
						
							2021-12-14 13:39:52 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								934564882c 
								
							 
						 
						
							
							
								
								na  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-14 12:34:34 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								b1d167de5b 
								
							 
						 
						
							
							
								
								fix co-factoring'  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-14 10:12:38 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								5348af3c4c 
								
							 
						 
						
							
							
								
								fix co-factoring  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-14 10:05:09 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								f40becf099 
								
							 
						 
						
							
							
								
								remove case for non-emptiness to combine with standard membership  
							
							... 
							
							
							
							as part of revising engine for addressing #5693  
							
						 
						
							2021-12-13 18:17:40 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								b2af7ea68f 
								
							 
						 
						
							
							
								
								stdout  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-13 15:19:29 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								9ec0f94ab9 
								
							 
						 
						
							
							
								
								hoisting out blocker for empty  
							
							... 
							
							
							
							#5693  
						
							2021-12-13 14:25:05 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								8c2735e68b 
								
							 
						 
						
							
							
								
								prepare for diseq_lin viable  
							
							
							
						 
						
							2021-12-13 12:00:19 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								fcdf8d4948 
								
							 
						 
						
							
							
								
								include atomic  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-13 11:40:45 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								651b41f8c0 
								
							 
						 
						
							
							
								
								refactor fi functionality  
							
							
							
						 
						
							2021-12-13 11:39:15 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								ca3251b152 
								
							 
						 
						
							
							
								
								add widening in all cases  
							
							
							
						 
						
							2021-12-13 10:55:03 -08:00 
							
								 
							
						 
					 
				
					
						
							
								
								
									Nikolaj Bjorner 
								
							 
						 
						
							
							
							
							
								
							
							
								c7da31a67d 
								
							 
						 
						
							
							
								
								na  
							
							... 
							
							
							
							Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com> 
							
						 
						
							2021-12-13 10:24:42 -08:00