Lev Nachmanson
426f8396e3
Merge pull request #8691 from Z3Prover/no_fail
...
Disable failure on a nullified polynomial in levelwise
2026-02-19 11:46:46 -10:00
Lev Nachmanson
23560ba8a5
cleanup regarding levelwise
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-19 09:31:30 -10:00
Lev Nachmanson
91a3068f79
disable a failure on a nullified poly in levelwise
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-19 07:18:10 -10:00
Lev Nachmanson
1e985ea96e
enable optional failure in levelwise
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 13:14:59 -10:00
Lev Nachmanson
aff0a82914
disable control over what added in handle_nullified_poly
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 12:47:42 -10:00
copilot-swe-agent[bot]
366b197c2b
Fix OCaml build error in solver_get_levels
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-18 22:21:58 +00:00
Lev Nachmanson
d1461de8a7
fix nlsat.cpp and enable control over what added in handle_nullified_poly
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 12:02:56 -10:00
Lev Nachmanson
799fc9e8c4
hook up a test
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 10:59:41 -10:00
Lev Nachmanson
d8f2b5ca01
add new polynomials from handle_nullified to m_todo
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 10:54:39 -10:00
Lev Nachmanson
df419c137d
fix the test
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 07:47:16 -10:00
copilot-swe-agent[bot]
ac10af417a
Add missing API methods to Go and OCaml bindings
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-18 17:28:12 +00:00
Lev Nachmanson
b60e0e0dd3
keep literals alive
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 07:23:22 -10:00
Lev Nachmanson
138828259a
add a test with compute_conflict_explanation call
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 07:08:56 -10:00
Lev Nachmanson
05029c6f03
work on nl testing
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-18 06:33:52 -10:00
Lev Nachmanson
7aa1ba1905
a bug fix in levelwise with the section case, where a discriminant was not added, and adding new tests for levelwise
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-17 20:00:53 -10:00
Lev Nachmanson
af6d461b5e
add tests for levelwise
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-17 14:46:21 -10:00
copilot-swe-agent[bot]
064122a123
Improve documentation for RatVal division by zero handling
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-18 00:44:40 +00:00
copilot-swe-agent[bot]
ae328dc006
Fix Priority 1 ASSERT_FAIL bugs - replace assertions with proper error handling
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-18 00:42:55 +00:00
Lev Nachmanson
269dba0525
add all coeffs ot a nullified polynomial to the projection
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-17 14:20:58 -10:00
Lev Nachmanson
a781f9c0a0
remove an obsolete m_fail and related from levelwise
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-17 14:11:16 -10:00
Lev Nachmanson
2d8e866e19
try replace fail with a adding partial derivatives
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-17 13:20:50 -10:00
Lev Nachmanson
9ef99f57e8
remove irrelevant order-sign invariance tracking from levelwise
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-17 11:28:26 -10:00
Nuno Lopes
282834f90f
delete dead code
2026-02-17 21:18:48 +00:00
copilot-swe-agent[bot]
87812a99c0
Add safety comment and improve test documentation
...
- Add comment about safety of &levels[0] after n > 0 check
- Improve test documentation about SimpleSolver limitations
- Clarify that Units/NonUnits are more reliable for general use
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-17 16:43:12 +00:00
copilot-swe-agent[bot]
b799238fe8
Improve documentation clarity for new APIs
...
- Add notes to Trail/TrailLevels about SimpleSolver requirement
- Clarify congruence closure API documentation
- Update test example with more detailed comments
- Make it clear when these functions may not work
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-17 16:41:44 +00:00
copilot-swe-agent[bot]
4ccc28cc71
Optimize TrailLevels and improve documentation
...
- Fix NonUnits documentation for clarity
- Optimize TrailLevels to avoid double trail retrieval
- Use trail vector directly instead of rebuilding it
- Reduces memory allocations and reference counting overhead
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-17 16:40:09 +00:00
copilot-swe-agent[bot]
1bae5a847c
Add missing solver API functions to Go bindings
...
- Add Units() - get unit clauses learned by solver
- Add NonUnits() - get non-unit clauses
- Add Trail() - get decision trail
- Add TrailLevels() - get trail decision levels
- Add CongruenceRoot() - get congruence class representative
- Add CongruenceNext() - get next element in congruence class
- Add CongruenceExplain() - explain why two terms are congruent
- Add test example demonstrating new APIs
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-17 16:38:39 +00:00
Nikolaj Bjorner
cff06b528f
fix #8563 - align indices for flat quantifiers with sks vector layout, and also guard creating instantiation equalities with sort checks
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-16 20:57:38 -08:00
copilot-swe-agent[bot]
037a4aa155
Fix C4267 build warnings in ast.h by adding static_cast for size_t to unsigned conversions
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-17 04:44:23 +00:00
copilot-swe-agent[bot]
5a9f416837
Simplify Go bindings: refactor GetLowerAsVector and GetUpperAsVector to use astVectorToExprs helper
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-17 03:46:58 +00:00
copilot-swe-agent[bot]
96d9c66aff
Fix formatting of z3.go using gofmt
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 22:00:07 +00:00
Nikolaj Bjorner
1fb405cf44
Merge pull request #8655 from Z3Prover/copilot/fix-go-bindings-reference-count
...
[WIP] Fix reference counting for Z3_ast_vector in go bindings
2026-02-16 13:58:03 -08:00
copilot-swe-agent[bot]
ea1f5a333a
Fix Go bindings reference counting for Z3_ast_vector objects
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 21:48:49 +00:00
copilot-swe-agent[bot]
188880a20c
Add missing high-priority Go bindings to Solver
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 21:28:24 +00:00
Nikolaj Bjorner
dd10826c99
Merge pull request #8646 from Z3Prover/copilot/build-go-bindings-ci
...
Enable Go bindings in ubuntu-cmake CI builds
2026-02-16 09:45:42 -08:00
Nikolaj Bjorner
e87cf5ad2b
remove brittle pydoc example
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-16 09:20:57 -08:00
copilot-swe-agent[bot]
d33c0e5601
Fix trailing whitespace in Go source files
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 06:06:48 +00:00
copilot-swe-agent[bot]
3f4bd11f00
Fix Go bindings and enable in CI
...
- Fix all compilation errors in Go bindings
- Add missing type definitions (Pattern, ASTVector, ParamDescrs)
- Fix boolean comparisons to use bool() casts
- Fix Z3_app type casts using unsafe.Pointer
- Fix null symbol handling to use nil
- Fix unused variable in basic_example.go
- Fix CMake test target to run from examples/go directory
- Restore CI steps to build and test Go bindings
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 06:05:58 +00:00
copilot-swe-agent[bot]
bbc1e501ab
Fix Go bindings compilation issues and add to CI
...
- Fix malformed z3.go with duplicate function body fragments
- Fix datatype.go to use Z3_del_constructor and Z3_del_constructor_list instead of non-existent inc_ref/dec_ref functions
- Remove non-existent Push/Pop methods from fixedpoint.go
- Fix CMake Go bindings targets quoting for proper LDFLAGS handling
- Add Go bindings support to ubuntu-cmake CI jobs
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 05:58:20 +00:00
Nikolaj Bjorner
249b59f42c
Merge pull request #8637 from Z3Prover/copilot/refactor-proof-functions-initializer-list
...
Modernize mk_unit_resolution and mk_transitivity with std::initializer_list overloads
2026-02-15 21:33:08 -08:00
Nikolaj Bjorner
a6620765dc
Merge pull request #8638 from Z3Prover/copilot/refactor-update-quantifier-initializer-list
...
Modernize update_quantifier with std::initializer_list overloads
2026-02-15 21:32:38 -08:00
Nikolaj Bjorner
e099c74985
Merge branch 'master' of https://github.com/z2prover/z3
2026-02-15 21:25:04 -08:00
Nikolaj Bjorner
66d0fb5477
git bindings v1.0
2026-02-15 21:24:40 -08:00
Nikolaj Bjorner
b0ebc78217
Merge pull request #8631 from danielzgtg/doc/solverSexpr
...
Document example for Solver.sexpr()
2026-02-15 20:51:54 -08:00
Daniel Tang
114a325cd4
Document example for Solver.sexpr()
2026-02-15 21:38:46 -05:00
copilot-swe-agent[bot]
f3c4c57c58
Improve test validation for mk_transitivity
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 01:52:20 +00:00
copilot-swe-agent[bot]
e627e60fe7
Restore defensive SASSERT in smt_conflict_resolution
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 01:50:51 +00:00
copilot-swe-agent[bot]
d239e7a19d
Add test for initializer_list overloads
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 01:48:21 +00:00
copilot-swe-agent[bot]
fb043ac9ee
Add std::initializer_list overloads for update_quantifier and update call sites
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 01:28:31 +00:00
copilot-swe-agent[bot]
9efb0e0794
Add initializer_list overloads and update all call sites
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-16 01:27:08 +00:00