mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-11-03 21:09:11 +00:00
Code Activity
18371 commits 49 branches 53 tags 182 MiB
Commit graph

3038 commits

Author SHA1 Message Date
Margus Veanes
a288f9048a
Update regex union and intersection to maintain ANF (#5717) 
* added merge for unions and intersections

* added normalization rules to ensure ANF

* fixing PR comments related to merge
 2021-12-16 19:19:36 -08:00
Nikolaj Bjorner
a099972354 fix #5714 
It is not unlike other fuzz bugs: it exercises some behavior that applications are unlikely to expose. In this case, a rule body expanded into a conjunction with more than 1M formulas (with a lot of repetition). The original rule representation assumed silently that the number of constraints in a body would fit within 20 bits, but reality allowed bodies with as many as 2^{32} - 1 constraints.
So "minimizing" the bug as @agurfinkel asks for seems not to make too much sense.

Just running the samples in debug mode  points to the root cause.

Since fuzz bugs are not from applications and fuzz tools have the potential for creating a large number of issues, I find it reasonable to push some basic pro-active asks on filers:

- reproduce bug in debug builds to assess whether a debug assert triggers.
- minimize or keep it simpler when possible (in this case it does not apply)
- perform basic diagnostics/triage. I am basically asking to push this part of the work on to the fuzzer. Otherwise, addressing random bugs doesn't scale. Triaging should have pointed to the root cause.

Now, there tends to be something to learn from bugs. In this case, the question was: "can we avoid constraints with duplications"? In particular, it points to a basic inefficiency of extracting conjunctions (and disjunctions). The function didn't deduplicate. So I added deduplication into this function. It is used throughout z3 code base so could expose latent issues. We will see.
 2021-12-16 10:20:53 -08:00
Margus Veanes
2be93870c8
Cleanup regex info and some fixes in Derivative code (#5709) 
* removed unused regex info fields

* cleanup of info and fixes in antimirov derivatives

* removed extra qualification on operator
 2021-12-15 10:59:34 -08:00
Nikolaj Bjorner
03b5380a20 na 2021-12-14 13:39:52 -08:00
Nikolaj Bjorner
b1d167de5b fix co-factoring' 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-12-14 10:12:38 -08:00
Nikolaj Bjorner
f40becf099 remove case for non-emptiness to combine with standard membership 
as part of revising engine for addressing #5693
 2021-12-13 18:17:40 -08:00
Nikolaj Bjorner
96e871c826 add stub for testing updates to scoped_timer 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-12-12 12:31:23 -08:00
Nikolaj Bjorner
51fa40ece5 fix spelling 2021-12-09 10:23:37 -08:00
Nikolaj Bjorner
e45ae32685 unsound equality propagation #5676 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-12-08 09:02:05 -08:00
Nikolaj Bjorner
a5bd115235 replace_re axiom placeholder 
@ahelwer - illustrates placeholder for one approach for axiomatizing replace_re
 2021-12-08 03:40:24 -08:00
Nikolaj Bjorner
87aec8819f fix #5687 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-12-01 10:08:29 -08:00
Nikolaj Bjorner
c083aa82ee add debug information in user-propagate #5687 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-11-29 08:59:53 -08:00
Nikolaj Bjorner
d50bfc6a50 #5641 2021-11-25 18:01:35 +01:00
Nikolaj Bjorner
e8f5a29c31 fix #5679 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-11-22 19:37:10 +01:00
Nikolaj Bjorner
518ef9f916 fix #5674 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-11-18 21:14:50 -08:00
Nikolaj Bjorner
b28a8013fe #5653 
fix performance bottleneck in static features
 2021-11-11 13:30:38 -08:00
Henrich Lauko
96671cfc73
Add and fix a few general compiler warnings. (#5628) 
* rewriter: fix unused variable warnings

* cmake: make missing non-virtual dtors error

* treewide: add missing virtual destructors

* cmake: add a few more checks

* api: add missing virtual destructor to user_propagator_base

* examples: compile cpp example with compiler warnings

* model: fix unused variable warnings

* rewriter: fix logical-op-parentheses warnings

* sat: fix unused variable warnings

* smt: fix unused variable warnings
 2021-10-29 15:42:32 +02:00
Margus Veanes
efcad5ff35
fixed nullability bug in the if-then-else info (#5620) 2021-10-26 09:11:07 +02:00
Nikolaj Bjorner
bc2020a39b #5604 
retain array interpretation when available
 2021-10-17 20:24:26 -07:00
Margus Veanes
f78546cd7c
fixed bug of computing butlast of a sequence (#5602) 2021-10-15 18:02:51 -07:00
Nikolaj Bjorner
fb9fa1b7d2 updated printer 2021-10-15 17:56:54 -07:00
Margus Veanes
cb120c93f4
Regex range bug fix (#5601) 
* added a missing derivative case for nonground range

* further missing cases and a bug fix in re.to_str
 2021-10-15 15:30:55 -07:00
Nikolaj Bjorner
c15968aa9e fix #4901 2021-10-12 17:10:04 -07:00
Nikolaj Bjorner
9a76bf0aa2 #5591 
nth issue
 2021-10-12 13:59:28 -07:00
Christoph M. Wintersteiger
58fd4fc860
Merge pull request #5550 from wintersteiger/cwinter_fpa_fixes 
Assorted fixes for floats
 2021-10-12 18:24:49 +01:00
Nikolaj Bjorner
52032b9ef8 #5467 2021-10-12 10:16:15 -07:00
Christoph M. Wintersteiger
b471ebdf1c
Revert "Fix off-by-one in fp.div bit-blasting. Inspired by #4841 but doesn't quite fix it." 
This reverts commit f80fdb4ea3a762cfe95daa0321d9875cfa00c7ae.
 2021-10-12 12:45:11 +00:00
Christoph M. Wintersteiger
738783a26c
Fix off-by-one in fp.div bit-blasting. Inspired by #4841 but doesn't quite fix it. 2021-10-12 12:45:11 +00:00
Christoph M. Wintersteiger
c24f438e51
Fix for mk_to_fp_float; pertains to #4841 2021-10-12 12:45:10 +00:00
Christoph M. Wintersteiger
f1acc4b78a
Make fpa2bv debug symbol names optional 2021-10-12 12:45:09 +00:00
Christoph M. Wintersteiger
515a2a771e
Whitespace 2021-10-12 12:45:09 +00:00
Christoph M. Wintersteiger
e8d6d97ba3
Refine fpa_decl_plugin::is_unique_value 2021-10-12 12:45:08 +00:00
Christoph M. Wintersteiger
12c32663c6
Fix error messsages 2021-10-12 12:45:08 +00:00
Nikolaj Bjorner
73102cffcb fix #5589 2021-10-11 11:03:45 -07:00
Nikolaj Bjorner
75702c3631 na 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-10-11 11:03:45 -07:00
Nikolaj Bjorner
0fc9f1d46a fix max/min length to handle concatenation 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-10-09 16:20:32 -07:00
Margus Veanes
146f4621c5
Updated regex derivative engine (#5567) 
* updated derivative engine

* some edit

* further improvements in derivative code

* more deriv code edits and re::to_str update

* optimized mk_deriv_accept

* fixed PR comments

* small syntax fix

* updated some simplifications

* bugfix:forgot to_re before reverse

* fixed PR comments

* more PR comment fixes

* more PR comment fixes

* forgot to delete

* deleting unused definition

* fixes

Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>

* fixes

Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>

Co-authored-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-10-08 13:04:49 -07:00
Nikolaj Bjorner
281fb67d88 unit propagate with fingerprints 2021-10-04 20:01:46 -07:00
Nikolaj Bjorner
137e5c5263 fix tmp_eq 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-09-28 14:28:41 -07:00
Nikolaj Bjorner
67ae75bac7 fix tmp_eq 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-09-28 14:27:46 -07:00
Nikolaj Bjorner
da124e4275 tune q-eval and q-ematch 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-09-28 13:41:37 -07:00
Nikolaj Bjorner
92c1b600c3 tuning eval 2021-09-28 09:56:00 -07:00
Nikolaj Bjorner
18d1b368d1 #5532 2021-09-21 20:12:32 -07:00
Nikolaj Bjorner
708602dfbb fix #5560 - add a throttle on maximal size of bignums created for propagate-value lemmas 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-09-21 08:56:13 -07:00
Nikolaj Bjorner
2e96557827 fix #5560 - add a throttle on maximal size of bignums created for propagate-value lemmas 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-09-21 08:55:28 -07:00
Nikolaj Bjorner
6f31d83633 fix #5541 2021-09-20 10:10:28 -07:00
Nikolaj Bjorner
d36c3faf76 #4880 add interpreted versions of to_bv functions for MBQI quantifier models 2021-09-17 14:23:14 +01:00
Nikolaj Bjorner
cef964fda3 fixes for model converter default case 2021-09-16 17:31:26 +01:00
Nikolaj Bjorner
c3c5c14ead prepare for min/max i 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
 2021-09-16 16:23:10 +01:00
CEisenhofer
c58b2f4a9c
Added character functions to API (#5549) 
* Added character functions to API

* Changed names of c++ functions
 2021-09-15 13:34:58 +01:00