Address review feedback on the fixpoint loop:
- Scope the per-sweep cleanup to the module under rewrite via
Pass::call_on_module(..., "clean -purge") instead of running clean over
the whole design selection. This avoids O(N^2) work across modules and
keeps untouched modules' dangling cells until their own sweep, matching
the original single-call behavior.
- Emit a log_warning if a module fails to reach a fixpoint within
max_sweeps, so silent truncation of compaction is visible.
Co-authored-by: Cursor <cursoragent@cursor.com>
The tests/silimate suite (which aborted the Run tests CI job) exposed two
issues in the generalized passes:
- opt_compact_prefix: the forward dense pack regressions at 64 and 128 bits
no longer rewrote. The ConstEval fingerprint was uint64_t-based (capped at
62 bits) and the per-cone cell cap (max_width*96) was below the O(width^2)
cell count of a wide pack. The fingerprint now drives whole-width Const
bit patterns (no width cap) and the cone cap scales quadratically; total
work stays bounded by the shared walk/eval budgets.
- opt_priority_onehot: the "max-width below lane count" negative test set
max_width=8 on a 16-lane design expecting no rewrite, but the generalized
matcher legitimately (and equivalence-provably) rewrites the 8-lane
sub-region. The test now uses max_width=3 (below min_width 4) to verify
the width gate suppresses all matching.
Co-authored-by: Cursor <cursoragent@cursor.com>
