copilot-swe-agent[bot]
de3cf18899
Fix fp.to_real encoding for denormal floating-point values
...
The mk_to_real function in fpa2bv_converter.cpp was missing the
normalization shift adjustment (lz) when computing the real-valued
exponent for denormal floating-point numbers.
When unpack(x, sgn, sig, exp, lz, normalize=true) normalizes a denormal
by shifting the significand left by lz positions, the returned exp does
not account for this shift. All other callers (mk_mul, mk_div, mk_fma)
correctly subtract lz from the exponent, but mk_to_real was missing this.
The fix subtracts zero-extended lz from the sign-extended exp to get the
true exponent, matching the convention used by other FP operations.
Fixes incorrect model with (_ FloatingPoint 2 24) and fp.to_real.
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-24 05:22:54 +00:00
copilot-swe-agent[bot]
3feac95119
Simplify boolean return in goOnBindingCb
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-24 04:42:49 +00:00
Nikolaj Bjorner
8ec15639e0
Merge pull request #8726 from Z3Prover/copilot/convert-cofactor-term-ite-to-simplifier
...
Convert `cofactor-term-ite` tactic to a simplifier
2026-02-23 20:40:23 -08:00
Lev Nachmanson
cf3552c029
suppress witness subs optimization
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-23 09:59:08 -10:00
copilot-swe-agent[bot]
c0fd3513a2
Fix RNE/RNA overflow-to-infinity in Real-to-FP conversion (soundness bug)
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-23 04:34:58 +00:00
copilot-swe-agent[bot]
fd424c7afd
Delete factor_tactic.cpp (implementation moved to factor_simplifier.cpp)
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-23 04:01:34 +00:00
copilot-swe-agent[bot]
afbd038924
Delete cofactor_term_ite_tactic.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-23 03:57:37 +00:00
Nikolaj Bjorner
2ea86d94dc
Merge pull request #8735 from Z3Prover/copilot/fix-discussed-issues
...
Add missing API bindings: importModelConverter, OnClause, and user propagator (Go/Java)
2026-02-22 19:46:11 -08:00
Nikolaj Bjorner
8fbc4ed26d
Merge pull request #8727 from Z3Prover/copilot/expose-max-bv-sharing-simplifier
...
Expose max-bv-sharing as a registered simplifier
2026-02-22 19:40:35 -08:00
Nikolaj Bjorner
0b5480b6c3
Merge pull request #8729 from Z3Prover/copilot/convert-bvarray2uf-to-simplifier
...
Convert `bvarray2uf` tactic to a dependent_expr_simplifier
2026-02-22 19:39:19 -08:00
copilot-swe-agent[bot]
d5030dfe30
Fix unsafe.Pointer usage in Go propagator - use uintptr_t for cgo.Handle
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-23 01:09:07 +00:00
copilot-swe-agent[bot]
0de7af9112
Add missing API bindings: importModelConverter, OnClause, and user propagator
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-23 01:01:26 +00:00
Nikolaj Bjorner
69eab28550
Merge pull request #8730 from Z3Prover/copilot/convert-der-tactic-to-simplifier
...
Convert `der` tactic to a `dependent_expr_simplifier`
2026-02-22 14:04:04 -08:00
copilot-swe-agent[bot]
1d2a76d27b
Delete bvarray2uf_tactic.cpp (removed from CMakeLists.txt)
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-22 08:57:39 +00:00
copilot-swe-agent[bot]
57d1667d28
Remove der_tactic.cpp from CMakeLists.txt (file was deleted)
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-22 08:47:14 +00:00
Nikolaj Bjorner
b149f27e82
Delete src/tactic/core/der_tactic.cpp
2026-02-22 00:25:24 -08:00
copilot-swe-agent[bot]
b6e63f06fd
Remove old cofactor_term_ite_tactic.cpp, use simplifier-based implementation
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-22 00:45:44 +00:00
copilot-swe-agent[bot]
4f6c0637fc
Remove old mk_factor_tactic, rename factor2 to factor
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-22 00:45:12 +00:00
copilot-swe-agent[bot]
d9d712f1d0
Remove old bvarray2uf_tactic implementation; use simplifier as basis
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-22 00:43:36 +00:00
copilot-swe-agent[bot]
7c4a3b2c1b
Remove old der_tactic implementation; rename mk_der2_tactic to mk_der_tactic
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-22 00:40:49 +00:00
Nikolaj Bjorner
0d553f2ce9
Merge pull request #8712 from Z3Prover/copilot/fix-soundness-issue-conversion
...
Fix FPA soundness issue in incremental (push/pop) solving
2026-02-21 16:26:23 -08:00
copilot-swe-agent[bot]
c18db6080a
Convert cofactor-term-ite tactic to also expose as a simplifier
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 23:52:01 +00:00
copilot-swe-agent[bot]
0cc4afa097
Add bvarray2uf_simplifier: convert tactic to simplifier
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 23:50:32 +00:00
copilot-swe-agent[bot]
c78b3d872d
Convert der tactic to simplifier: add der_simplifier.h and update der_tactic.h
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 23:49:05 +00:00
copilot-swe-agent[bot]
42d3a13ddf
Add factor_simplifier and factor2 tactic wrapping the simplifier
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 23:45:51 +00:00
copilot-swe-agent[bot]
ce905f91c3
Register max_bv_sharing simplifier via ADD_SIMPLIFIER
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 23:26:47 +00:00
Toby Shi
f5fba112bc
add parser_context in c++ api
2026-02-21 17:59:44 +08:00
copilot-swe-agent[bot]
46daa160ed
Fix FPA soundness issue: reset rewriter cache in pop_scope_eh (issue #8345 )
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 03:35:47 +00:00
Nikolaj Bjorner
ee1a6a2f91
Merge pull request #8710 from Z3Prover/copilot/fix-discussed-issues-8709
...
Align congruence closure API naming in Python and Java bindings
2026-02-20 19:13:11 -08:00
copilot-swe-agent[bot]
e5d7319670
Code simplifications for finite set plugin
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 02:08:04 +00:00
copilot-swe-agent[bot]
a3ea31cb42
Fix congruence closure API naming in Python and Java bindings
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-21 02:04:31 +00:00
Lev Nachmanson
66aaece3f5
try evaluate discriminants more rarely
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-20 10:16:27 -10:00
Nikolaj Bjorner
e2129a7b81
Merge pull request #8702 from Z3Prover/copilot/fix-issues-in-discussion-8701
...
Add missing solver/optimizer API bindings across language targets
2026-02-20 09:28:50 -08:00
Nikolaj Bjorner
20c446cede
Merge pull request #8703 from Z3Prover/copilot/fix-finite-set-apis
...
Add FiniteSet API support to Go, OCaml, and JavaScript/TypeScript bindings
2026-02-20 08:40:07 -08:00
copilot-swe-agent[bot]
ce0fb1bd24
Fix OCaml build error: use status instead of solver_result in z3.mli
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-20 04:32:56 +00:00
copilot-swe-agent[bot]
5253f9af9d
Fix TypeScript type error: explicitly type consVec as AstVectorImpl<Bool<Name>>
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-20 04:31:18 +00:00
copilot-swe-agent[bot]
60f5a76516
Add tests and documentation for addAndTrack in TypeScript bindings (fix discussion #8705 )
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-20 04:28:10 +00:00
copilot-swe-agent[bot]
8d79e21aa7
Add missing API methods across language bindings (discussion #8701 )
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-20 04:24:22 +00:00
copilot-swe-agent[bot]
5d93f098fc
Add FiniteSet support to Go, OCaml, and JavaScript APIs
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-20 04:23:26 +00:00
Nikolaj Bjorner
8314aecb44
Merge pull request #8686 from Z3Prover/finite-sets
...
Finite sets
2026-02-19 19:49:47 -08:00
Nikolaj Bjorner
3d8dd0d783
update params
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-19 19:06:06 -08:00
Lev Nachmanson
9c4e172e95
set the default of lws_spt_threshold to 4
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-19 14:18:11 -10:00
Lev Nachmanson
385f913a33
try optimize handle_nullified_poly
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-19 13:58:45 -10:00
Nikolaj Bjorner
38ce0882db
remove lattice component
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-19 15:49:45 -08:00
Nikolaj Bjorner
bf73fddf6f
Merge pull request #8693 from Z3Prover/copilot/fix-test-coverage-gaps
...
Add unit tests covering ackermannization module and Z3_algebraic_eval
2026-02-19 15:32:46 -08:00
Nikolaj Bjorner
369890330e
Merge pull request #8699 from Z3Prover/copilot/fix-missed-bugs-ff-by-one
...
Fix off-by-one vulnerabilities in ackermannization module
2026-02-19 15:32:23 -08:00
copilot-swe-agent[bot]
dbd7cd7414
Fix off-by-one vulnerabilities: use range-based for on goals; cache loop bound
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-19 22:37:22 +00:00
copilot-swe-agent[bot]
093e227689
Add ackermannize tests for mutation coverage
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-19 22:07:41 +00:00
Nikolaj Bjorner
5bd7d93b55
add parameter validation
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-19 14:02:59 -08:00
Nikolaj Bjorner
ee03533c3a
update examples to use arrays
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-19 13:57:43 -08:00