Lev Nachmanson
9b88aaf134
determine parameter evaluation order
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2025-09-16 16:32:46 -07:00
Don Syme
44d2bba3e5
Add comprehensive tests for API algebraic number functions ( #7888 )
...
- Created new test file api_algebraic.cpp with tests for all algebraic API functions
- Tests cover basic operations (add, sub, mul, div, power, root)
- Tests cover comparison operations (lt, le, gt, ge, eq, neq)
- Tests cover sign detection (is_zero, is_pos, is_neg, sign)
- Tests cover algebraic value detection (is_value)
- Added comprehensive test cases for rational numbers and fractions
- Updated main.cpp and CMakeLists.txt to include the new test module
Coverage improvements:
- src/api/api_algebraic.cpp: 0% -> 52% (136/258 lines covered)
- Overall project coverage: ~47% (gained 71 covered lines)
Co-authored-by: Daily Test Coverage Improver <github-actions[bot]@users.noreply.github.com>
2025-09-16 15:32:23 -07:00
Nikolaj Bjorner
6752be7263
Remove unused variable in polynomial.cpp
...
Removed unused variable 'sz2' in polynomial multiplication.
2025-09-15 10:43:09 -07:00
Nikolaj Bjorner
b0bc41457f
Update polynomial.cpp
2025-09-15 10:41:56 -07:00
Nikolaj Bjorner
7efcda2674
Update polynomial.cpp
2025-09-15 09:46:29 -07:00
Nikolaj Bjorner
f4a87d4f61
shelve experiment with a variant of geobuckets
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-15 09:46:29 -07:00
Copilot
41491d79be
Add comprehensive test coverage for math/lp and math/polynomial modules ( #7877 )
...
* Initial plan
* Add comprehensive test coverage for math/lp and math/polynomial modules
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Finalize test coverage improvements with corrected implementations
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Fix compilation errors in test files
- Fix algebraic_numbers.cpp: Simplified tests to use basic algebraic operations without polynomial manager dependencies
- Fix polynomial_factorization.cpp: Corrected upolynomial::factors usage and API calls
- Fix nla_intervals.cpp: Changed 'solver' to 'nla::core' and fixed lar_solver constructor
- Fix monomial_bounds.cpp: Updated class names and method calls to match current NLA API
These changes address the scoped_numeral compilation errors and other API mismatches identified in the build.
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Fix monomial bounds test assertions to use consistent values
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2025-09-14 14:57:21 -07:00
Nikolaj Bjorner
6e767795db
set status to unknown
2025-09-14 13:43:10 -07:00
Nikolaj Bjorner
928a2e7cf2
update python doc tests
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-14 10:56:26 -07:00
Nikolaj Bjorner
0d0dd0315a
evaluate unhandled arithmetic operators based on an initialized model #7876
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-14 06:45:36 -07:00
Nikolaj Bjorner
3c897b450f
add rewrite rules for update-field under accessors and recognizers
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-14 06:14:42 -07:00
Nikolaj Bjorner
84bf34266b
put back shortcut for square test. Remove assumption in unit test
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-14 05:00:47 -07:00
Nikolaj Bjorner
8158a500d4
remove shortcut as it breaks current contract
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-14 04:49:27 -07:00
Nikolaj Bjorner
573c2cb8f7
micro tuning perfect square test
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-13 20:10:43 -07:00
Nuno Lopes
c350ddf990
remove a few useless dynamic casts
2025-09-13 21:06:55 +01:00
Nikolaj Bjorner
3a409e0673
#7861
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-11 15:05:11 -07:00
Nikolaj Bjorner
8440623f6d
initialize table with power of 2
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-11 11:47:25 -07:00
Copilot
294f0578b0
Fix Java API mkString to properly handle Unicode surrogate pairs ( #7865 )
...
* Initial plan
* Fix Java API mkString to properly handle surrogate pairs
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2025-09-11 11:13:31 -07:00
Nikolaj Bjorner
9196a3c369
fix #7861
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-11 10:20:58 -07:00
Nikolaj Bjorner
7566cc744d
display assumptions used
2025-09-11 10:20:55 -07:00
Copilot
b2acbaa0c9
Fix .NET performance issues by reducing multiple enumerations in constraint methods ( #7854 )
...
* Initial plan
* Fix .NET performance issues by reducing multiple enumerations in constraint methods
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Refactor MkApp and related methods for null checks
* Update null checks for MkApp method arguments
* Fix assertion condition for MkApp method
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
Co-authored-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-07 16:43:13 -07:00
Nikolaj Bjorner
a7eed2a9f3
remove flush_smc after m_solver.get_model #7855
...
the SAT model converter is applied by m_solver.get_model()
Calling m_sat_mc->flush_smc causes the SAT model converter to be inherited within m_sat_mc and then the model converter gets applied again. This time breaking the model.
flush_smc is reserved for incremental use:
2025-09-07 16:42:21 -07:00
Nikolaj Bjorner
d701702735
remove model converter operator on expr_ref&
2025-09-07 16:42:20 -07:00
Copilot
90e610eb23
Fix performance issue in MkAnd(IEnumerable) and eliminate code duplication ( #7851 )
...
* Initial plan
* Fix performance issue in MkAnd(IEnumerable<BoolExpr>) method
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Refactor IEnumerable methods to call params array variants
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2025-09-06 19:50:38 -07:00
Nikolaj Bjorner
866393a842
update defaults for new grobner featuers
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-05 14:34:03 -07:00
Nikolaj Bjorner
d7718623a4
handle case where all variables are bounded
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-04 12:58:03 -07:00
Nikolaj Bjorner
98a9a34f2b
add option to reduce pseudo-linear monomials
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-04 11:04:12 -07:00
Nikolaj Bjorner
e0c315bc3e
filter pseudo-linear monomials
2025-09-03 17:51:12 -07:00
Nikolaj Bjorner
7005d04755
propagate mod over ite even if it hurts
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-09-02 18:39:29 -07:00
Nikolaj Bjorner
a382ddbd8a
add rewrite for mod over negation, refine axioms for grobner quotients
2025-09-02 18:26:22 -07:00
Nikolaj Bjorner
e2235d81d3
add option for gcd-test to grobner
2025-09-01 16:37:21 -07:00
Nikolaj Bjorner
49703f8bba
remove debug out
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-31 17:41:42 -07:00
Nikolaj Bjorner
4c0c199e32
take into account integer coefficients
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-31 16:07:37 -07:00
Nikolaj Bjorner
e91e432496
add option to propagation quotients
...
for equations x*y + z = 0,
with x, y, z integer, enforce that x divides z
It is (currently) enabled within Grobner completion
and applied partially to x a variable, z linear, and
only when |z| < |x|.
2025-08-31 14:41:23 -07:00
Nikolaj Bjorner
91b4873b79
categorize lp stats
2025-08-29 17:06:13 -07:00
Nikolaj Bjorner
06de5f422c
remove str parameters
2025-08-29 17:06:13 -07:00
Karlheinz Friedberger
3e216dbb20
Fix method signature for onBindingWrapper, again ( #7829 )
...
#7828
2025-08-28 18:21:51 -07:00
Nikolaj Bjorner
a5609364dd
Fix method signature for onBindingWrapper
...
#7828
2025-08-28 13:04:04 -07:00
Nikolaj Bjorner
2337e68169
fix #7822
2025-08-27 09:17:55 -07:00
Shiwei Weng 翁士伟
894c0e9fbe
Bugfix: post-build sanity check when an old version of ocaml-z3 is installed ( #7815 )
...
* fix: add generating META for ocamlfind.
* Patch macos. We need to keep the `@rpath` and use environment var to enable the test because we need to leave it to be fixed by package managers.
* Trigger CI.
* Debug.
* Debug.
* Debug.
* Debug.
* Debug.
* Debug.
* Hacky fix for ocaml building warning.
* Fix typo and rename variables.
* Fix cmake for ocaml test, using local libz3 explicit.
2025-08-24 20:49:04 -07:00
Nikolaj Bjorner
12563c6963
clean up a little of the handling of VERSION.txt
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-24 16:38:15 -07:00
Copilot
300e0ae69e
Move VERSION.txt to scripts directory and update all references ( #7811 )
...
* Initial plan
* Move VERSION.txt to scripts/ and update all references
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2025-08-24 16:36:05 -07:00
Nikolaj Bjorner
287464567b
copy VERSION from SRC_DIR
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-24 15:10:49 -07:00
Nikolaj Bjorner
116e1eca8b
print dirs
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-24 15:02:50 -07:00
Nikolaj Bjorner
be22111df5
more output
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-24 14:49:56 -07:00
Nikolaj Bjorner
867bc6aee6
remove extra characters
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-24 14:36:23 -07:00
Nikolaj Bjorner
438b41acbf
try other dir
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-23 18:27:26 -07:00
Nikolaj Bjorner
1987b3dde1
try src_dir_repo
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-23 18:20:32 -07:00
Nikolaj Bjorner
778b9a57c3
try diferennt dirs
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-23 18:13:18 -07:00
Nikolaj Bjorner
3b036369f9
add more logging to setup.py
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2025-08-23 16:37:06 -07:00