Copilot
6ec2d4bc8d
Replace fall-through comments with Z3_fallthrough macro ( #8219 )
...
* Initial plan
* Fix switch fall-through warnings with Z3_fallthrough attribute
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-16 19:54:31 -08:00
Copilot
a574f97ebd
Update cross-build workflow to GCC 12 for C++20 support ( #8220 )
...
* Initial plan
* Update cross-build workflow to use g++-12 for C++20 support
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-16 19:53:36 -08:00
Copilot
36323f723b
Fix 13 compiler warnings: sign-comparison and unused parameters ( #8215 )
...
* Initial plan
* Fix 13 compiler warnings: sign-comparison and unused parameters
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-16 16:00:42 -08:00
Copilot
9666915dca
Fix artifact extraction patterns in nightly Python packaging job ( #8217 )
...
* Initial plan
* Fix unzip patterns in Python packaging job
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-16 15:50:22 -08:00
Ilana Shapiro
b1b7270686
Fix UNKNOWN bug in search tree about inconsistent end state ( #8214 )
...
* restore more aggressive pruning in search tree
* restore where we close children to be correct
* add core strengthening check
* fix recursion bug
* less strict core propagation
* old search tree version
* restore search tree patch
* remove flag
* debugging inconsistent end state with search, some changes need to be made in search tree, only backtrack should be closing nodes, I think the bug is when we do find_highest_attach for nonchronological backjumping, you might get to a point where the sibling is closed, so then we need to resolve further up the tree
* clean up code, fix deadlock
* delete test files
* clean up
---------
Co-authored-by: Ilana Shapiro <ilanashapiro@Mac.localdomain>
Co-authored-by: Ilana Shapiro <ilanashapiro@Ilanas-MacBook-Pro.local>
Co-authored-by: Ilana Shapiro <ilanashapiro@Ilanas-MBP.lan1>
2026-01-16 10:41:13 -08:00
Copilot
596cd23efc
Fix nightly build failures in ARM64 and Python packaging jobs ( #8213 )
...
* Initial plan
* Fix nightly build workflow failures for ARM64 and Python packaging
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-16 10:39:05 -08:00
Nuno Lopes
a7def9e65d
bot: restore std::format
2026-01-16 09:35:42 +00:00
Copilot
fb0f8190e3
[WIP] Update nightly.yml to fix build error with macOS runner ( #8209 )
...
* Initial plan
* Fix macos-13 runner retirement: update to macos-14
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-15 23:09:01 -08:00
Copilot
07929c3271
Fix checkout action GLIBC incompatibility in manylinux and macOS builds ( #8207 )
...
* Initial plan
* Fix checkout action compatibility with manylinux containers and macOS
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-15 21:54:24 -08:00
Copilot
6e68911cbb
Reapply PR #8190 : Replace std::ostringstream with C++20 std::format ( #8204 )
...
* Initial plan
* Reapply PR #8190 : Replace std::ostringstream with C++20 std::format
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-15 21:30:29 -08:00
Copilot
7d899fdc43
Migrate nightly builds from Azure DevOps to GitHub Actions ( #8206 )
...
* Initial plan
* Add GitHub Actions workflow for nightly builds
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Fix Windows builds to use --zip flag instead of manual archiving
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-15 21:08:55 -08:00
Nikolaj Bjorner
76182c7e66
fix #8195
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-15 14:39:29 -08:00
Copilot
be2d7ecb91
Change code-conventions-analyzer workflow discussion category to "Agentic Workflows" ( #8203 )
...
* Initial plan
* Update code-conventions-analyzer discussion category to "Agentic Workflows"
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-15 12:45:47 -08:00
Copilot
6df16fad9c
Update api-coherence-checker workflow to use "Agentic Workflows" discussion category ( #8202 )
...
* Initial plan
* Update api-coherence-checker to use "Agentic Workflows" discussion category
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-15 12:45:13 -08:00
Nikolaj Bjorner
778ed22dbf
simplify contains check
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-15 12:01:44 -08:00
Ilana Shapiro
1d1fc69be3
Add core strengthening and non-chronological backtracking to parallel search tree ( #8193 )
...
* restore more aggressive pruning in search tree
* restore where we close children to be correct
* add core strengthening check
* fix recursion bug
* less strict core propagation
* old search tree version
* restore search tree patch
* remove flag
---------
Co-authored-by: Ilana Shapiro <ilanashapiro@Mac.localdomain>
Co-authored-by: Ilana Shapiro <ilanashapiro@Ilanas-MacBook-Pro.local>
Co-authored-by: Ilana Shapiro <ilanashapiro@Ilanas-MBP.lan1>
2026-01-15 11:49:18 -08:00
Copilot
7d4964a2f0
Fix api-coherence workflow to verify and filter resolved issues ( #8201 )
...
* Initial plan
* Update api-coherence workflow to verify and filter resolved issues
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-15 11:40:26 -08:00
Copilot
2436943794
Standardize for-loop increments to prefix form (++i) ( #8199 )
...
* Initial plan
* Convert postfix to prefix increment in for loops
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Fix member variable increment conversion bug
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Update API generator to produce prefix increments
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-14 19:55:31 -08:00
Copilot
1bf463d77a
Replace manual pair unpacking with structured bindings ( #8197 )
...
* Initial plan
* Apply structured bindings to enode_bool_pair usage
Replace manual unpacking of pairs with C++17 structured bindings in:
- src/ast/euf/euf_egraph.cpp
- src/smt/smt_internalizer.cpp
- src/smt/smt_context.cpp (2 locations)
This improves code readability and reduces boilerplate code.
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-14 19:52:01 -08:00
Copilot
e7f9a31b25
Replace remaining NULL with nullptr ( #8198 )
...
* Initial plan
* Replace NULL with nullptr in spacer_context.cpp
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-14 19:50:44 -08:00
Copilot
896e297bd4
Update ARM GCC toolchain to 13.3 for C++20 std::format support ( #8196 )
...
* Initial plan
* Update ARM GCC toolchain from 11.2 to 13.3 for C++20 std::format support
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-14 17:09:06 -08:00
Nikolaj Bjorner
a2605e7b66
remove RCF example
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-14 17:07:25 -08:00
Nuno Lopes
1d8c50ebd6
fix build
2026-01-14 18:54:16 +00:00
Copilot
c5b28950d5
Remove redundant overridden default destructors ( #8191 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-14 18:41:26 +00:00
Lev Nachmanson
ece691285e
throw an algebraic exception on a failure of m_limit.inc() instead of returning sign_zero
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-01-14 07:23:26 -10:00
Nuno Lopes
888d2fc480
copilot: don't use std::format and try using clang-tidy
2026-01-14 09:17:49 +00:00
Lev Nachmanson
d5e0216070
Revert "Merge pull request #8190 from Z3Prover/copilot/fix-std-format-usage"
...
This reverts commit d9bdb6b83c , reversing
changes made to 8b188621a5 .
2026-01-13 18:18:07 -10:00
Copilot
3bf271bb42
Enhance Code Conventions Analyzer for empty constructors and non-virtual destructors ( #8192 )
...
* Initial plan
* Enhance Code Conventions Analyzer for empty constructors and non-virtual destructors
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-13 18:57:10 -08:00
Lev Nachmanson
d9bdb6b83c
Merge pull request #8190 from Z3Prover/copilot/fix-std-format-usage
...
Modernize string formatting from std::ostringstream to std::format
2026-01-13 13:54:00 -10:00
copilot-swe-agent[bot]
0c2ea345fb
Fix spacing in error message
...
Co-authored-by: levnach <5377127+levnach@users.noreply.github.com>
2026-01-13 21:36:14 +00:00
copilot-swe-agent[bot]
64957e2b0e
Modernize more files to use std::format: bv_decl_plugin, dl_decl_plugin, datatype_decl_plugin, seq_decl_plugin
...
Co-authored-by: levnach <5377127+levnach@users.noreply.github.com>
2026-01-13 21:34:47 +00:00
copilot-swe-agent[bot]
99a40e79d4
Modernize ostringstream to std::format in ast.cpp and array_decl_plugin.cpp
...
Co-authored-by: levnach <5377127+levnach@users.noreply.github.com>
2026-01-13 21:29:51 +00:00
copilot-swe-agent[bot]
d274181c1f
Initial plan
2026-01-13 21:07:21 +00:00
Nikolaj Bjorner
8b188621a5
coerce bool
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-13 11:45:57 -08:00
Nikolaj Bjorner
c78d5405d1
update iterator pattern
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-13 11:33:15 -08:00
Simon Jeanteur
deaced1711
Subterms Theory ( #8115 )
...
* somewhaat failed attempt at declaring subterm predicate
I can't really figure out how to link the smt parser to the rest of the
machinenery, so I will stop here and try from the other side. I'll start
implmenting the logic and see if it brings me back to the parser.
* initial logic implmentation
Very primitive, but I don't like have that much work uncommitted.
* parser implementation
* more theory
* Working base
* subterm reflexivity
* a few optimization
Skip adding obvious equalities or disequality
* removed some optimisations
* better handling of backtracking
* stupid segfault
Add m_subterm to the trail
* Update src/smt/theory_datatype.h
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update src/ast/rewriter/datatype_rewriter.cpp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update src/smt/theory_datatype.cpp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update src/smt/theory_datatype.cpp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update src/smt/theory_datatype.cpp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* review
* forgot to update `iterate_subterm`'s signature
* fix iterator segfault
* Remove duplicate include statement
Removed duplicate include of 'theory_datatype.h'.
* Replace 'optional' with 'std::option' in datatype_decl_plugin.h
* Add is_subterm_predicate matcher to datatype_decl_plugin
* Change std::option to std::optional for m_subterm
* Update pdecl.h
* Change has_subterm to use has_value method
* Update pdecl.cpp
---------
Co-authored-by: Nikolaj Bjorner <nbjorner@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-01-13 10:53:17 -08:00
Copilot
7377d28c30
Replace empty destructors with = default for compiler optimization ( #8189 )
...
* Initial plan
* Replace empty destructors with = default
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-13 10:50:10 -08:00
Nikolaj Bjorner
a0bca2b71a
Add workflow_dispatch trigger to wip.yml
2026-01-13 10:49:33 -08:00
Nikolaj Bjorner
1806e8bb33
Update pyodide.yml
2026-01-13 10:48:34 -08:00
Copilot
635c7ea32e
Extend code-conventions-analyzer workflow with Z3-specific C++ modernization patterns ( #8187 )
...
* Initial plan
* Update code-conventions-analyzer workflow with modern C++ preferences
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-13 09:35:57 -08:00
Nikolaj Bjorner
5d0be96fd1
update RCFNum
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-13 09:22:43 -08:00
Nikolaj Bjorner
c2cf11672a
update python example
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-13 09:17:01 -08:00
Nikolaj Bjorner
38d67b3c59
removing file to deal with build issue
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-13 09:15:14 -08:00
Nikolaj Bjorner
eca8e19231
remove debug output
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-01-12 21:52:44 -08:00
Copilot
daefb4ddfd
Fix unused parameter warnings in empty override functions by omitting parameter names ( #8174 )
...
* Initial plan
* Fix unused parameter warnings in empty override functions
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Omit parameter names in empty override functions instead of casting to void
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-12 21:27:33 -08:00
dependabot[bot]
bb6cd7cd0e
Bump actions/setup-dotnet from 4.3.1 to 5.0.1 ( #8175 )
...
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet ) from 4.3.1 to 5.0.1.
- [Release notes](https://github.com/actions/setup-dotnet/releases )
- [Commits](67a3573c9a...2016bd2012 )
---
updated-dependencies:
- dependency-name: actions/setup-dotnet
dependency-version: 5.0.1
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-12 20:45:55 -08:00
dependabot[bot]
6023b4c406
Bump actions/download-artifact from 6.0.0 to 7.0.0 ( #8176 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](https://github.com/actions/download-artifact/compare/v6...v7 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 7.0.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-12 20:45:41 -08:00
dependabot[bot]
df95e219b4
Bump actions/setup-java from 4.8.0 to 5.1.0 ( #8177 )
...
Bumps [actions/setup-java](https://github.com/actions/setup-java ) from 4.8.0 to 5.1.0.
- [Release notes](https://github.com/actions/setup-java/releases )
- [Commits](c1e323688f...f2beeb24e1 )
---
updated-dependencies:
- dependency-name: actions/setup-java
dependency-version: 5.1.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-12 20:45:23 -08:00
dependabot[bot]
b9b1ae56f2
Bump actions/checkout from 4.2.2 to 6.0.1 ( #8178 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.2 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Commits](https://github.com/actions/checkout/compare/v4.2.2...v6.0.1 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.1
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-12 20:45:10 -08:00
dependabot[bot]
aeb7f7eb51
Bump astral-sh/setup-uv from 5.4.2 to 7.2.0 ( #8179 )
...
Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv ) from 5.4.2 to 7.2.0.
- [Release notes](https://github.com/astral-sh/setup-uv/releases )
- [Commits](d4b2f3b6ec...61cb8a9741 )
---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
dependency-version: 7.2.0
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-12 20:44:56 -08:00