Copilot
295dbc601d
Eliminate unnecessary copies with std::move for ref-counted types ( #8591 )
2026-02-13 12:18:25 +00:00
Nikolaj Bjorner
21cb8b3b01
Modify behavior for division by zero
...
Allow division by zero in z3 expressions without raising an error.
2026-02-13 12:18:25 +00:00
Nikolaj Bjorner
b27a8a0d5f
Delete src/api/python/test_critical_fixes.py
2026-02-13 12:18:25 +00:00
copilot-swe-agent[bot]
3113759dab
Fix error message capitalization for Python conventions
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-13 12:18:25 +00:00
copilot-swe-agent[bot]
8b6aa64f37
Add comprehensive tests for Python API bug fixes
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-13 12:18:25 +00:00
copilot-swe-agent[bot]
c6eb275130
Fix 9 critical assert statements and RatVal division by zero (Priority 1)
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-13 12:18:25 +00:00
Nikolaj Bjorner
e2cf229df2
Remove assertion for number of watches in normalize
2026-02-13 12:18:25 +00:00
copilot-swe-agent[bot]
27169eb0f7
Fix BOUNDS and ASSERT_FAIL issues in Python API
...
- Add negative index support to AstVector.__setitem__, ModelRef.__getitem__, ApplyResult.__getitem__
- Replace bare assertions with proper Z3Exception in z3num.Numeral methods
- All changes tested and validated with comprehensive test suite
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-13 12:18:25 +00:00
copilot-swe-agent[bot]
fce08b2941
Remove custom starts_with methods in favor of C++20 std::string::starts_with
...
The custom starts_with() helper methods are redundant since Z3 uses C++20,
which includes std::string::starts_with() as a member function. Updated all
call sites to use the standard library method.
Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
2026-02-12 08:24:53 +00:00
copilot-swe-agent[bot]
bb177988eb
Apply code simplification improvements
...
- Consolidated two contains() methods into single template function
- Added const correctness to helper methods in argument_parser.h
- Improved string handling (replaced substr with compare, return "" instead of std::string())
- Fixed indentation in nlsat_solver.cpp nested loop
- Modernized empty container return syntax in lp.cpp
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-12 02:59:21 +00:00
Nikolaj Bjorner
ae51cb04ba
#8552
...
make it recompile constraints with duplicates
2026-02-11 17:38:45 -08:00
Nikolaj Bjorner
fb172b67ac
small update to testing on p.m_sls_worker instead of should_run_sls
2026-02-11 17:38:45 -08:00
Copilot
20fef3f449
Eliminate unnecessary copy operations in function parameters and range-based loops ( #8589 )
2026-02-11 21:14:32 +00:00
Nuno Lopes
836a76c78a
Remove copies ( #8583 )
2026-02-11 18:14:36 +00:00
Nikolaj Bjorner
ffd9207bc5
fix #8572
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-10 20:22:27 -08:00
Nikolaj Bjorner
9f35314188
fix #8552
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-10 17:21:14 -08:00
Nikolaj Bjorner
e6c05d55a7
fix another regression by Nuno's changes
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-10 15:42:23 -08:00
Lev Nachmanson
850cc3e120
relax a too strong assert
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-10 13:24:52 -10:00
Copilot
eec25c1ad8
Simplify svector assignment operators using = default ( #8566 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-10 22:27:42 +00:00
Nikolaj Bjorner
4d635340d9
fix build of test
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-02-10 12:56:13 -08:00
Nuno Lopes
de26d8f6f7
revert swap changes to fix CI
2026-02-10 19:30:49 +00:00
Nikolaj Bjorner
a7b9df14f4
fix build warnings and scoop up after Nuno's leaks
2026-02-10 09:32:26 -08:00
Nuno Lopes
bcca975d2d
fix crash
2026-02-10 10:33:36 +00:00
Nuno Lopes
915ad35012
remove a few copies
2026-02-10 09:52:03 +00:00
Nuno Lopes
617c621cc0
replace some copies with moves
2026-02-09 22:45:28 +00:00
Nikolaj Bjorner
73844f9a7f
set random seed directly on m_smt_params before context initialization
...
updates to random seed on ctx does not get propagated to arithmetic solver, preventing diversity within arithmetic solver.
2026-02-09 14:44:08 -08:00
Nuno Lopes
30f5500b1e
move, dont copy
2026-02-09 21:51:48 +00:00
Nuno Lopes
a1d484c4a8
move, dont copy
2026-02-09 19:41:39 +00:00
Copilot
921006f628
Replace user-defined swap with C++11 move semantics for covert move patterns ( #8543 )
2026-02-09 17:52:30 +00:00
Lev Nachmanson
dd09603f4d
fix the logic of adding all coefficients and blocking double insertions in m_todo
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-08 15:01:51 -10:00
Nikolaj Bjorner
c269421942
Revert "mpz: use pointer tagging to save space ( #8447 )"
...
This reverts commit 2f4abe2ce6 .
2026-02-08 14:48:21 -08:00
Nikolaj Bjorner
8eff8dc9c8
Merge branch 'master' into copilot/update-nightly-build-test-process
2026-02-08 11:28:21 -08:00
Copilot
c0be7ac621
Remove unused swap() methods ( #8538 )
2026-02-08 18:53:43 +00:00
Lev Nachmanson
56db8d5e98
fix nlsat_explain.cpp that the regression tests would pass with lws=false
...
Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
2026-02-08 08:40:49 -10:00
copilot-swe-agent[bot]
e685ea45ed
Fix OCaml linker flag and align validation runners with build runners
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-08 17:26:30 +00:00
copilot-swe-agent[bot]
34d2d08364
Fix CMake variable name and clarify test path documentation
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-08 17:24:18 +00:00
copilot-swe-agent[bot]
af76ac69d6
Apply headerpad fix to build systems (Python and CMake) and fix validation test paths
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-08 17:23:04 +00:00
Nikolaj Bjorner
72564da251
Merge pull request #8535 from Z3Prover/copilot/fix-install-name-tool-issue
...
Add -headerpad_max_install_names to all macOS dylib builds
2026-02-08 09:13:57 -08:00
Copilot
47897d6fb6
Store rational by value in parameter variant ( #8518 )
...
Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
2026-02-08 12:17:13 +00:00
Nuno Lopes
6ed5b6d667
constructor
2026-02-08 11:56:00 +00:00
Copilot
2f4abe2ce6
mpz: use pointer tagging to save space ( #8447 )
...
Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
2026-02-08 11:55:14 +00:00
Nuno Lopes
3a4f1fd65a
remove redundant assert
2026-02-08 11:27:17 +00:00
copilot-swe-agent[bot]
a08e8a99f9
Add -headerpad_max_install_names flag for macOS dylib builds
...
This fixes the install_name_tool issue on macOS where the tool fails
with "larger updated load commands do not fit". The linker flag
-Wl,-headerpad_max_install_names ensures sufficient header padding
in the Mach-O binary for install_name_tool to modify install names.
Changes made:
- CMake: Added flag to libz3, z3java, z3jl shared libraries on Darwin
- Python build: Changed flag from ML-only to all macOS builds
- OCaml CMake: Added flag to OCaml stublib build on APPLE
Fixes #7623 (regression in 4.15.5)
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-08 03:26:13 +00:00
Nikolaj Bjorner
3f5810a365
Merge pull request #8531 from Z3Prover/copilot/fix-build-warnings-again
...
Fix MSVC C4267 warnings in initializer_list overloads
2026-02-07 18:45:52 -08:00
Lev Nachmanson
f5b8dfc2f1
Revert "optionally throttle patch_basic_columns() especially useful in unsat cases"
...
This reverts commit bee2b45743 .
2026-02-07 10:45:15 -10:00
Lev Nachmanson
73696725e4
Revert "try fixed int patch period"
...
This reverts commit 3e2027ec11 .
2026-02-07 10:45:15 -10:00
copilot-swe-agent[bot]
8b42b190a0
Fix build warnings: cast size_t to unsigned in arith_decl_plugin.h and bv_decl_plugin.h
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-02-07 19:49:28 +00:00
Nikolaj Bjorner
3bd5b5a5d4
Merge pull request #8500 from Z3Prover/copilot/update-functional-datatype
...
Add datatype_update_field to C++, Python, TypeScript, and OCaml bindings
2026-02-07 10:11:54 -08:00
Nikolaj Bjorner
8978f1549b
Merge pull request #8509 from Z3Prover/copilot/fix-build-warnings
...
Fix compiler warnings: unused variables, uninitialized variable, and false positive array bounds
2026-02-07 05:10:02 -08:00
Nikolaj Bjorner
f26f570ec7
Merge pull request #8521 from Z3Prover/copilot/add-static-linkage-functions
...
Add static linkage to file-local function
2026-02-07 05:08:00 -08:00