Merge pull request #8509 from Z3Prover/copilot/fix-build-warnings

Fix compiler warnings: unused variables, uninitialized variable, and false positive array bounds

src/muz/rel/udoc_relation.cpp

@@ -282,7 +282,6 @@ namespace datalog {
         return false;
     }
     unsigned udoc_plugin::num_sort_bits(sort* s) const {
-        unsigned num_bits = 0;
         if (bv.is_bv_sort(s))
             return bv.get_bv_size(s);
         if (m.is_bool(s)) 

src/smt/dyn_ack.cpp

@@ -356,7 +356,7 @@ namespace smt {
         m_context.m_stats.m_num_del_dyn_ack++;
         app_pair p((app*)nullptr,(app*)nullptr);
         if (m_clause2app_pair.find(cls, p)) {
-            auto [a1, a2] = p;
+            [[maybe_unused]] auto [a1, a2] = p;
             SASSERT(a1 && a2);
             m_instantiated.erase(p);
             m_clause2app_pair.erase(cls);
@@ -365,7 +365,7 @@ namespace smt {
         }
         app_triple tr(0,0,0);
         if (m_triple.m_clause2apps.find(cls, tr)) {
-            auto [a1, a2, a3] = tr;
+            [[maybe_unused]] auto [a1, a2, a3] = tr;
             SASSERT(a1 && a2 && a3);
             m_triple.m_instantiated.erase(tr);
             m_triple.m_clause2apps.erase(cls);

src/smt/smt_context.cpp

@@ -2408,7 +2408,7 @@ namespace smt {
        \warning This method will not invoke reset_cache_generation.
     */
     unsigned context::pop_scope_core(unsigned num_scopes) {
-        unsigned units_to_reassert_lim;
+        unsigned units_to_reassert_lim = 0;
 
         try {
             if (m.has_trace_stream() && !m_is_auxiliary)

src/smt/theory_lra.cpp

@@ -3446,7 +3446,7 @@ public:
             break;
         }
         case equality_source: {
-            auto [n1, n2] = m_equalities[idx];
+            [[maybe_unused]] auto [n1, n2] = m_equalities[idx];
             SASSERT(n1 != nullptr);
             SASSERT(n2 != nullptr);
             m_eqs.push_back(m_equalities[idx]);          

src/util/vector.h

@@ -405,7 +405,14 @@ public:
         if (CallDestructors) {
             back().~T(); 
         }
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
         reinterpret_cast<SZ *>(m_data)[SIZE_IDX]--; 
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic pop
+#endif
     }
 
     vector& push_back(T const & elem) {