3
0
Fork 0
mirror of https://github.com/YosysHQ/yosys synced 2025-10-10 09:48:06 +00:00

Tests: Prefer single quotes for regex

Replaces double quotes on problematic regex strings (mostly ones that have escape sequences that are easier to preserve in single quotes).  Necessitates also changing single quotes to `.`, i.e match any.
For some (mostly ones that only have a single escaped character, or were using `\.` to match a literal fullstop) keep the double quotes and fix the regex instead.
This commit is contained in:
Krystine Sherwin 2025-10-06 14:22:18 +13:00
parent 4b4ea671e5
commit 1248af1e02
No known key found for this signature in database
43 changed files with 74 additions and 73 deletions

View file

@ -1,9 +1,9 @@
logger -expect log "SAT proof finished - no model found: SUCCESS!" 1 logger -expect log "SAT proof finished - no model found: SUCCESS!" 1
logger -expect log "Number of cells:.*[\t ]12" 1 logger -expect log 'Number of cells:.*[\t ]12' 1
logger -expect log "Number of cells:.*[\t ]20" 1 logger -expect log 'Number of cells:.*[\t ]20' 1
logger -expect log "Problem is satisfiable with \\gate.__glift_weight = 11." 1 logger -expect log 'Problem is satisfiable with \\gate.__glift_weight = 11.' 1
logger -expect log "Problem is NOT satisfiable with \\gate.__glift_weight <= 10." 1 logger -expect log 'Problem is NOT satisfiable with \\gate.__glift_weight <= 10.' 1
logger -expect log "Wire \\gate.__glift_weight is minimized at 11." 1 logger -expect log 'Wire \\gate.__glift_weight is minimized at 11.' 1
logger -expect log "Specializing .* from file with .* = 1." 2 logger -expect log "Specializing .* from file with .* = 1." 2
logger -expect log "Specializing .* from file with .* = 0." 4 logger -expect log "Specializing .* from file with .* = 0." 4
read_verilog <<EOT read_verilog <<EOT

View file

@ -1,5 +1,5 @@
logger -nowarn "Yosys has only limited support for tri-state logic at the moment\. .*" logger -nowarn "Yosys has only limited support for tri-state logic at the moment. .*"
logger -nowarn "Ignoring boxed module .*\." logger -nowarn "Ignoring boxed module .*."
read_verilog <<EOT read_verilog <<EOT
module top(input C, D, output [7:0] Q); module top(input C, D, output [7:0] Q);
@ -53,10 +53,10 @@ FDCE_1 /*#(.INIT(1))*/ fd7(.C(C), .CE(1'b0), .D(D), .CLR(1'b0), .Q(Q[6]));
FDPE_1 #(.INIT(1)) fd8(.C(C), .CE(1'b0), .D(D), .PRE(1'b0), .Q(Q[7])); FDPE_1 #(.INIT(1)) fd8(.C(C), .CE(1'b0), .D(D), .PRE(1'b0), .Q(Q[7]));
endmodule endmodule
EOT EOT
logger -expect warning "Whitebox '\$paramod\\FDRE\\INIT=.*1' with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\." 1 logger -expect warning 'Whitebox .\$paramod\\FDRE\\INIT=.*1. with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\.' 1
logger -expect warning "Whitebox '\$paramod\\FDRE_1\\INIT=.*1' with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\." 1 logger -expect warning 'Whitebox .\$paramod\\FDRE_1\\INIT=.*1. with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\.' 1
logger -expect warning "Whitebox 'FDSE' with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\." 1 logger -expect warning 'Whitebox .FDSE. with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\.' 1
logger -expect warning "Whitebox '\$paramod\\FDSE_1\\INIT=.*1' with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\." 1 logger -expect warning 'Whitebox .\$paramod\\FDSE_1\\INIT=.*1. with \(\* abc9_flop \*\) contains a \$dff cell with non-zero initial state -- this is not supported for ABC9 sequential synthesis. Treating as a blackbox\.' 1
read_verilog -lib +/xilinx/cells_sim.v read_verilog -lib +/xilinx/cells_sim.v
equiv_opt -assert -multiclock -map +/xilinx/cells_sim.v synth_xilinx -abc9 -dff -noiopad -noclkbuf equiv_opt -assert -multiclock -map +/xilinx/cells_sim.v synth_xilinx -abc9 -dff -noiopad -noclkbuf
design -load postopt design -load postopt

View file

@ -4,12 +4,13 @@ logger -expect-no-warnings
logger -expect log "quoted space" 1 logger -expect log "quoted space" 1
logger -expect log "quoted" 2 logger -expect log "quoted" 2
logger -expect log "space" 2 logger -expect log "space" 2
logger -expect log '\\"escaped' 1 logger -expect log '"escaped' 2
logger -expect log 'quotes\\"' 1 logger -expect log 'quotes"' 2
test_args unquoted space test_args unquoted space
test_args "quoted space" test_args "quoted space"
test_args \"escaped quotes\" test_args "\"escaped quotes\""
test_args '"escaped quotes"'
logger -check-expected logger -check-expected

View file

@ -24,6 +24,6 @@ select -assert-mod-count 2 =*
logger -check-expected logger -check-expected
logger -expect warning "Selection .wb. did not match any module\." 1 logger -expect warning "Selection .wb. did not match any module." 1
logger -expect error "No top module found in source design\." 1 logger -expect error "No top module found in source design." 1
design -import read -as new_wb wb design -import read -as new_wb wb

View file

@ -6,5 +6,5 @@ EOT
select -set foo w:* select -set foo w:*
select -assert-any @foo select -assert-any @foo
select -unset foo select -unset foo
logger -expect error "Selection '\\foo' does not exist!" 1 logger -expect error 'Selection .\\foo. does not exist!' 1
select -unset foo select -unset foo

View file

@ -1,12 +1,12 @@
logger -expect-no-warnings logger -expect-no-warnings
logger -expect warning "reg '\\var_12' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_12. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_13' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_13. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_14' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_14. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_15' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_15. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_16' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_16. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_17' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_17. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_18' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_18. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_19' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_19. is assigned in a continuous assignment' 1
read_verilog -sv typedef_initial_and_assign.sv read_verilog -sv typedef_initial_and_assign.sv
hierarchy; proc; opt; async2sync hierarchy; proc; opt; async2sync

View file

@ -1,5 +1,5 @@
logger -expect log ".*cells_not_processed=[01]* .*" 1 logger -expect log ".*cells_not_processed=[01]* .*" 1
logger -expect log ".*src=.<<EOT:1\.1-9\.10. .*" 1 logger -expect log '.*src=.<<EOT:1\.1-9\.10. .*' 1
read_verilog <<EOT read_verilog <<EOT
module mux2(a, b, s, y); module mux2(a, b, s, y);
input a, b, s; input a, b, s;

View file

@ -1,5 +1,5 @@
logger -expect warning "wire '\\o' is assigned in a block at <<EOT:2.11-2.17" 1 logger -expect warning 'wire .\\o. is assigned in a block at <<EOT:2.11-2.17' 1
logger -expect warning "wire '\\p' is assigned in a block at <<EOT:3.11-3.16" 1 logger -expect warning 'wire .\\p. is assigned in a block at <<EOT:3.11-3.16' 1
read_verilog <<EOT read_verilog <<EOT
module top(input i, output o, p); module top(input i, output o, p);
always @* o <= i; always @* o <= i;

View file

@ -11,7 +11,7 @@ buffer b(.i(i), .o(w));
endmodule endmodule
EOT EOT
logger -expect warning "Critical-path does not terminate in a recognised endpoint\." 1 logger -expect warning "Critical-path does not terminate in a recognised endpoint." 1
sta sta
@ -22,7 +22,7 @@ assign o = i;
endmodule endmodule
EOT EOT
logger -expect log "No timing paths found\." 1 logger -expect log "No timing paths found." 1
sta sta
@ -56,7 +56,7 @@ const0 c(.o(p));
endmodule endmodule
EOT EOT
logger -expect warning "Cell type 'const0' not recognised! Ignoring\." 1 logger -expect warning "Cell type 'const0' not recognised! Ignoring." 1
sta sta

View file

@ -9,7 +9,7 @@ module \top
end end
end end
EOT EOT
logger -expect log "Chip area for module '\\top': 9.072000" 1 logger -expect log 'Chip area for module .\\top.: 9.072000' 1
logger -expect-no-warnings logger -expect-no-warnings
logger -expect log " 1 9.072 cells" 1 logger -expect log " 1 9.072 cells" 1
logger -expect log " 1 9.072 sg13g2_and2_1" 1 logger -expect log " 1 9.072 sg13g2_and2_1" 1
@ -70,7 +70,7 @@ module \child
end end
EOT EOT
logger -expect log "Chip area for top module '\\top': 112.492800" 1 logger -expect log 'Chip area for top module .\\top.: 112.492800' 1
logger -expect log "of which used for sequential elements: 94.348800" 1 logger -expect log "of which used for sequential elements: 94.348800" 1
logger -expect log "2 18.144 cells" 1 logger -expect log "2 18.144 cells" 1
logger -expect log "4 112.493 cells" 1 logger -expect log "4 112.493 cells" 1

View file

@ -82,9 +82,9 @@ module \child
end end
EOT EOT
logger -expect log "Chip area for top module '\\top': 66.000000" 1 logger -expect log 'Chip area for top module .\\top.: 66.000000' 1
logger -expect log "3 30.5 3 30.5 cells" 1 logger -expect log "3 30.5 3 30.5 cells" 1
logger -expect log "2 51 - - \$reduce_xor" 2 logger -expect log "2 51 - - \\$reduce_xor" 2
logger -expect log "8 66 2 5 cells" 2 logger -expect log "8 66 2 5 cells" 2
logger -expect-no-warnings logger -expect-no-warnings
stat -liberty ./stat_area_by_width.lib -top \top -hierarchy stat -liberty ./stat_area_by_width.lib -top \top -hierarchy

View file

@ -81,8 +81,8 @@ module \child
end end
EOT EOT
logger -expect log "Chip area for top module '\\top': 80.000000" 1 logger -expect log 'Chip area for top module .\\top.: 80.000000' 1
logger -expect log "1 12 1 12 \$bmux" 1 logger -expect log "1 12 1 12 \\$bmux" 1
logger -expect log "3 37.5 3 37.5 cells" 1 logger -expect log "3 37.5 3 37.5 cells" 1
logger -expect log "8 80 2 5 cells" 2 logger -expect log "8 80 2 5 cells" 2
logger -expect-no-warnings logger -expect-no-warnings

View file

@ -1,5 +1,5 @@
# Check that we spot mismatched brackets # Check that we spot mismatched brackets
logger -expect error "Mismatched brackets in macro argument: \[ and }." 1 logger -expect error "Mismatched brackets in macro argument: \\[ and }." 1
read_verilog <<EOT read_verilog <<EOT
`define foo(x=[1,2}) `define foo(x=[1,2})
EOT EOT

View file

@ -1,6 +1,6 @@
# Check that we don't allow passing too few arguments (and, while we're at it, check that passing "no" # Check that we don't allow passing too few arguments (and, while we're at it, check that passing "no"
# arguments actually passes 1 empty argument). # arguments actually passes 1 empty argument).
logger -expect error "Cannot expand macro `foo by giving only 1 argument \(argument 2 has no default\)." 1 logger -expect error 'Cannot expand macro `foo by giving only 1 argument \(argument 2 has no default\).' 1
read_verilog <<EOT read_verilog <<EOT
`define foo(x=1, y) `define foo(x=1, y)
`foo() `foo()

View file

@ -9,5 +9,5 @@ always_comb begin
end end
endmodule endmodule
EOF EOF
logger -expect error "^Latch inferred for signal `\\top\.\$unnamed_block\$1\.y' from always_comb process" 1 logger -expect error '^Latch inferred for signal `\\top\.\$unnamed_block\$1\.y. from always_comb process' 1
proc proc

View file

@ -11,5 +11,5 @@ always_comb begin
end end
endmodule endmodule
EOF EOF
logger -expect error "^Latch inferred for signal `\\top\.\$unnamed_block\$1\.y' from always_comb process" 1 logger -expect error '^Latch inferred for signal `\\top\.\$unnamed_block\$1\.y. from always_comb process' 1
proc proc

View file

@ -16,5 +16,5 @@ always_comb begin
end end
endmodule endmodule
EOF EOF
logger -expect error "^Latch inferred for signal `\\top\.\$unnamed_block\$1\.y' from always_comb process" 1 logger -expect error '^Latch inferred for signal `\\top\.\$unnamed_block\$1\.y. from always_comb process' 1
proc proc

View file

@ -13,5 +13,5 @@ always_comb begin
end end
endmodule endmodule
EOF EOF
logger -expect error "^Latch inferred for signal `\\top\.\$unnamed_block\$3\.y' from always_comb process" 1 logger -expect error '^Latch inferred for signal `\\top\.\$unnamed_block\$3\.y. from always_comb process' 1
proc proc

View file

@ -1,4 +1,4 @@
logger -expect error "Begin label missing where end label \(incorrect_name\) was given\." 1 logger -expect error 'Begin label missing where end label \(incorrect_name\) was given\.' 1
read_verilog -sv <<EOF read_verilog -sv <<EOF
module top; module top;
initial initial

View file

@ -1,4 +1,4 @@
logger -expect error "Begin label \(correct_name\) and end label \(incorrect_name\) don't match\." 1 logger -expect error 'Begin label \(correct_name\) and end label \(incorrect_name\) don.t match\.' 1
read_verilog -sv <<EOF read_verilog -sv <<EOF
module top; module top;
initial initial

View file

@ -15,7 +15,7 @@ module foo2;
endmodule endmodule
EOT EOT
logger -expect error "Begin label \(a\) and end label \(b\) don't match\." 1 logger -expect error 'Begin label \(a\) and end label \(b\) don.t match\.' 1
read_verilog <<EOT read_verilog <<EOT
module foo3; module foo3;

View file

@ -1,4 +1,4 @@
logger -expect error "Failed to detect width for identifier \\genblk1\.y!" 1 logger -expect error 'Failed to detect width for identifier \\genblk1\.y!' 1
read_verilog <<EOT read_verilog <<EOT
module top1; module top1;
wire x; wire x;

View file

@ -1,4 +1,4 @@
logger -expect error "Cannot add procedural assertion `\\x' because a signal with the same name was already created" 1 logger -expect error 'Cannot add procedural assertion `\\x. because a signal with the same name was already created' 1
read_verilog -sv <<EOT read_verilog -sv <<EOT
module top; module top;
wire x, y; wire x, y;

View file

@ -1,4 +1,4 @@
logger -expect error "Cannot add cell `\\x' because a memory with the same name was already created" 1 logger -expect error 'Cannot add cell `\\x. because a memory with the same name was already created' 1
read_verilog <<EOT read_verilog <<EOT
module mod; module mod;
endmodule endmodule

View file

@ -1,4 +1,4 @@
logger -expect error "Cannot add interface port `\\i' because a signal with the same name was already created" 1 logger -expect error 'Cannot add interface port `\\i. because a signal with the same name was already created' 1
read_verilog -sv <<EOT read_verilog -sv <<EOT
interface intf; interface intf;
logic x; logic x;

View file

@ -1,4 +1,4 @@
logger -expect error "Cannot add memory `\\x' because a signal with the same name was already created" 1 logger -expect error 'Cannot add memory `\\x. because a signal with the same name was already created' 1
read_verilog <<EOT read_verilog <<EOT
module top; module top;
reg [2:0] x; reg [2:0] x;

View file

@ -1,4 +1,4 @@
logger -expect error "Cannot add pwire `\\x' because a signal with the same name was already created" 1 logger -expect error 'Cannot add pwire `\\x. because a signal with the same name was already created' 1
read_verilog -pwires <<EOT read_verilog -pwires <<EOT
module top; module top;
wire x; wire x;

View file

@ -1,4 +1,4 @@
logger -expect error "Cannot add signal `\\x' because a memory with the same name was already created" 1 logger -expect error 'Cannot add signal `\\x. because a memory with the same name was already created' 1
read_verilog <<EOT read_verilog <<EOT
module top; module top;
reg [2:0] x [0:0]; reg [2:0] x [0:0];

View file

@ -1,4 +1,4 @@
logger -expect error "Begin label missing where end label \(incorrect_name\) was given\." 1 logger -expect error 'Begin label missing where end label \(incorrect_name\) was given\.' 1
read_verilog -sv <<EOF read_verilog -sv <<EOF
module top; module top;
if (1) if (1)

View file

@ -1,4 +1,4 @@
logger -expect error "Begin label \(correct_name\) and end label \(incorrect_name\) don't match\." 1 logger -expect error 'Begin label \(correct_name\) and end label \(incorrect_name\) don.t match\.' 1
read_verilog -sv <<EOF read_verilog -sv <<EOF
module top; module top;
if (1) if (1)

View file

@ -1,4 +1,4 @@
logger -expect error "Cannot declare module port `\\x' within a generate block\." 1 logger -expect error 'Cannot declare module port `\\x. within a generate block\.' 1
read_verilog <<EOT read_verilog <<EOT
module top(x); module top(x);
generate generate

View file

@ -1,4 +1,4 @@
logger -expect error "Identifier `\\y' is implicitly declared and `default_nettype is set to none" 1 logger -expect error 'Identifier `\\y. is implicitly declared and `default_nettype is set to none' 1
read_verilog <<EOT read_verilog <<EOT
`default_nettype none `default_nettype none
module top1; module top1;

View file

@ -8,7 +8,7 @@ EOT
design -reset design -reset
logger -expect error "Expected to find '\(' to begin macro arguments for 'MACRO', but instead found ';'" 1 logger -expect error "Expected to find '\\(' to begin macro arguments for 'MACRO', but instead found ';'" 1
read_verilog -sv <<EOT read_verilog -sv <<EOT
`define MACRO(a = 1, b = 2) initial $display("MACRO(a = %d, b = %d)", a, b) `define MACRO(a = 1, b = 2) initial $display("MACRO(a = %d, b = %d)", a, b)
module top; module top;

View file

@ -1,4 +1,4 @@
logger -expect error "Expected to find '\(' to begin macro arguments for 'foo', but instead found '\\x0a'" 1 logger -expect error 'Expected to find .\(. to begin macro arguments for .foo., but instead found .\\x0a.' 1
read_verilog -sv <<EOT read_verilog -sv <<EOT
`define foo(a=1) (a) `define foo(a=1) (a)
`foo `foo

View file

@ -7,7 +7,7 @@ EOF
design -reset design -reset
logger -expect error "Module name \(correct_name\) and end label \(incorrect_name\) don't match\." 1 logger -expect error 'Module name \(correct_name\) and end label \(incorrect_name\) don.t match\.' 1
read_verilog -sv <<EOF read_verilog -sv <<EOF
module correct_name; module correct_name;
localparam X = 1; localparam X = 1;

View file

@ -7,7 +7,7 @@ EOF
design -reset design -reset
logger -expect error "Package name \(correct_name\) and end label \(incorrect_name\) don't match\." 1 logger -expect error 'Package name \(correct_name\) and end label \(incorrect_name\) don.t match\.' 1
read_verilog -sv <<EOF read_verilog -sv <<EOF
package correct_name; package correct_name;
localparam X = 1; localparam X = 1;

View file

@ -8,5 +8,5 @@ module top;
endmodule endmodule
EOF EOF
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1 logger -expect error 'Parameter `\\X. has no default value and has not been overridden!' 1
hierarchy -top top hierarchy -top top

View file

@ -8,5 +8,5 @@ module top;
endmodule endmodule
EOF EOF
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1 logger -expect error 'Parameter `\\X. has no default value and has not been overridden!' 1
hierarchy -top top hierarchy -top top

View file

@ -8,5 +8,5 @@ module top;
endmodule endmodule
EOF EOF
logger -expect error "Parameter `\\Y' has no default value and has not been overridden!" 1 logger -expect error 'Parameter `\\Y. has no default value and has not been overridden!' 1
hierarchy -top top hierarchy -top top

View file

@ -8,5 +8,5 @@ module top;
endmodule endmodule
EOF EOF
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1 logger -expect error 'Parameter `\\X. has no default value and has not been overridden!' 1
hierarchy -top top hierarchy -top top

View file

@ -8,5 +8,5 @@ module top;
endmodule endmodule
EOF EOF
logger -expect error "Parameter `\\X' has no default value and has not been overridden!" 1 logger -expect error 'Parameter `\\X. has no default value and has not been overridden!' 1
hierarchy -top top hierarchy -top top

View file

@ -146,7 +146,7 @@ logger -check-expected
design -reset design -reset
# Test octal escape out of range. # Test octal escape out of range.
logger -expect warning "octal escape exceeds \\377" 1 logger -expect warning 'octal escape exceeds \\377' 1
read_verilog << EOF read_verilog << EOF
module top; module top;
wire[7:0] x = "\400"; wire[7:0] x = "\400";
@ -156,7 +156,7 @@ logger -check-expected
design -reset design -reset
# Test invalid octal digit. # Test invalid octal digit.
logger -expect warning "'\?' not a valid digit in octal escape sequence" 1 logger -expect warning "'\\?' not a valid digit in octal escape sequence" 1
read_verilog << EOF read_verilog << EOF
module top; module top;
wire[7:0] x = "\0?"; wire[7:0] x = "\0?";

View file

@ -1,9 +1,9 @@
logger -expect warning "wire '\\wire_1' is assigned in a block" 1 logger -expect warning 'wire .\\wire_1. is assigned in a block' 1
logger -expect warning "reg '\\reg_2' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\reg_2. is assigned in a continuous assignment' 1
logger -expect warning "reg '\\var_reg_2' is assigned in a continuous assignment" 1 logger -expect warning 'reg .\\var_reg_2. is assigned in a continuous assignment' 1
logger -expect warning "wire '\\wire_logic_1' is assigned in a block" 1 logger -expect warning 'wire .\\wire_logic_1. is assigned in a block' 1
logger -expect warning "wire '\\wire_integer_1' is assigned in a block" 1 logger -expect warning 'wire .\\wire_integer_1. is assigned in a block' 1
read_verilog -sv wire_and_var.sv read_verilog -sv wire_and_var.sv