copilot-swe-agent[bot]
4cdfceabc5
Use u_gcd from util/mpz.h instead of local gcd definition
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 04:24:16 +00:00
copilot-swe-agent[bot]
d267e452a2
Add Clemens Eisenhofer as co-author to nseq_parith.h and nseq_parikh.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 04:21:30 +00:00
Lev Nachmanson
274d64299e
Address PR review: add ENSURE checks, fix duplicate test, fix comment
...
- Add ENSURE(result == Z3_L_TRUE) for each BNH optimization call and
ENSURE(num_sat == 7) at the end so CI catches regressions.
- Remove test_bnh_optimize() from tst_api() to avoid duplicate
execution under /a; keep standalone tst_bnh_opt() entry point.
- Fix Test 2 comment: it tests same-size backup, not backup-longer.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-10 16:58:24 -10:00
Lev Nachmanson
6d890fb026
Fix NLA optimization regression and relax restore_x
...
- Relax restore_x() to handle backup/current size mismatches: when
backup is shorter (new columns added), call
move_non_basic_columns_to_bounds() to find a feasible solution.
- Fix 100x performance regression in nonlinear optimization: save LP
optimum before check_nla and return it as bound regardless of NLA
result, so opt_solver::check_bound() can validate via full re-solve
with accumulated NLA lemmas.
- Refactor theory_lra::maximize() into three helpers: max_with_lp(),
max_with_nl(), and max_result().
- Add mk_gt(theory_var, impq const&) overload for building blockers
from saved LP optimum values.
- Add BNH multi-objective optimization test (7/7 sat in <1s vs 1/7
in 30s before fix).
- Add restore_x test for backup size mismatch handling.
Fixes #8890
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-10 16:38:08 -10:00
copilot-swe-agent[bot]
334df71b11
Add nseq_parith.h and nseq_parikh.cpp: Parikh filter for ZIPT string solver
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 00:05:26 +00:00
copilot-swe-agent[bot]
3054f0cb41
Initial plan
2026-03-10 23:43:18 +00:00
Nikolaj Bjorner
51e245a245
Merge pull request #8935 from Z3Prover/copilot/implement-int-bounds-var-bound-watcher
...
Implement IntBounds/VarBoundWatcher + Constraint.Shared for Nielsen graph arithmetic pruning
2026-03-10 16:36:52 -07:00
Nikolaj Bjorner
53d5d98341
Merge branch 'c3' into copilot/implement-int-bounds-var-bound-watcher
2026-03-10 16:33:25 -07:00
copilot-swe-agent[bot]
57ede4cdcd
Address code review: clarify add_lower/upper_int_bound return semantics; fix test assertion
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 23:29:15 +00:00
copilot-swe-agent[bot]
47f9be0270
Implement IntBounds/VarBoundWatcher + Constraint.Shared; fix pre-existing build errors
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 23:26:55 +00:00
Nikolaj Bjorner
c3eb0056db
Merge pull request #8933 from Z3Prover/copilot/fix-build-error-nseq-zipt
...
Fix build: nseq_zipt fixture missing simple_solver arg to nielsen_graph
2026-03-10 15:49:46 -07:00
Nikolaj Bjorner
3a71f28c6c
Rename dummy_simple_solver to zipt_dummy_simple_solver
2026-03-10 15:49:24 -07:00
copilot-swe-agent[bot]
0efb7402e8
Fix build: add dummy_simple_solver to nseq_zipt.cpp fixture, fix assert_expr in seq_nielsen.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 22:47:49 +00:00
copilot-swe-agent[bot]
09f5d637b0
Initial plan
2026-03-10 22:44:11 +00:00
copilot-swe-agent[bot]
07ee2f31ef
Initial plan
2026-03-10 22:41:43 +00:00
Nikolaj Bjorner
d2739d9816
use reference to solver
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-10 15:22:50 -07:00
Nikolaj Bjorner
c98ea6dc21
make simple solver a reference
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-10 15:10:51 -07:00
Nikolaj Bjorner
3e3c3f106d
Merge pull request #8931 from Z3Prover/copilot/replace-lp-simple-solver
...
Replace lp_simple_solver in Nielsen graph with smt::kernel-based context_solver
2026-03-10 15:04:40 -07:00
copilot-swe-agent[bot]
5744958e46
Replace lp_simple_solver in nielsen with context_solver using smt::kernel (seq_len)
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 21:39:29 +00:00
copilot-swe-agent[bot]
a4f2c4a217
Initial plan
2026-03-10 21:09:43 +00:00
Nikolaj Bjorner
a8269c7d98
Merge pull request #8930 from Z3Prover/copilot/introduce-constraints-on-s
...
Use mod-based constraints for semi-linear regex length sets
2026-03-10 13:33:43 -07:00
copilot-swe-agent[bot]
334e6da60d
Guard mod constraint: skip for period <= 1
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 20:14:53 +00:00
Nikolaj Bjorner
2ec8a1231c
Merge pull request #8929 from Z3Prover/copilot/fix-build-warnings
...
Fix -Wunused-variable warnings in theory_finite_set, theory_finite_set_size, theory_nseq
2026-03-10 12:53:53 -07:00
copilot-swe-agent[bot]
2bae0f02c4
Replace fresh-variable semi-linear constraint with mod-based approach
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 19:48:18 +00:00
copilot-swe-agent[bot]
3a34517162
Initial plan
2026-03-10 19:29:33 +00:00
copilot-swe-agent[bot]
472d9bde6c
Fix unused variable build warnings in theory_finite_set, theory_finite_set_size, theory_nseq
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 18:52:40 +00:00
copilot-swe-agent[bot]
9c1d9af6d7
Initial plan
2026-03-10 18:49:44 +00:00
Nikolaj Bjorner
235448d929
Merge pull request #8928 from Z3Prover/copilot/update-release-notes
...
Add Version 4.17.0 release notes from discussion #8907
2026-03-10 11:48:19 -07:00
copilot-swe-agent[bot]
175a50330b
Update RELEASE_NOTES.md with additional Version 4.17.0 entries from discussion #8907
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 18:39:34 +00:00
copilot-swe-agent[bot]
240453e452
Initial plan
2026-03-10 18:38:06 +00:00
Nikolaj Bjorner
83c8743ea7
Merge pull request #8925 from Z3Prover/copilot/add-theory-seq-len-solver
...
Add theory_seq_len: partial sequence length axiomatization via semi-linear constraints
2026-03-10 11:36:33 -07:00
Nikolaj Bjorner
46e796114b
Merge pull request #8927 from Z3Prover/copilot/fix-build-error
...
Fix build error: remove stale dep_tracker method definitions
2026-03-10 11:34:58 -07:00
copilot-swe-agent[bot]
d4b99730b9
Fix build error: remove stale dep_tracker method definitions from seq_nielsen.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 18:30:33 +00:00
copilot-swe-agent[bot]
2e784a6ba3
Initial plan
2026-03-10 18:10:16 +00:00
copilot-swe-agent[bot]
56e9e9df57
Add theory_seq_len: partial axiom instantiation for sequence length constraints
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 18:02:04 +00:00
copilot-swe-agent[bot]
3ee78e242b
Initial plan
2026-03-10 17:39:57 +00:00
Nikolaj Bjorner
4ea4533f3b
Merge pull request #8924 from Z3Prover/copilot/replace-lp-solver-with-abstract-solver
...
Replace hardcoded lp_solver in seq_nielsen with abstract simple_solver interface
2026-03-10 10:35:57 -07:00
Nikolaj Bjorner
2e636ec25d
Merge branch 'c3' into copilot/replace-lp-solver-with-abstract-solver
2026-03-10 10:35:44 -07:00
Nikolaj Bjorner
3f0e821207
Merge pull request #8923 from Z3Prover/copilot/host-char-range-and-set
...
Move char_range and char_set from seq_nielsen to zstring
2026-03-10 10:18:58 -07:00
Nikolaj Bjorner
c710e1fa14
Merge pull request #8922 from Z3Prover/copilot/replace-dep-tracker-with-uint-set
...
Replace dep_tracker with uint_set in seq_nielsen
2026-03-10 10:18:37 -07:00
copilot-swe-agent[bot]
40b33ab353
Address code review: simplify constructor, add UNREACHABLE()
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 17:10:36 +00:00
copilot-swe-agent[bot]
35addda546
Replace lp_solver in seq_nielsen with abstract simple_solver class
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 17:08:57 +00:00
Nikolaj Bjorner
bb11a56a67
Merge pull request #8918 from Z3Prover/copilot/code-simplification-march-2026
...
Simplify conditional logic in sls_euf_plugin.cpp and extract sign condition helper in realclosure.cpp
2026-03-10 10:03:22 -07:00
copilot-swe-agent[bot]
5330bd20bc
Replace dep_tracker class in seq_nielsen with uint_set
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 16:58:50 +00:00
copilot-swe-agent[bot]
430a43045a
Move char_range and char_set from seq_nielsen to zstring
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 16:57:43 +00:00
Nikolaj Bjorner
08f4596cb7
Merge pull request #8921 from Z3Prover/copilot/update-file-headers-order
...
Swap author order in file headers: Clemens Eisenhofer before Nikolaj Bjorner
2026-03-10 09:50:07 -07:00
copilot-swe-agent[bot]
bf82bb0899
Initial plan
2026-03-10 16:46:03 +00:00
copilot-swe-agent[bot]
e3922f9f2b
Initial plan
2026-03-10 16:33:45 +00:00
copilot-swe-agent[bot]
f3018a563e
Initial plan
2026-03-10 16:32:10 +00:00
copilot-swe-agent[bot]
2f8cc1536c
Swap author order: Clemens Eisenhofer before Nikolaj Bjorner in file headers
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 16:27:26 +00:00