Henrich Lauko
96671cfc73
Add and fix a few general compiler warnings. ( #5628 )
...
* rewriter: fix unused variable warnings
* cmake: make missing non-virtual dtors error
* treewide: add missing virtual destructors
* cmake: add a few more checks
* api: add missing virtual destructor to user_propagator_base
* examples: compile cpp example with compiler warnings
* model: fix unused variable warnings
* rewriter: fix logical-op-parentheses warnings
* sat: fix unused variable warnings
* smt: fix unused variable warnings
2021-10-29 15:42:32 +02:00
Nikolaj Bjorner
94cc4ead72
remove arith_lhs simplification from preamble tactic
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-10-05 10:55:38 -07:00
Nikolaj Bjorner
62fd22f555
disable macro finder tactic if there are recursive functions fix #5574
2021-09-29 09:33:52 -07:00
Nikolaj Bjorner
6f31d83633
fix #5541
2021-09-20 10:10:28 -07:00
Nikolaj Bjorner
8bdc8d0e1a
Update solver_subsumption_tactic.h
...
use naming convention with - instead of _ for tactics
2021-09-01 11:35:06 -07:00
Nikolaj Bjorner
b3db9a1cd5
#5488
2021-08-18 08:30:08 -07:00
Nikolaj Bjorner
d1d64bbe59
#5454
2021-08-11 04:55:20 -07:00
Nikolaj Bjorner
4f2211baab
fix solver-subsumption again, #5468 (negation was swapped in original wrong subsumption check, then soundness fix removed core subsumption functionality)
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-08-11 04:36:48 -07:00
Nikolaj Bjorner
081cdbd762
fix #5468
2021-08-10 10:46:47 -07:00
Nikolaj Bjorner
391db898d3
lost update from August 3 #5468
2021-08-10 09:45:17 -07:00
Nikolaj Bjorner
85da7407dc
#5460
...
NB @nunoplopes - the code path regarding rewrite_uncstr could use some unit tests.
2021-08-08 17:18:31 -07:00
Nikolaj Bjorner
e27a71bbcb
#5460
2021-08-08 16:29:41 -07:00
Nikolaj Bjorner
dcfd7b76c9
more rewrites based on example in #5457
2021-08-05 11:54:13 -07:00
Nikolaj Bjorner
e10850e66a
fix #5457
2021-08-05 11:27:03 -07:00
Nikolaj Bjorner
a39d1c6188
fix #5456
2021-08-04 10:07:29 -07:00
Nikolaj Bjorner
939860148f
#5452
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-08-03 20:03:34 -07:00
Nikolaj Bjorner
2891ac7dec
merge
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-08-03 19:47:38 -07:00
Nikolaj Bjorner
40f5270ae2
fix #5452
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-08-03 17:23:41 -07:00
Nikolaj Bjorner
da8530e2db
#5447
...
That the bug went away is a fluke. It wasnt fixed.
It is in pb-preprocess, an essentially unused tactic. The special subsumption resolution rule wasn't accounting for membership of all variables.
2021-08-02 09:03:15 -07:00
Nikolaj Bjorner
50f5cafb50
fix #5446
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-08-01 05:09:58 -07:00
Nikolaj Bjorner
490dc66ec2
remove sine filter #5446
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-08-01 05:05:45 -07:00
Nikolaj Bjorner
7de8c72246
cleanups
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-07-31 11:32:47 -07:00
Nikolaj Bjorner
10145366b2
#5425
...
Add an alternative to unit-subsume-simplify
It is called solver-subsumption
It does a little more than unit-subsume-simplify and also uses a different decomposition algorithm for clauses.
It removes redundant constraints and simplifies clauses in a single pass.
A possible use of this tactic is in isolation where the maximal number of conflicts
(smt.conflicts_max, sat.conflicts_max) are bounded. For simpler formulas full solver calls may be still feasible.
2021-07-23 21:02:25 -07:00
Nikolaj Bjorner
7af2309fae
#5331
2021-07-19 16:09:13 -07:00
Nikolaj Bjorner
c7a7d40a8f
remove incorrect and inefficient default model conversion
2021-07-15 18:47:25 +02:00
Nikolaj Bjorner
29a2838bc9
#5338 #5349
2021-06-16 16:01:42 -05:00
Nikolaj Bjorner
f95d0b7216
#5349 #5338
2021-06-16 16:01:42 -05:00
Nikolaj Bjorner
dc6a8fde34
fix #5340
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-06-15 13:53:22 -05:00
Nikolaj Bjorner
83e2e7200c
fix #5316
2021-05-30 11:28:31 -07:00
Nikolaj Bjorner
322531e95c
fix #5303
2021-05-25 10:20:20 -07:00
Nuno Lopes
f1e0d5dc8a
remove a hundred implicit constructors/destructors
2021-05-23 14:25:01 +01:00
Nikolaj Bjorner
c230d89a3a
fix #5294
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-05-22 09:59:50 -07:00
Nikolaj Bjorner
e63e4587a4
build
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-05-21 15:41:12 -07:00
Nikolaj Bjorner
28328e63fd
fix #5255
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-05-09 20:48:11 -07:00
Nikolaj Bjorner
4a6083836a
call it data instead of c_ptr for approaching C++11 std::vector convention.
2021-04-13 18:17:35 -07:00
Nuno Lopes
c47ab023e5
remove a few trivial destructors so they get inlined
2021-04-04 17:13:59 +01:00
Nikolaj Bjorner
2fef6dc502
more scaffolding
2021-03-21 11:31:14 -07:00
Nikolaj Bjorner
8c66691e6d
disable propagation in proof mode as it produces ill-formed proof objects. Fixes #5063
2021-03-03 09:51:56 -08:00
Nikolaj Bjorner
0ce1c34d81
fix #5065 - regression solving str.from_int equations now that it isn't injective any longer
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-03-02 12:59:48 -08:00
Nuno Lopes
d6ce9cce95
fix clang warnings
2021-02-19 10:59:22 +00:00
Nikolaj Bjorner
180015a529
fix #5035
2021-02-18 16:47:36 -08:00
Nikolaj Bjorner
4991c6c2c6
fix #5002
...
Avoid code path that uses qe_tactic as it isn't protected against parameter abuse
2021-02-12 13:20:51 -08:00
Nikolaj Bjorner
25f53c0467
deal with warnings reported in https://launchpadlibrarian.net/522361319/buildlog_ubuntu-groovy-s390x.z3_4.8.10-1ubuntu4ppa1_BUILDING.txt.gz
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2021-02-11 13:49:47 -08:00
Nikolaj Bjorner
0ec567fe15
integrate v2 of lns
2021-02-04 15:47:40 -08:00
Nikolaj Bjorner
fb1509d011
expose internal API for set_phase
2021-02-02 14:29:06 -08:00
Nikolaj Bjorner
8f577d3943
remove ast_manager get_sort method entirely
2021-02-02 13:57:01 -08:00
Nikolaj Bjorner
937b61fc88
fix build, refactor
2021-02-02 05:26:57 -08:00
Nikolaj Bjorner
3ae4c6e9de
refactor get_sort
2021-02-02 04:45:54 -08:00
Nikolaj Bjorner
4455f6caf8
move to get_sort as method, add opt_lns pass, disable xor simplification unless configured, fix perf bug in model converter update trail
2021-02-02 03:58:19 -08:00
Nikolaj Bjorner
0e429cab33
enable new core for incremental mode
2021-01-11 14:55:31 -08:00