5 commits

Author	SHA1	Message	Date
Nikolaj Bjorner	4a142b0f81	fix #6623	2023-04-09 21:10:24 -07:00
Nikolaj Bjorner	5c7eaec566	#6364 - remove option of redundant clauses from internalization ... gc-ing definitions leads to unsoundness when they are not replayed. Instead of attempting to replay definitions theory internalization is irredundant by default. This is also the old solver behavior where TH_LEMMA is essentially never used, but is valid for top-level theory lemmas.	2022-10-24 00:38:31 -07:00
Nikolaj Bjorner	2842c27e92	#6364	2022-10-20 04:48:13 -07:00
Bruce Mitchener	5014b1a34d	Use = default for virtual constructors.	2022-08-05 18:11:46 +03:00
Jamey Sharp	426306376f	CNF conversion refactoring (#5547) ... * split sat2goal out of goal2sat These two classes need different things out of the sat::solver class, and separating them makes it easier to fiddle with their dependencies independently. I also fiddled with some headers to make it possible to include sat_solver_core.h instead of sat_solver.h. * limit solver_core methods to those needed by goal2sat And switch sat2goal and sat_tactic over to relying on the derived sat::solver class instead. There were no other uses of solver_core. I'm hoping this makes it feasible to reuse goal2sat's CNF conversion from places like the tseitin-cnf tactic, so they can be unified into a single implementation.	2021-09-20 08:53:10 -07:00