Nikolaj Bjorner
40b9d80ae5
more review
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-14 12:20:01 -07:00
Nikolaj Bjorner
744d75e8cc
more review
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-14 12:10:12 -07:00
Nikolaj Bjorner
0dc5b4eef5
add review comments
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-14 11:59:47 -07:00
Copilot
5a3dbaf9f3
Move nseq_regex/state into smt/seq and seq_model into smt/; rename to seq_* prefix ( #8984 )
...
* Initial plan
* build verified: nseq_regex moved to smt/seq
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* rename nseq_regex/state/model to seq_regex/state/model in smt/seq; add Clemens Eisenhofer as co-author
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* seq_model: remove theory_nseq dependency; get family_id from seq_util
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Add comments for regex enhancements in seq_model
Added comments regarding future improvements for regex handling.
* Add comments for large exponent handling
Add comments for handling large exponents in seq_model.cpp
* Revise comments for clarity on sort usage
Updated comments to reflect review suggestions regarding the use of the sort of 'n'.
* seq_state: remove sgraph dep; seq_model: use snode sort for is_empty; remove NSB review comments
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
* Update seq_state.h
* Remove unnecessary include for smt_context.h
* move seq_model from smt/seq/ to smt/; fix seq_state.h add_str_mem typo
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
Co-authored-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-14 11:45:32 -07:00
Nikolaj Bjorner
27f5541b0b
updates
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-13 18:19:25 -07:00
Nikolaj Bjorner
8a48caf742
na
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-13 10:25:43 -07:00
Nikolaj Bjorner
df9df50a71
update generation of empty sequence to take sort argument, fix mk_concat substitution
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-13 10:03:52 -07:00
CEisenhofer
e384e8f3d4
Added right-to-left rules
2026-03-13 17:25:14 +01:00
copilot-swe-agent[bot]
c6cfd43ab2
Fix build: correct constructor initializer list syntax in seq_nielsen.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-12 20:16:52 +00:00
Nikolaj Bjorner
5d0f5dc4e5
Merge branch 'c3' into copilot/add-parikh-filter-implementation-again
2026-03-12 09:20:03 -07:00
CEisenhofer
3ad9c290fc
Use length information during Nielsen saturation
2026-03-12 17:01:44 +01:00
CEisenhofer
e8354a783a
Power base compression
2026-03-12 13:24:20 +01:00
CEisenhofer
bee9fd82f0
Another power bug
2026-03-12 12:59:03 +01:00
CEisenhofer
87c5be8904
Fixed progress annotations
2026-03-12 11:22:42 +01:00
CEisenhofer
1351efe9af
Unit cases
2026-03-12 11:13:18 +01:00
copilot-swe-agent[bot]
9813b2adfb
Merge branch 'c3' of https://github.com/Z3Prover/z3 into copilot/add-parikh-filter-implementation-again
2026-03-12 04:22:43 +00:00
copilot-swe-agent[bot]
dac52ae4e0
remove smt_kernel.h dependency from seq_nielsen.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-12 03:00:38 +00:00
Nikolaj Bjorner
6fa3c7eabb
Merge branch 'c3' into copilot/add-parikh-filter-implementation-again
2026-03-11 19:27:03 -07:00
Nikolaj Bjorner
3d36fb95ec
Merge branch 'c3' into copilot/update-simple-solver-incremental-mode
2026-03-11 19:24:21 -07:00
copilot-swe-agent[bot]
a51ba544ea
Fix typo: rename m_parith to m_parikh in seq_nielsen.h/.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 19:08:11 +00:00
copilot-swe-agent[bot]
30c2a9ccdc
Address code review: add SASSERT for lo>hi, simplify is_to_re handling
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 17:23:00 +00:00
copilot-swe-agent[bot]
194dfe6c61
Port ZIPT Parikh features: minterm_to_char_set, char range constraints, fix stride soundness
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 17:21:27 +00:00
CEisenhofer
99727faf70
Model reconstruction
2026-03-11 18:13:16 +01:00
copilot-swe-agent[bot]
255d381b72
Make simple_solver incremental: use push/pop scopes in Nielsen DFS
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 17:09:34 +00:00
copilot-swe-agent[bot]
45a574d7fa
Remove nseq_parith.h and nseq_parikh.cpp backwards-compat shims
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 15:48:05 +00:00
CEisenhofer
d23f376b39
Fixed a lot regarding powers, but there seems to be a model reconstruction bug left
2026-03-11 16:44:14 +01:00
CEisenhofer
6d0468861d
Fixed git merge problems
2026-03-11 13:05:27 +01:00
CEisenhofer
2f46c8893e
Another attempt to fix powers
2026-03-11 11:29:25 +01:00
copilot-swe-agent[bot]
213ddd36ba
Rename nseq_parikh→seq_parikh; add m/seq/a member attributes to seq_parikh
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 05:41:16 +00:00
copilot-swe-agent[bot]
4ac5315846
Fix review: min>=max guard, ceiling-div overflow, SASSERT, accessor methods, comments
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 05:15:20 +00:00
copilot-swe-agent[bot]
eca5fcc7bb
Integrate nseq_parith into nielsen_graph; add k upper bound and check_parikh_conflict
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 05:10:30 +00:00
copilot-swe-agent[bot]
35ee8f917d
Remove redundant zero-guards before u_gcd calls in concat/intersection cases
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 04:26:26 +00:00
copilot-swe-agent[bot]
4cdfceabc5
Use u_gcd from util/mpz.h instead of local gcd definition
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 04:24:16 +00:00
copilot-swe-agent[bot]
d267e452a2
Add Clemens Eisenhofer as co-author to nseq_parith.h and nseq_parikh.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 04:21:30 +00:00
copilot-swe-agent[bot]
334df71b11
Add nseq_parith.h and nseq_parikh.cpp: Parikh filter for ZIPT string solver
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-11 00:05:26 +00:00
copilot-swe-agent[bot]
57ede4cdcd
Address code review: clarify add_lower/upper_int_bound return semantics; fix test assertion
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 23:29:15 +00:00
copilot-swe-agent[bot]
47f9be0270
Implement IntBounds/VarBoundWatcher + Constraint.Shared; fix pre-existing build errors
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 23:26:55 +00:00
Nikolaj Bjorner
c98ea6dc21
make simple solver a reference
...
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
2026-03-10 15:10:51 -07:00
copilot-swe-agent[bot]
5744958e46
Replace lp_simple_solver in nielsen with context_solver using smt::kernel (seq_len)
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 21:39:29 +00:00
copilot-swe-agent[bot]
d4b99730b9
Fix build error: remove stale dep_tracker method definitions from seq_nielsen.cpp
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 18:30:33 +00:00
Nikolaj Bjorner
2e636ec25d
Merge branch 'c3' into copilot/replace-lp-solver-with-abstract-solver
2026-03-10 10:35:44 -07:00
Nikolaj Bjorner
3f0e821207
Merge pull request #8923 from Z3Prover/copilot/host-char-range-and-set
...
Move char_range and char_set from seq_nielsen to zstring
2026-03-10 10:18:58 -07:00
Nikolaj Bjorner
c710e1fa14
Merge pull request #8922 from Z3Prover/copilot/replace-dep-tracker-with-uint-set
...
Replace dep_tracker with uint_set in seq_nielsen
2026-03-10 10:18:37 -07:00
copilot-swe-agent[bot]
40b33ab353
Address code review: simplify constructor, add UNREACHABLE()
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 17:10:36 +00:00
copilot-swe-agent[bot]
35addda546
Replace lp_solver in seq_nielsen with abstract simple_solver class
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 17:08:57 +00:00
copilot-swe-agent[bot]
5330bd20bc
Replace dep_tracker class in seq_nielsen with uint_set
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 16:58:50 +00:00
copilot-swe-agent[bot]
430a43045a
Move char_range and char_set from seq_nielsen to zstring
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 16:57:43 +00:00
copilot-swe-agent[bot]
2f8cc1536c
Swap author order: Clemens Eisenhofer before Nikolaj Bjorner in file headers
...
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-03-10 16:27:26 +00:00
CEisenhofer
587eec4226
More bug fixing in the gpower introduction
2026-03-09 15:20:58 +01:00
CEisenhofer
32a09859e3
Fixing power introduction
2026-03-09 15:03:26 +01:00