wip - updates to proof logging and self-checking

move self-checking functionality to inside sat/smt so it can be used on-line and not just off-line.

when self-validation fails, use vs, not clause, to check. It allows self-validation without checking and maintaining RUP validation.

new options sat.smt.proof.check_rup, sat.smt.proof.check for online validation.

z3 sat.smt.proof.check=true sat.euf=true /v:1 sat.smt.proof.check_rup=true /st file.smt2 sat.smt.proof=p.smt2

src/sat/smt/q_theory_checker.cpp

@@ -0,0 +1,66 @@
+/*++
+Copyright (c) 2022 Microsoft Corporation
+
+Module Name:
+
+    q_theory_checker.cpp
+
+Abstract:
+
+    Plugin for checking quantifier instantiations
+
+Author:
+
+    Nikolaj Bjorner (nbjorner) 2022-10-07
+
+--*/
+
+#include "ast/rewriter/var_subst.h"
+#include "sat/smt/q_theory_checker.h"
+#include "sat/smt/q_solver.h"
+
+namespace q {
+        
+    expr_ref_vector theory_checker::clause(app* jst) {
+        expr_ref_vector result(m);
+        for (expr* arg : *jst) 
+            if (!is_bind(arg))
+                result.push_back(mk_not(m, arg));
+        return result;
+    }
+
+    expr_ref_vector theory_checker::binding(app* jst) {
+        expr_ref_vector result(m);
+        for (expr* arg : *jst) 
+            if (is_bind(arg)) {
+                result.append(to_app(arg)->get_num_args(), to_app(arg)->get_args());
+                break;
+            }
+        return result;        
+    }
+    
+    bool theory_checker::vc(app* jst, expr_ref_vector const& clause0, expr_ref_vector& v) {
+        expr* q = nullptr;
+        if (!is_inst(jst))
+            return false;
+        auto clause1 = clause(jst);
+        SASSERT(clause1.size() >= 2);
+        VERIFY(m.is_not(clause1.get(0), q) && is_forall(q));
+        auto inst = binding(jst);
+        expr_ref qi = instantiate(m, to_quantifier(q), inst.begin());
+        clause1[0] = m.mk_not(qi);
+        v.reset();
+        v.append(clause1);
+        return qi == clause1.get(1);
+    }
+
+    bool theory_checker::is_inst(expr* jst) {
+        return is_app(jst) && to_app(jst)->get_name() == m_inst && m.mk_proof_sort() == jst->get_sort();
+    }
+
+    bool theory_checker::is_bind(expr* e) {
+        return is_app(e) && to_app(e)->get_name() == m_bind  && m.mk_proof_sort() == e->get_sort();
+    }
+
+    
+}