3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-02-01 23:07:59 +00:00
z3/src/tactic
Copilot 058a8c082d
Refactor mk_and and mk_app to use std::span API (#8285)
* Initial plan

* Refactor mk_and and mk_app to use std::span

- Made mk_and(unsigned num_args, expr * const * args) private
- Added new public mk_and(std::span<expr* const> args) method
- Added new public mk_app(family_id fid, decl_kind k, std::span<expr* const> args) method
- Updated all convenience overloads to use std::span version
- Updated all external call sites to use the new std::span API

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Fix remaining test files to use std::span API

- Updated src/test/sorting_network.cpp
- Updated src/test/ho_matcher.cpp with explicit cast to resolve ambiguity

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Revert overlapping changes superseded by PR #8286

Reverted 30 files to match the state from PR #8286 (commit ebc0688) which refactored mk_and/mk_or call sites to use vector overloads. This supersedes the std::span changes in those files.

Retained std::span changes in files unique to this PR:
- Core API changes (ast.h, ast.cpp)
- Files not affected by PR #8286 (api_context.cpp, ast_util.cpp, bool_rewriter.h, datatype_rewriter.cpp, dom_simplifier.cpp, factor_rewriter.cpp, pb2bv_rewriter.cpp, quant_hoist.cpp, spacer_cluster_util.cpp, sortmax.cpp, array_axioms.cpp, smtfd_solver.cpp, goal.cpp, ho_matcher.cpp, qe_arith.cpp, sorting_network.cpp)
- Special case in hnf.cpp where both PRs modified different lines

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-22 16:58:38 -08:00
..
aig Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
arith Refactor mk_and/mk_or call sites to use vector overloads (#8286) 2026-01-22 13:21:22 -08:00
bv Refactor mk_and/mk_or call sites to use vector overloads (#8286) 2026-01-22 13:21:22 -08:00
core Refactor mk_and/mk_or call sites to use vector overloads (#8286) 2026-01-22 13:21:22 -08:00
fd_solver Refactor mk_and and mk_app to use std::span API (#8285) 2026-01-22 16:58:38 -08:00
fpa Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
portfolio Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
sls Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
smtlogics Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
ufbv Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
CMakeLists.txt move horn_subsume_model_converter to ast/converters 2022-11-03 20:26:02 -07:00
dependency_converter.cpp call it data instead of c_ptr for approaching C++11 std::vector convention. 2021-04-13 18:17:35 -07:00
dependency_converter.h move model and proof converters to self-contained module 2022-11-03 05:23:01 -07:00
dependent_expr_state_tactic.h add an option to register callback on quantifier instantiation 2025-08-06 21:11:55 -07:00
goal.cpp Refactor mk_and and mk_app to use std::span API (#8285) 2026-01-22 16:58:38 -08:00
goal.h Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
goal_num_occurs.cpp Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
goal_num_occurs.h booyah 2020-07-04 15:56:30 -07:00
goal_proof_converter.h Fix some typos. (#7115) 2024-02-07 23:06:43 -08:00
goal_shared_occs.cpp Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
goal_shared_occs.h booyah 2020-07-04 15:56:30 -07:00
goal_util.cpp port to inherit from std::exception 2024-11-04 13:25:14 -08:00
goal_util.h booyah 2020-07-04 15:56:30 -07:00
probe.cpp Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
probe.h remove default destructors & some default constructors 2024-09-04 22:30:23 +01:00
tactic.cpp Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
tactic.h fix #7404, relates to #7400. 2024-09-27 11:36:10 +01:00
tactic_exception.h add noexcept 2024-11-04 11:21:55 -08:00
tactical.cpp Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
tactical.h booyah 2020-07-04 15:56:30 -07:00
user_propagator_base.h add an option to register callback on quantifier instantiation 2025-08-06 21:11:55 -07:00