3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-01-20 01:03:20 +00:00
z3/src
copilot-swe-agent[bot] 62c3239d14 Remove unreliable RCF predicate tests for pi/e
Z3's RCF implementation doesn't reliably return expected values for
predicates like isRational() on transcendental numbers (pi, e).
Testing shows pi.isRational() returns true, which is incorrect.

Updated tests to:
- Remove all predicate checks on pi and e
- Focus on reliable tests: creation, decimal conversion, arithmetic
- Keep predicate tests only for cases that work reliably:
  * isRational() for simple rationals/integers
  * isAlgebraic() for polynomial roots
  * isInfinitesimal() for infinitesimals
  * isTranscendental() only for rationals (negative test)

The API functions are correctly implemented and match other language
bindings. Python doesn't even expose these predicates, suggesting
they're known to be unreliable for certain value types.

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
2026-01-18 05:05:10 +00:00
..
ackermannization Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
api Remove unreliable RCF predicate tests for pi/e 2026-01-18 05:05:10 +00:00
ast Fix 13 compiler warnings: sign-comparison and unused parameters (#8215) 2026-01-16 16:00:42 -08:00
cmd_context Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
math Merge pull request #8218 from Z3Prover/copilot/fix-segmentation-fault-ufnira 2026-01-17 05:18:38 -10:00
model Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
muz Replace fall-through comments with Z3_fallthrough macro (#8219) 2026-01-16 19:54:31 -08:00
nlsat Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
opt Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
params Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
parsers Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
qe Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
sat Fix 13 compiler warnings: sign-comparison and unused parameters (#8215) 2026-01-16 16:00:42 -08:00
shell Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
smt Replace fall-through comments with Z3_fallthrough macro (#8219) 2026-01-16 19:54:31 -08:00
solver Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
tactic Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
test Standardize for-loop increments to prefix form (++i) (#8199) 2026-01-14 19:55:31 -08:00
util Fix UNKNOWN bug in search tree about inconsistent end state (#8214) 2026-01-16 10:41:13 -08:00
CMakeLists.txt BLD: Add CMake option to build Python bindings without rebuilding libz3 (redux) (#8088) 2025-12-16 17:50:37 +00:00