mirror of
https://github.com/Z3Prover/z3
synced 2026-07-15 11:35:42 +00:00
69cd7e0c4c
The page https://github.com/Z3Prover/z3/blob/master/README-CMake.md#adding-z3-as-a-dependency-to-a-cmake-project advises using the CMake FetchContent feature to include z3 as source into other CMake project. I'm trying to do this to use Z3 within a ClangTidy checker. This is one of a series of PR's aimed at getting Z3 to compile cleanly when included this way. This initial PR fixes all the errors, allowing the compilation to succeed. Subsequent diffs will address warnings. I tested only the CMake compilation, on a Mac. *Missing Z3_THROWs* Update z3++.h to use Z3_THROW in a couple of places. Clang compiles with exceptions disabled so we get messages like: ``` /Users/daviddetlefs/llvm-project/build_dbg/_deps/z3-src/src/api/c++/z3++.h:4928:17: error: cannot use 'throw' with exceptions disabled4928 | throw exception("rcf_num objects from different contexts"); ``` NOTE TO REVIEWERS: I'm not complete clear on the usage conventions for Z3_THROW. With exception disabled, it seems like the throwing function will just continue. If there's somethign else that should be done, like setting some error state, please let me know. *CMake component name collision* There was an error at the CMake level, a name collision (on "opt"). Apparently CMake components are named using a flat namespace, so it's easy to see how this could occur. It seems to me that the right global way to fix this would be to encourage people to use some form of "qualified name" convention in naming their component. The fix I chose was a local version of this, changing the Z3 component name to z3_opt. (It didn't seem feasible to make the change in clang.) NOTE TO REVIEWERS: If you think this is OK, please let me know if a) You'd like me to also change the name of the opt directory, to keep thecomponent-name == directory-name invariant, and b) You'd like me to make this z3_ change more globally, to future-proof (somewhat) against similar component name collisions. |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| maxcore.cpp | ||
| maxcore.h | ||
| maxlex.cpp | ||
| maxlex.h | ||
| maxsmt.cpp | ||
| maxsmt.h | ||
| opt_cmds.cpp | ||
| opt_cmds.h | ||
| opt_context.cpp | ||
| opt_context.h | ||
| opt_cores.cpp | ||
| opt_cores.h | ||
| opt_lns.cpp | ||
| opt_lns.h | ||
| opt_mux.h | ||
| opt_params.pyg | ||
| opt_pareto.cpp | ||
| opt_pareto.h | ||
| opt_parse.cpp | ||
| opt_parse.h | ||
| opt_preprocess.cpp | ||
| opt_preprocess.h | ||
| opt_sls_solver.h | ||
| opt_solver.cpp | ||
| opt_solver.h | ||
| optsmt.cpp | ||
| optsmt.h | ||
| pb_sls.cpp | ||
| pb_sls.h | ||
| sortmax.cpp | ||
| totalizer.cpp | ||
| totalizer.h | ||
| wmax.cpp | ||
| wmax.h | ||