breaking change. Enforce append semantics everywhere for parameter updates #5744

Replace semantics doesn't work with assumptions made elsewhere in code.
The remedy is to apply append (override) semantics for parameter changes.

src/tactic/core/blast_term_ite_tactic.cpp

@@ -174,8 +174,8 @@ public:
     char const* name() const override { return "blast_term_ite"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->m_rw.m_cfg.updt_params(p);
+        m_params.append(p);
+        m_imp->m_rw.m_cfg.updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/core/cofactor_term_ite_tactic.cpp

@@ -52,7 +52,7 @@ public:
 
     ~cofactor_term_ite_tactic() override {}
     char const* name() const override { return "cofactor"; }
-    void updt_params(params_ref const & p) override { m_params = p; m_elim_ite.updt_params(p); }
+    void updt_params(params_ref const & p) override { m_params.append(p); m_elim_ite.updt_params(m_params); }
     void collect_param_descrs(param_descrs & r) override { m_elim_ite.collect_param_descrs(r); }
     
     void  operator()(goal_ref const & g, goal_ref_buffer& result) override {

src/tactic/core/collect_statistics_tactic.cpp

@@ -60,7 +60,7 @@ public:
     }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
+        m_params.append(p);
     }
 
     void collect_param_descrs(param_descrs & r) override {}

src/tactic/core/ctx_simplify_tactic.cpp

@@ -605,8 +605,8 @@ ctx_simplify_tactic::~ctx_simplify_tactic() {
 }
 
 void ctx_simplify_tactic::updt_params(params_ref const & p) {
-    m_params = p;
-    m_imp->updt_params(p);
+    m_params.append(p);
+    m_imp->updt_params(m_params);
 }
 
 void ctx_simplify_tactic::get_param_descrs(param_descrs & r) {

src/tactic/core/elim_term_ite_tactic.cpp

@@ -143,8 +143,8 @@ public:
     }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->m_rw.cfg().updt_params(p);
+        m_params.append(p);
+        m_imp->m_rw.cfg().updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/core/elim_uncnstr_tactic.cpp

@@ -862,9 +862,9 @@ public:
     }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_max_memory = megabytes_to_bytes(p.get_uint("max_memory", UINT_MAX));
-        m_max_steps  = p.get_uint("max_steps", UINT_MAX);
+        m_params.append(p);
+        m_max_memory = megabytes_to_bytes(m_params.get_uint("max_memory", UINT_MAX));
+        m_max_steps  = m_params.get_uint("max_steps", UINT_MAX);
     }
     
     void collect_param_descrs(param_descrs & r) override {

src/tactic/core/injectivity_tactic.cpp

@@ -258,8 +258,8 @@ public:
     char const* name() const override { return "injectivity"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_finder->updt_params(p);
+        m_params.append(p);
+        m_finder->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/core/nnf_tactic.cpp

@@ -51,7 +51,7 @@ public:
 
     char const* name() const override { return "nnf"; }
 
-    void updt_params(params_ref const & p) override { m_params = p; }
+    void updt_params(params_ref const & p) override { m_params.append(p); }
 
     void collect_param_descrs(param_descrs & r) override { nnf::get_param_descrs(r); }
 

src/tactic/core/propagate_values_tactic.cpp

@@ -219,9 +219,9 @@ public:
     char const* name() const override { return "propagate_values"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
+        m_params.append(p);
         m_r.updt_params(p);
-        updt_params_core(p);
+        updt_params_core(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/core/simplify_tactic.cpp

@@ -80,8 +80,8 @@ simplify_tactic::~simplify_tactic() {
 }
 
 void simplify_tactic::updt_params(params_ref const & p) {
-    m_params = p;
-    m_imp->m_r.updt_params(p);
+    m_params.append(p);
+    m_imp->m_r.updt_params(m_params);
 }
 
 void simplify_tactic::get_param_descrs(param_descrs & r) {

src/tactic/core/solve_eqs_tactic.cpp

@@ -1092,8 +1092,8 @@ public:
     char const* name() const override { return "solve_eqs"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {        

src/tactic/core/special_relations_tactic.h

@@ -49,7 +49,7 @@ public:
 
     ~special_relations_tactic() override {}
 
-    void updt_params(params_ref const & p) override { m_params = p; }
+    void updt_params(params_ref const & p) override { m_params.append(p); }
     
     void collect_param_descrs(param_descrs & r) override { }
     

src/tactic/core/tseitin_cnf_tactic.cpp

@@ -894,8 +894,8 @@ public:
     char const* name() const override { return "tseitin_cnf"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {