breaking change. Enforce append semantics everywhere for parameter updates #5744

Replace semantics doesn't work with assumptions made elsewhere in code.
The remedy is to apply append (override) semantics for parameter changes.

src/tactic/arith/add_bounds_tactic.cpp

@@ -149,8 +149,8 @@ public:
     char const* name() const override { return "add_bounds"; }
     
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/card2bv_tactic.cpp

@@ -45,7 +45,7 @@ public:
     char const* name() const override { return "card2bv"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
+        m_params.append(p);
     }
 
     void collect_param_descrs(param_descrs & r) override {  

src/tactic/arith/diff_neq_tactic.cpp

@@ -360,8 +360,8 @@ public:
     char const* name() const override { return "diff_neq"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/factor_tactic.cpp

@@ -297,8 +297,8 @@ public:
     char const* name() const override { return "factor"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->m_rw.cfg().updt_params(p);
+        m_params.append(p);
+        m_imp->m_rw.cfg().updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/fix_dl_var_tactic.cpp

@@ -303,8 +303,8 @@ public:
     char const* name() const override { return "fix_dl_var"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/fm_tactic.cpp

@@ -1645,8 +1645,8 @@ public:
     char const* name() const override { return "fm"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/lia2card_tactic.cpp

@@ -135,8 +135,8 @@ public:
     char const* name() const override { return "lia2card"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_compile_equality = p.get_bool("compile_equality", true);
+        m_params.append(p);
+        m_compile_equality = m_params.get_bool("compile_equality", true);
     }
 
     expr_ref mk_bounded(expr_ref_vector& axioms, app* x, unsigned lo, unsigned hi) {

src/tactic/arith/lia2pb_tactic.cpp

@@ -308,8 +308,8 @@ public:
     char const* name() const override { return "lia2pb"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/pb2bv_tactic.cpp

@@ -1010,8 +1010,8 @@ public:
     char const* name() const override { return "pb2bv"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/propagate_ineqs_tactic.cpp

@@ -543,8 +543,8 @@ propagate_ineqs_tactic::~propagate_ineqs_tactic() {
 }
 
 void propagate_ineqs_tactic::updt_params(params_ref const & p) {
-    m_params = p;
-    m_imp->updt_params(p);
+    m_params.append(p);
+    m_imp->updt_params(m_params);
 }
 
 void propagate_ineqs_tactic::operator()(goal_ref const & g, 

src/tactic/arith/purify_arith_tactic.cpp

@@ -906,7 +906,7 @@ public:
     char const* name() const override { return "purify_arith"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
+        m_params.append(p);
     }
 
     void collect_param_descrs(param_descrs & r) override {

src/tactic/arith/recover_01_tactic.cpp

@@ -401,8 +401,8 @@ public:
     char const* name() const override { return "recover_01"; }
 
     void updt_params(params_ref const & p) override {
-        m_params = p;
-        m_imp->updt_params(p);
+        m_params.append(p);
+        m_imp->updt_params(m_params);
     }
 
     void collect_param_descrs(param_descrs & r) override {