mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-04-27 19:05:51 +00:00
Code Activity

Java API: In fromInt() methods of enums fail on invalid value.

Browse source 
The existing code just returns one of the enum values if an unknown int
value is passed, silently hiding bugs.
This commit is contained in:
Philipp Wendler 2016-07-22 16:49:50 +02:00
parent 9ed2c846a9
commit f325b51213
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/mk_genfile_common.py
View file

@ -345,7 +345,7 @@ def mk_z3consts_java_internal(api_files, package_name, output_dir):
efile.write(' public static final %s fromInt(int v) {\n' % name)
efile.write(' for (%s k: values()) \n' % name)
efile.write(' if (k.intValue == v) return k;\n')
efile.write(' return values()[0];\n')
efile.write(' throw new IllegalArgumentException("Illegal value " + v + " for %s");\n' % name)
efile.write(' }\n\n')
efile.write(' public final int toInt() { return this.intValue; }\n')
# efile.write(';\n %s(int v) {}\n' % name)