remove a hundred implicit constructors/destructors

src/ast/ast.h

@@ -214,12 +214,10 @@ void display_parameters(std::ostream & out, unsigned n, parameter const * p);
    between symbols (family names) and the unique IDs.
 */
 class family_manager {
-    family_id               m_next_id;
+    family_id               m_next_id = 0;
     symbol_table<family_id> m_families;
     svector<symbol>         m_names;
 public:
-    family_manager():m_next_id(0) {}
-
     /**
        \brief Return the family_id for s, a new id is created if !has_family(s)
 
@@ -999,8 +997,8 @@ struct builtin_name {
 */
 class decl_plugin {
 protected:
-    ast_manager * m_manager;
-    family_id     m_family_id;
+    ast_manager * m_manager = nullptr;
+    family_id     m_family_id = null_family_id;
 
     virtual void set_manager(ast_manager * m, family_id id) {
         SASSERT(m_manager == nullptr);
@@ -1024,8 +1022,6 @@ protected:
     friend class ast_manager;
 
 public:
-    decl_plugin():m_manager(nullptr), m_family_id(null_family_id) {}
-
     virtual ~decl_plugin() {}
     virtual void finalize() {}
 
@@ -1354,8 +1350,6 @@ class user_sort_plugin : public decl_plugin {
     svector<symbol> m_sort_names;
     dictionary<int> m_name2decl_kind;
 public:
-    user_sort_plugin() {}
-
     sort * mk_sort(decl_kind k, unsigned num_parameters, parameter const * parameters) override;
     func_decl * mk_func_decl(decl_kind k, unsigned num_parameters, parameter const * parameters,
                              unsigned arity, sort * const * domain, sort * range) override;
@@ -2450,7 +2444,6 @@ typedef obj_mark<expr> expr_mark;
 class expr_sparse_mark {
     obj_hashtable<expr> m_marked;
 public:
-    expr_sparse_mark() {}
     bool is_marked(expr * n) const { return m_marked.contains(n); }
     void mark(expr * n) { m_marked.insert(n); }
     void mark(expr * n, bool flag) { if (flag) m_marked.insert(n); else m_marked.erase(n); }
@@ -2461,7 +2454,6 @@ template<unsigned IDX>
 class ast_fast_mark {
     ptr_buffer<ast> m_to_unmark;
 public:
-    ast_fast_mark() {}
     ~ast_fast_mark() {
         reset();
     }
@@ -2603,7 +2595,6 @@ class scoped_mark : public ast_mark {
     unsigned_vector m_lim;
 public:
     scoped_mark(ast_manager& m): m_stack(m) {}
-    ~scoped_mark() override {}
     void mark(ast * n, bool flag) override;
     void reset() override;
     void mark(ast * n);
@@ -2644,7 +2635,3 @@ struct parameter_pp {
 inline std::ostream& operator<<(std::ostream& out, parameter_pp const& pp) {
     return pp.m.display(out, pp.p);
 }
-
-
-
-

src/ast/datatype_decl_plugin.h

@@ -105,7 +105,6 @@ namespace datatype {
         class size {
             unsigned m_ref{ 0 };
         public:
-            size() {}
             virtual ~size() { }
             void inc_ref() { ++m_ref; }
             void dec_ref();
@@ -124,7 +123,6 @@ namespace datatype {
         struct offset : public size {
             sort_size m_offset;
             offset(sort_size const& s): m_offset(s) {}
-            ~offset() override {}
             size* subst(obj_map<sort,size*>& S) override { return this; }
             sort_size eval(obj_map<sort, sort_size> const& S) override { return m_offset; }
         };
@@ -152,7 +150,6 @@ namespace datatype {
         struct sparam : public size {
             sort_ref m_param;
             sparam(sort_ref& p): m_param(p) {}
-            ~sparam() override {}
             size* subst(obj_map<sort, size*>& S) override;
             sort_size eval(obj_map<sort, sort_size> const& S) override { return S[m_param]; }
         };

src/ast/rewriter/ast_counter.h

@@ -35,8 +35,6 @@ protected:
 public:
     typedef map_impl::iterator iterator;
     
-    counter() {}
-    
     void reset() { m_data.reset(); }
     iterator begin() const { return m_data.begin(); }
     iterator end() const { return m_data.end(); }    
@@ -74,7 +72,6 @@ protected:
     unsigned_vector  m_scopes;
     unsigned get_max_var(bool & has_var);    
 public:
-    var_counter() {}
     void count_vars(const app * t, int coef = 1);
     unsigned get_max_var(expr* e);
     unsigned get_next_var(expr* e);
@@ -86,8 +83,6 @@ class ast_counter {
  public:
     typedef map_impl::iterator iterator;
     
-    ast_counter() {}
-    
     iterator begin() const { return m_data.begin(); }
     iterator end() const { return m_data.end(); }
     

src/ast/rewriter/recfun_rewriter.h

@@ -26,7 +26,6 @@ class recfun_rewriter {
     recfun::util  m_rec;
 public:
     recfun_rewriter(ast_manager& m): m(m), m_rec(m) {}
-    ~recfun_rewriter() {}
     
     br_status mk_app_core(func_decl * f, unsigned num_args, expr * const * args, expr_ref & result);
 

src/ast/seq_decl_plugin.h

@@ -160,7 +160,6 @@ class seq_decl_plugin : public decl_plugin {
 public:
     seq_decl_plugin();
 
-    ~seq_decl_plugin() override {}
     void finalize() override;
 
     bool unicode() const { return get_char_plugin().unicode(); }
@@ -575,8 +574,6 @@ public:
         re(*this) {
     }
 
-    ~seq_util() {}
-
     family_id get_family_id() const { return m_fid; }
 };
 

src/ast/shared_occs.h

@@ -24,8 +24,6 @@ Revision History:
 class shared_occs_mark {
     ptr_buffer<ast> m_to_unmark;
 public:
-    shared_occs_mark() {}
- 
     ~shared_occs_mark() {
         reset();
     }

src/ast/substitution/matcher.h

@@ -36,8 +36,6 @@ class matcher {
     void reset();
 
 public:
-    matcher() {}
-
     /**
        \brief Return true if e2 is an instance of e1.
        In case of success (result is true), it will store the substitution that makes e1 equals to e2 into s.