mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-06-22 05:43:39 +00:00
Code Activity

Optimize expr_safe_replace for quantifiers when all source patterns are vars (#7481)

Browse source 
* Update expr_safe_replace.cpp

* Update expr_safe_replace.cpp

* Update expr_safe_replace.cpp
This commit is contained in:
Nuno Lopes 2024-12-19 22:05:13 +00:00 • committed by GitHub
parent c33bc2c8be
commit e4ab2944fe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/ast/rewriter/expr_safe_replace.cpp
View file

@ -145,7 +145,7 @@ void expr_safe_replace::operator()(expr* e, expr_ref& res) {
var_shifter shift(m); var_shifter shift(m);
expr_ref src(m), dst(m), tmp(m); expr_ref src(m), dst(m), tmp(m);
unsigned num_decls = q->get_num_decls(); unsigned num_decls = q->get_num_decls();
for (unsigned i = 0; i < m_src.size(); ++i) { for (unsigned i = 0, e = m_src.size(); i < e; ++i) {
shift(m_src.get(i), num_decls, src); shift(m_src.get(i), num_decls, src);
shift(m_dst.get(i), num_decls, dst); shift(m_dst.get(i), num_decls, dst);
replace.insert(src, dst); replace.insert(src, dst);
@ -160,8 +160,27 @@ void expr_safe_replace::operator()(expr* e, expr_ref& res) {
replace(q->get_no_pattern(i), tmp); replace(q->get_no_pattern(i), tmp);
nopats.push_back(tmp); nopats.push_back(tmp);
} }
bool all_vars = true;
unsigned max_idx = 0;
for (unsigned i = 0, e = m_src.size(); i < e; ++i) {
auto *s = replace.m_src.get(i);
if (!(all_vars = is_var(s)))
break;
max_idx = std::max(max_idx, to_var(s)->get_idx());
}
if (all_vars) {
m_args.reset();
m_args.resize(max_idx + 1);
for (unsigned i = 0, e = m_src.size(); i < e; ++i) {
m_args[to_var(replace.m_src.get(i))->get_idx()] = replace.m_dst.get(i);
}
var_subst subst(m, false);
new_body = subst(q->get_expr(), m_args);
} else {
replace(q->get_expr(), new_body); replace(q->get_expr(), new_body);
} }
}
b = m.update_quantifier(q, pats.size(), pats.data(), nopats.size(), nopats.data(), new_body); b = m.update_quantifier(q, pats.size(), pats.data(), nopats.size(), nopats.data(), new_body);
m_refs.push_back(b); m_refs.push_back(b);
cached = b; cached = b;