add virtual destructors, fix operator code for API methods complement and intersection per note by Loris d'Antoni

Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>

src/api/api_seq.cpp

@@ -155,9 +155,9 @@ extern "C" {
     MK_UNARY(Z3_mk_re_plus, mk_c(c)->get_seq_fid(), OP_RE_PLUS, SKIP);
     MK_UNARY(Z3_mk_re_star, mk_c(c)->get_seq_fid(), OP_RE_STAR, SKIP);
     MK_UNARY(Z3_mk_re_option, mk_c(c)->get_seq_fid(), OP_RE_OPTION, SKIP);
-    MK_UNARY(Z3_mk_re_complement, mk_c(c)->get_seq_fid(), OP_RE_OPTION, SKIP);
+    MK_UNARY(Z3_mk_re_complement, mk_c(c)->get_seq_fid(), OP_RE_COMPLEMENT, SKIP);
     MK_NARY(Z3_mk_re_union, mk_c(c)->get_seq_fid(), OP_RE_UNION, SKIP);
-    MK_NARY(Z3_mk_re_intersect, mk_c(c)->get_seq_fid(), OP_RE_UNION, SKIP);
+    MK_NARY(Z3_mk_re_intersect, mk_c(c)->get_seq_fid(), OP_RE_INTERSECT, SKIP);
     MK_NARY(Z3_mk_re_concat, mk_c(c)->get_seq_fid(), OP_RE_CONCAT, SKIP);
     MK_BINARY(Z3_mk_re_range, mk_c(c)->get_seq_fid(), OP_RE_RANGE, SKIP);
 

src/math/automata/boolean_algebra.h

@@ -26,6 +26,7 @@ Revision History:
 template<class T>
 class positive_boolean_algebra {
 public:
+    virtual ~positive_boolean_algebra() {}
     virtual T mk_false() = 0;
     virtual T mk_true() = 0;
     virtual T mk_and(T x, T y) = 0;
@@ -38,6 +39,7 @@ public:
 template<class T>
 class boolean_algebra : public positive_boolean_algebra<T> {
 public:
+    virtual ~boolean_algebra() {}
     virtual T mk_not(T x) = 0;	
     //virtual lbool are_equivalent(T x, T y) = 0;
     //virtual T simplify(T x) = 0;    

src/math/subpaving/tactic/subpaving_tactic.cpp

@@ -36,6 +36,8 @@ class subpaving_tactic : public tactic {
             e2v.mk_inv(m_inv);
         }
 
+        virtual ~display_var_proc() {}
+        
         ast_manager & m() const { return m_inv.get_manager(); }
         
         virtual void operator()(std::ostream & out, subpaving::var x) const { 

src/tactic/arith/add_bounds_tactic.cpp

@@ -51,6 +51,7 @@ public:
     virtual result operator()(goal const & g) {
         return is_unbounded(g);
     }
+    virtual ~is_unbounded_probe() {}
 };
 
 probe * mk_is_unbounded_probe() {
@@ -109,7 +110,7 @@ class add_bounds_tactic : public tactic {
             void operator()(quantifier*) {}
         };
         
-        virtual void operator()(goal_ref const & g, 
+        void operator()(goal_ref const & g, 
                         goal_ref_buffer & result, 
                         model_converter_ref & mc, 
                         proof_converter_ref & pc,

src/tactic/arith/diff_neq_tactic.cpp

@@ -312,7 +312,7 @@ class diff_neq_tactic : public tactic {
             return md;
         }
 
-        virtual void operator()(goal_ref const & g, 
+        void operator()(goal_ref const & g, 
                         goal_ref_buffer & result, 
                         model_converter_ref & mc, 
                         proof_converter_ref & pc,

src/tactic/arith/fm_tactic.cpp

@@ -1549,7 +1549,7 @@ class fm_tactic : public tactic {
                 throw tactic_exception(TACTIC_MAX_MEMORY_MSG);
         }
         
-        virtual void operator()(goal_ref const & g, 
+        void operator()(goal_ref const & g, 
                         goal_ref_buffer & result, 
                         model_converter_ref & mc, 
                         proof_converter_ref & pc,

src/tactic/arith/lia2pb_tactic.cpp

@@ -188,7 +188,7 @@ class lia2pb_tactic : public tactic {
             return true;
         }
 
-        virtual void operator()(goal_ref const & g, 
+        void operator()(goal_ref const & g, 
                         goal_ref_buffer & result, 
                         model_converter_ref & mc, 
                         proof_converter_ref & pc,

src/tactic/arith/normalize_bounds_tactic.cpp

@@ -80,7 +80,7 @@ class normalize_bounds_tactic : public tactic {
             return false;
         }
         
-        virtual void operator()(goal_ref const & in, 
+        void operator()(goal_ref const & in, 
                         goal_ref_buffer & result, 
                         model_converter_ref & mc, 
                         proof_converter_ref & pc,

src/tactic/arith/pb2bv_tactic.cpp

@@ -885,7 +885,7 @@ private:
             r.erase("elim_and");            
         }
         
-        virtual void operator()(goal_ref const & g, 
+        void operator()(goal_ref const & g, 
                         goal_ref_buffer & result, 
                         model_converter_ref & mc, 
                         proof_converter_ref & pc,

src/tactic/core/elim_uncnstr_tactic.cpp

@@ -819,7 +819,7 @@ class elim_uncnstr_tactic : public tactic {
             m_rw = alloc(rw, m(), produce_proofs, m_vars, m_mc.get(), m_max_memory, m_max_steps);            
         }
 
-        virtual void operator()(goal_ref const & g, 
+        void operator()(goal_ref const & g, 
                                 goal_ref_buffer & result, 
                                 model_converter_ref & mc, 
                                 proof_converter_ref & pc,