3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-04-26 22:03:34 +00:00

Fix unused parameter warnings in empty override functions by omitting parameter names (#8174)

* Initial plan

* Fix unused parameter warnings in empty override functions

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Omit parameter names in empty override functions instead of casting to void

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-12 21:27:33 -08:00 committed by GitHub
parent bb6cd7cd0e
commit daefb4ddfd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
15 changed files with 19 additions and 19 deletions

View file

@ -44,6 +44,6 @@ public:
ast_manager& get_manager() { return m; } ast_manager& get_manager() { return m; }
void display(std::ostream & out) override {} void display(std::ostream &) override { }
}; };

View file

@ -50,7 +50,7 @@ public:
void add(expr * d, expr* e) { SASSERT(is_app(d) && to_app(d)->get_num_args() == 0); add(to_app(d)->get_decl(), e); } void add(expr * d, expr* e) { SASSERT(is_app(d) && to_app(d)->get_num_args() == 0); add(to_app(d)->get_decl(), e); }
void operator()(labels_vec & labels) override {} void operator()(labels_vec &) override { }
void operator()(model_ref & md) override; void operator()(model_ref & md) override;

View file

@ -76,7 +76,7 @@ public:
ast_manager& get_manager() { return m; } ast_manager& get_manager() { return m; }
void display(std::ostream & out) override {} void display(std::ostream &) override { }
void get_units(obj_map<expr, bool>& units) override { units.reset(); } void get_units(obj_map<expr, bool>& units) override { units.reset(); }

View file

@ -42,7 +42,7 @@ public:
// run the replacements the inverse direction. // run the replacements the inverse direction.
void invert() { m_proofs.reverse(); } void invert() { m_proofs.reverse(); }
void display(std::ostream & out) override {} void display(std::ostream &) override { }
}; };

View file

@ -39,7 +39,7 @@ namespace euf {
void merge_eh(enode* n1, enode* n2) override; void merge_eh(enode* n1, enode* n2) override;
void diseq_eh(enode* eq) override {} void diseq_eh(enode*) override { }
void undo() override; void undo() override;

View file

@ -101,7 +101,7 @@ namespace euf {
void merge_eh(enode* n1, enode* n2) override; void merge_eh(enode* n1, enode* n2) override;
void diseq_eh(enode* eq) override {} void diseq_eh(enode*) override { }
void propagate() override; void propagate() override;

View file

@ -122,7 +122,7 @@ namespace sls {
void propagate_literal(sat::literal lit) override { m_g = nullptr; } void propagate_literal(sat::literal lit) override { m_g = nullptr; }
bool propagate() override { return false; } bool propagate() override { return false; }
bool repair_down(app* e) override { return true; } bool repair_down(app* e) override { return true; }
void repair_up(app* e) override {} void repair_up(app*) override { }
void repair_literal(sat::literal lit) override { m_g = nullptr; } void repair_literal(sat::literal lit) override { m_g = nullptr; }
bool is_sat() override; bool is_sat() override;

View file

@ -51,7 +51,7 @@ namespace sls {
void on_restart() override {} void on_restart() override {}
std::ostream& display(std::ostream& out) const override; std::ostream& display(std::ostream& out) const override;
bool set_value(expr* e, expr* v) override; bool set_value(expr* e, expr* v) override;
void collect_statistics(statistics& st) const override {} void collect_statistics(statistics&) const override { }
void reset_statistics() override {} void reset_statistics() override {}
}; };

View file

@ -92,7 +92,7 @@ namespace sls {
void register_term(expr* e) override; void register_term(expr* e) override;
bool set_value(expr* e, expr* v) override { return false; } bool set_value(expr* e, expr* v) override { return false; }
void repair_literal(sat::literal lit) override {} void repair_literal(sat::literal) override { }
bool include_func_interp(func_decl* f) const override; bool include_func_interp(func_decl* f) const override;
bool check_ackerman(func_decl* f) const override; bool check_ackerman(func_decl* f) const override;

View file

@ -72,9 +72,9 @@ namespace sls {
bool set_value(expr* e, expr* v) override { return false; } bool set_value(expr* e, expr* v) override { return false; }
bool include_func_interp(func_decl* f) const override; bool include_func_interp(func_decl* f) const override;
void repair_up(app* e) override {} void repair_up(app*) override { }
bool repair_down(app* e) override { return false; } bool repair_down(app* e) override { return false; }
void repair_literal(sat::literal lit) override {} void repair_literal(sat::literal) override { }
void collect_statistics(statistics& st) const override; void collect_statistics(statistics& st) const override;
void reset_statistics() override; void reset_statistics() override;

View file

@ -185,7 +185,7 @@ namespace sls {
bool repair_down(app* e) override; bool repair_down(app* e) override;
void repair_literal(sat::literal lit) override; void repair_literal(sat::literal lit) override;
void collect_statistics(statistics& st) const override {} void collect_statistics(statistics&) const override { }
void reset_statistics() override {} void reset_statistics() override {}
}; };

View file

@ -62,7 +62,7 @@ class fpa_value_factory : public value_factory {
} }
expr * get_fresh_value(sort * s) override { return get_some_value(s); } expr * get_fresh_value(sort * s) override { return get_some_value(s); }
void register_value(expr * n) override { /* Ignore */ } void register_value(expr *) override { /* Ignore */ }
app * mk_value(mpf const & x) { app * mk_value(mpf const & x) {
return m_util.mk_value(x); return m_util.mk_value(x);

View file

@ -70,7 +70,7 @@ public:
expr * get_fresh_value(sort * s) override; expr * get_fresh_value(sort * s) override;
void register_value(expr * n) override { } void register_value(expr *) override { }
}; };
/** /**

View file

@ -97,7 +97,7 @@ namespace opt {
rational get_lower() const override { return m_lower; } rational get_lower() const override { return m_lower; }
rational get_upper() const override { return m_upper; } rational get_upper() const override { return m_upper; }
bool get_assignment(unsigned index) const override { return m_soft[index].is_true(); } bool get_assignment(unsigned index) const override { return m_soft[index].is_true(); }
void collect_statistics(statistics& st) const override { } void collect_statistics(statistics&) const override { }
void get_model(model_ref& mdl, svector<symbol>& labels) override { mdl = m_model.get(); labels = m_labels;} void get_model(model_ref& mdl, svector<symbol>& labels) override { mdl = m_model.get(); labels = m_labels;}
virtual void commit_assignment(); virtual void commit_assignment();
void set_model() { s().get_model(m_model); s().get_labels(m_labels); } void set_model() { s().get_model(m_model); s().get_labels(m_labels); }

View file

@ -121,11 +121,11 @@ public:
m_opt(opt) m_opt(opt)
{} {}
void reset(cmd_context & ctx) override { } void reset(cmd_context &) override { }
char const * get_usage() const override { return "<term>"; } char const * get_usage() const override { return "<term>"; }
char const * get_descr(cmd_context & ctx) const override { return "check sat modulo objective function";} char const * get_descr(cmd_context & ctx) const override { return "check sat modulo objective function";}
unsigned get_arity() const override { return 1; } unsigned get_arity() const override { return 1; }
void prepare(cmd_context & ctx) override {} void prepare(cmd_context &) override { }
cmd_arg_kind next_arg_kind(cmd_context & ctx) const override { return CPK_EXPR; } cmd_arg_kind next_arg_kind(cmd_context & ctx) const override { return CPK_EXPR; }
void set_next_arg(cmd_context & ctx, expr * t) override { void set_next_arg(cmd_context & ctx, expr * t) override {
@ -152,11 +152,11 @@ public:
m_opt(opt) m_opt(opt)
{} {}
void reset(cmd_context & ctx) override { } void reset(cmd_context &) override { }
char const * get_usage() const override { return "(get-objectives)"; } char const * get_usage() const override { return "(get-objectives)"; }
char const * get_descr(cmd_context & ctx) const override { return "retrieve the objective values (after optimization)"; } char const * get_descr(cmd_context & ctx) const override { return "retrieve the objective values (after optimization)"; }
unsigned get_arity() const override { return 0; } unsigned get_arity() const override { return 0; }
void prepare(cmd_context & ctx) override {} void prepare(cmd_context &) override { }
void failure_cleanup(cmd_context & ctx) override { void failure_cleanup(cmd_context & ctx) override {