Fix unused parameter warnings in empty override functions by omitting parameter names (#8174)

* Initial plan

* Fix unused parameter warnings in empty override functions

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

* Omit parameter names in empty override functions instead of casting to void

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

src/ast/converters/equiv_proof_converter.h

@@ -44,6 +44,6 @@ public:
 
     ast_manager& get_manager() { return m; }
 
-    void display(std::ostream & out) override {}
+    void display(std::ostream &) override { }
 };
 

src/ast/converters/generic_model_converter.h

@@ -50,7 +50,7 @@ public:
 
     void add(expr * d, expr* e) { SASSERT(is_app(d) && to_app(d)->get_num_args() == 0); add(to_app(d)->get_decl(), e); }
     
-    void operator()(labels_vec & labels) override {}
+    void operator()(labels_vec &) override { }
     
     void operator()(model_ref & md) override;
 

src/ast/converters/horn_subsume_model_converter.h

@@ -76,7 +76,7 @@ public:
 
     ast_manager& get_manager() { return m; }
 
-    void display(std::ostream & out) override {}
+    void display(std::ostream &) override { }
 
     void get_units(obj_map<expr, bool>& units) override { units.reset(); }
 

src/ast/converters/replace_proof_converter.h

@@ -42,7 +42,7 @@ public:
     // run the replacements the inverse direction.
     void invert() { m_proofs.reverse(); }
 
-    void display(std::ostream & out) override {}
+    void display(std::ostream &) override { }
 
 };
 

src/ast/euf/euf_arith_plugin.h

@@ -39,7 +39,7 @@ namespace euf {
 
         void merge_eh(enode* n1, enode* n2) override;
 
-        void diseq_eh(enode* eq) override {}
+        void diseq_eh(enode*) override { }
 
         void undo() override;
 

src/ast/euf/euf_bv_plugin.h

@@ -101,7 +101,7 @@ namespace euf {
 
         void merge_eh(enode* n1, enode* n2) override;
 
-        void diseq_eh(enode* eq) override {}
+        void diseq_eh(enode*) override { }
 
         void propagate() override;
 

src/ast/sls/sls_array_plugin.h

@@ -122,7 +122,7 @@ namespace sls {
         void propagate_literal(sat::literal lit) override { m_g = nullptr; }
         bool propagate() override { return false; }
         bool repair_down(app* e) override { return true; }
-        void repair_up(app* e) override {}
+        void repair_up(app*) override { }
         void repair_literal(sat::literal lit) override { m_g = nullptr; }
         bool is_sat() override;
 

src/ast/sls/sls_basic_plugin.h

@@ -51,7 +51,7 @@ namespace sls {
         void on_restart() override {}
         std::ostream& display(std::ostream& out) const override;
         bool set_value(expr* e, expr* v) override;
-        void collect_statistics(statistics& st) const override {}
+        void collect_statistics(statistics&) const override { }
         void reset_statistics() override {}
     };
 

src/ast/sls/sls_datatype_plugin.h

@@ -92,7 +92,7 @@ namespace sls {
         void register_term(expr* e) override;
 
         bool set_value(expr* e, expr* v) override { return false; }
-        void repair_literal(sat::literal lit) override {}
+        void repair_literal(sat::literal) override { }
         bool include_func_interp(func_decl* f) const override;
         bool check_ackerman(func_decl* f) const override;
 

src/ast/sls/sls_euf_plugin.h

@@ -72,9 +72,9 @@ namespace sls {
         bool set_value(expr* e, expr* v) override { return false; }
         bool include_func_interp(func_decl* f) const override;
 
-        void repair_up(app* e) override {}
+        void repair_up(app*) override { }
         bool repair_down(app* e) override { return false; }
-        void repair_literal(sat::literal lit) override {}
+        void repair_literal(sat::literal) override { }
 
         void collect_statistics(statistics& st) const override;
         void reset_statistics() override;

src/ast/sls/sls_seq_plugin.h

@@ -185,7 +185,7 @@ namespace sls {
         bool repair_down(app* e) override;
         void repair_literal(sat::literal lit) override;
 
-        void collect_statistics(statistics& st) const override {}
+        void collect_statistics(statistics&) const override { }
         void reset_statistics() override {}
 
     };