3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-04-15 13:28:47 +00:00

move sorting of nex expressions to nex_creator

Signed-off-by: Lev Nachmanson <levnach@hotmail.com>
This commit is contained in:
Lev Nachmanson 2019-09-27 17:56:13 -07:00
parent 090851559b
commit d535a3cfbc

350
src/math/lp/nex_creator.cpp Normal file
View file

@ -0,0 +1,350 @@
/*++
Copyright (c) 2017 Microsoft Corporation
Module Name:
<name>
Abstract:
<abstract>
Author:
Nikolaj Bjorner (nbjorner)
Lev Nachmanson (levnach)
Revision History:
--*/
#include "math/lp/nex_creator.h"
#include <map>
namespace nla {
nex * nex_creator::mk_div(const nex* a, lpvar j) {
SASSERT(is_simplified(a));
TRACE("nla_cn_details", tout << "a=" << *a << ", v" << j << "\n";);
SASSERT((a->is_mul() && a->contains(j)) || (a->is_var() && to_var(a)->var() == j));
if (a->is_var())
return mk_scalar(rational(1));
vector<nex_pow> bv;
bool seenj = false;
for (auto& p : to_mul(a)->children()) {
const nex * c = p.e();
int pow = p.pow();
if (!seenj) {
if (c->contains(j)) {
if (!c->is_var()) {
bv.push_back(nex_pow(mk_div(c, j)));
if (pow != 1) {
bv.push_back(nex_pow(clone(c), pow));
}
} else {
SASSERT(to_var(c)->var() == j);
if (p.pow() != 1) {
bv.push_back(nex_pow(mk_var(j), pow - 1));
}
}
seenj = true;
}
} else {
bv.push_back(nex_pow(clone(c)));
}
}
if (bv.size() > 1) {
return mk_mul(bv);
}
if (bv.size() == 1 && bv.begin()->pow() == 1) {
return bv.begin()->e();
}
if (bv.size() == 0)
return mk_scalar(rational(1));
return mk_mul(bv);
}
bool nex_creator::eat_scalar_pow(nex_scalar *& r, nex_pow& p) {
if (!p.e()->is_scalar())
return false;
nex_scalar *pe = to_scalar(p.e());
if (r == nullptr) {
r = pe;
r->value() = r->value().expt(p.pow());
} else {
r->value() *= pe->value().expt(p.pow());
}
return true;
}
void nex_creator::simplify_children_of_mul(vector<nex_pow> & children) {
nex_scalar* r = nullptr;
TRACE("nla_cn_details", print_vector(children, tout););
vector<nex_pow> to_promote;
int skipped = 0;
for(unsigned j = 0; j < children.size(); j++) {
nex_pow& p = children[j];
if (eat_scalar_pow(r, p)) {
skipped++;
continue;
}
p.e() = simplify(p.e());
if ((p.e())->is_mul()) {
to_promote.push_back(p);
} else {
unsigned offset = to_promote.size() + skipped;
if (offset) {
children[j - offset] = p;
}
}
}
children.shrink(children.size() - to_promote.size() - skipped);
for (nex_pow & p : to_promote) {
for (nex_pow& pp : to_mul(p.e())->children()) {
if (!eat_scalar_pow(r, pp))
children.push_back(nex_pow(pp.e(), pp.pow() * p.pow()));
}
}
if (r != nullptr) {
children.push_back(nex_pow(r));
}
mul_to_powers(children);
TRACE("nla_cn_details", print_vector(children, tout););
}
bool nex_creator::mul_simplify_lt(const nex_mul* a, const nex_mul* b) {
NOT_IMPLEMENTED_YET();
}
bool nex_creator::sum_simplify_lt(const nex* a, const nex* b) {
int r = (int)(a->type()) - (int)(b->type());
if (r) {
return r < 0;
}
SASSERT(a->type() == b->type());
switch (a->type()) {
case expr_type::VAR: {
return less_than(to_var(a)->var() , to_var(b)->var());
}
case expr_type::SCALAR: {
return to_scalar(a)->value() < to_scalar(b)->value();
}
case expr_type::MUL: {
return mul_simplify_lt(to_mul(a), to_mul(b));
}
case expr_type::SUM: {
UNREACHABLE();
return false;
}
default:
SASSERT(false);
return false;
}
return false;
}
bool nex_creator::is_sorted(const nex_mul* e) const {
for (unsigned j = 0; j < e->children().size() - 1; j++) {
if (!(less_than_on_nex_pow(e->children()[j], e->children()[j+1])))
return false;
}
return true;
}
bool nex_creator::mul_is_simplified(const nex_mul* e) const {
if (size() == 1 && e->children().begin()->pow() == 1)
return false;
std::set<const nex*, nex_lt> s([this](const nex* a, const nex* b) {return less_than_nex(a, b); });
for (const auto &p : e->children()) {
const nex* ee = p.e();
if (p.pow() == 0)
return false;
if (ee->is_mul())
return false;
if (ee->is_scalar() && to_scalar(ee)->value().is_one())
return false;
auto it = s.find(ee);
if (it == s.end()) {
s.insert(ee);
} else {
TRACE("nla_cn_details", tout << "not simplified " << *ee << "\n";);
return false;
}
}
return is_sorted(e);
}
nex * nex_creator::simplify_mul(nex_mul *e) {
TRACE("nla_cn_details", tout << *e << "\n";);
simplify_children_of_mul(e->children());
if (size() == 1 && e->children()[0].pow() == 1)
return e->children()[0].e();
TRACE("nla_cn_details", tout << *e << "\n";);
SASSERT(is_simplified(e));
return e;
}
nex* nex_creator::simplify_sum(nex_sum *e) {
simplify_children_of_sum(e->children());
if (e->size() == 1)
return e->children()[0];
return e;
}
bool nex_creator::sum_is_simplified(nex_sum* e) const {
if (e->size() < 2) return false;
for (nex * ee : e->children()) {
if (ee->is_sum())
return false;
if (ee->is_scalar() && to_scalar(ee)->value().is_zero())
return false;
}
return true;
}
void nex_creator::mul_to_powers(vector<nex_pow>& children) {
std::map<nex*, int, nex_lt> m([this](const nex* a, const nex* b) {return less_than_nex(a, b); });
for (auto & p : children) {
auto it = m.find(p.e());
if (it == m.end()) {
m[p.e()] = p.pow();
} else {
it->second+= p.pow();
}
}
children.clear();
for (auto & p : m) {
children.push_back(nex_pow(p.first, p.second));
}
std::sort(children.begin(), children.end(), [this](const nex_pow& a, const nex_pow& b) {
return less_than_on_nex_pow(a, b);
});
}
nex* nex_creator::create_child_from_nex_and_coeff(nex *e,
const rational& coeff) {
if (coeff.is_one())
return e;
SASSERT(is_simplified(e));
switch (e->type()) {
case expr_type::VAR: {
if (coeff.is_one())
return e;
return mk_mul(mk_scalar(coeff), e);
}
case expr_type::SCALAR: {
UNREACHABLE();
return nullptr;
}
case expr_type::MUL: {
nex_mul * em = to_mul(e);
nex_pow *np = em->children().begin();
if (np->e()->is_scalar()) {
SASSERT(np->pow() == 1);
to_scalar(np->e())->value() = coeff;
return e;
}
em->add_child(mk_scalar(coeff));
std::sort(em->children().begin(), em->children().end(), [this](const nex_pow& a,
const nex_pow& b) {return less_than_on_nex_pow(a, b);});
return em;
}
case expr_type::SUM: {
return mk_mul(mk_scalar(coeff), e);
}
default:
UNREACHABLE();
return nullptr;
}
}
// a + 3bc + 2bc => a + 5bc
void nex_creator::sort_join_sum(ptr_vector<nex> & children) {
std::map<nex*, rational, nex_lt> m([this](const nex *a , const nex *b)
{ return sum_simplify_lt(a, b); });
fill_map_with_children(m, children);
children.clear();
for (auto& p : m) {
children.push_back(create_child_from_nex_and_coeff(p.first, p.second));
}
}
rational nex_creator::extract_coeff_from_mul(const nex_mul* m) {
const nex* e = m->children().begin()->e();
if (e->is_scalar())
return to_scalar(e)->value();
return rational(1);
}
void nex_creator::fill_map_with_children(std::map<nex*, rational, nex_lt> & m, ptr_vector<nex> & children) {
nex_scalar * scalar = nullptr;
TRACE("nla_cn_details", print_vector_of_ptrs(children, tout););
for (nex* e : children) {
if (e->is_scalar()) {
if (scalar == nullptr) {
scalar = to_scalar(e);
} else {
scalar->value() += to_scalar(e)->value();
}
} else {
rational r = extract_coeff(e);
auto it = m.find(e);
if (it == m.end()) {
m[e] = r;
} else {
it->second += r;
}
}
}
if (scalar && scalar->value().is_zero() == false) {
m[scalar] = rational();
}
}
bool is_zero_scalar(nex *e) {
return e->is_scalar() && to_scalar(e)->value().is_zero();
}
void nex_creator::simplify_children_of_sum(ptr_vector<nex> & children) {
ptr_vector<nex> to_promote;
int skipped = 0;
for(unsigned j = 0; j < children.size(); j++) {
nex* e = children[j] = simplify(children[j]);
if (e->is_sum()) {
to_promote.push_back(e);
} else if (is_zero_scalar(e)) {
skipped ++;
continue;
} else {
unsigned offset = to_promote.size() + skipped;
if (offset) {
children[j - offset] = e;
}
}
}
children.shrink(children.size() - to_promote.size() - skipped);
for (nex *e : to_promote) {
for (nex *ee : *(to_sum(e)->children_ptr())) {
if (!is_zero_scalar(ee))
children.push_back(ee);
}
}
sort_join_sum(children);
}
}