simplify code + remove unused file

src/ast/converters/generic_model_converter.cpp

@@ -28,11 +28,6 @@ Notes:
 #include "model/model_v2_pp.h"
 #include "model/model_evaluator.h"
 
-
-generic_model_converter::~generic_model_converter() {
-}
-
-
 void generic_model_converter::add(func_decl * d, expr* e) {
     VERIFY(e);
     VERIFY(d->get_range() == e->get_sort());

src/ast/converters/generic_model_converter.h

@@ -41,8 +41,6 @@ private:
 public:
     generic_model_converter(ast_manager & m, char const* orig) : m(m), m_orig(orig) {}
     
-    ~generic_model_converter() override;
-    
     void hide(expr* e) { SASSERT(is_app(e) && to_app(e)->get_num_args() == 0); hide(to_app(e)->get_decl()); }
 
     void hide(func_decl * f) { m_entries.push_back(entry(f, nullptr, m, HIDE)); }

src/smt/tactic/smt_tactic_core.h

@@ -24,7 +24,6 @@ Notes:
 #include "tactic/goal.h"
 
 class tactic;
-class filter_model_converter;
 
 tactic * mk_smt_tactic_core(ast_manager& m, params_ref const & p = params_ref(), symbol const& logic = symbol::null);
 // syntax sugar for using_params(mk_smt_tactic(), p) where p = (:auto_config, auto_config)

src/tactic/filter_model_converter.h

@@ -1,50 +0,0 @@
-/*++
-Copyright (c) 2011 Microsoft Corporation
-
-Module Name:
-
-    filter_model_converter.h
-
-Abstract:
-
-    Filter decls from a model
-
-Author:
-
-    Leonardo (leonardo) 2011-05-06
-
-Notes:
-
---*/
-#pragma once
-
-#include "tactic/model_converter.h"
-
-class filter_model_converter : public model_converter {
-    func_decl_ref_vector  m_decls;
-public:
-    filter_model_converter(ast_manager & m):m_decls(m) {}
-    
-    ~filter_model_converter() override;
-    
-    ast_manager & m() const { return m_decls.get_manager(); }
-    
-    void operator()(model_ref & md, unsigned goal_idx) override;
-
-    virtual void operator()(svector<symbol> & labels, unsigned goal_idx);
-    
-    void operator()(model_ref & md) override { operator()(md, 0); } // TODO: delete
-
-    void cancel() override {}
-
-    void display(std::ostream & out) override;
-
-    void insert(func_decl * d) {
-        m_decls.push_back(d);
-    }
-
-    model_converter * translate(ast_translation & translator) override;
-};
-
-typedef ref<filter_model_converter> filter_model_converter_ref;
-

src/tactic/goal.cpp

@@ -159,9 +159,7 @@ void goal::quick_process(bool save_first, expr_ref& f, expr_dependency * d) {
     while (!todo.empty()) {
         if (m_inconsistent)
             return;
-        expr_pol p = todo.back();
+        auto [curr, pol] = todo.back();
-        expr * curr = p.first;
-        bool   pol = p.second;
         todo.pop_back();
         if (pol && m().is_and(curr)) {
             app * t = to_app(curr);