mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-06-05 16:40:52 +00:00
Code Activity

Build Warning Fixer: Build Z3 directly instead of reading workflow logs (#8148)

Browse source 
* Initial plan

* Update Build Warning Fixer to build Z3 directly instead of reading logs

- Change workflow to pick a random build configuration and build Z3 directly
- Remove GitHub Actions toolset and agentic-workflows tool dependencies
- Update instructions to extract warnings from direct build output
- Increase timeout from 30 to 60 minutes to accommodate build time
- Add examples for wip.yml, cross-build.yml, and coverage.yml workflows

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-10 20:25:01 -08:00 • committed by GitHub
parent 94898c6bf8
commit d29fc3eef3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 92 additions and 141 deletions
Download patch file Download diff file Expand all files Collapse all files

129
.github/workflows/build-warning-fixer.lock.yml generated vendored
View file

@ -19,7 +19,7 @@
# gh aw compile # gh aw compile
# For more information: https://github.com/githubnext/gh-aw/blob/main/.github/aw/github-agentic-workflows.md # For more information: https://github.com/githubnext/gh-aw/blob/main/.github/aw/github-agentic-workflows.md
# #
# Automatically analyzes build warnings from CI runs and creates PRs with fixes # Automatically builds Z3 directly and fixes detected build warnings
name: "Build Warning Fixer" name: "Build Warning Fixer"
"on": "on":
@ -145,19 +145,6 @@ jobs:
await determineAutomaticLockdown(github, context, core); await determineAutomaticLockdown(github, context, core);
- name: Downloading container images - name: Downloading container images
run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/github-mcp-server:v0.27.0 run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/github-mcp-server:v0.27.0
- name: Install gh-aw extension
env:
GH_TOKEN: ${{ secrets.GH_AW_GITHUB_MCP_SERVER_TOKEN || secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }}
run: |
# Check if gh-aw extension is already installed
if gh extension list | grep -q "githubnext/gh-aw"; then
echo "gh-aw extension already installed, upgrading..."
gh extension upgrade gh-aw || true
else
echo "Installing gh-aw extension..."
gh extension install githubnext/gh-aw
fi
gh aw --version
- name: Write Safe Outputs Config - name: Write Safe Outputs Config
run: | run: |
mkdir -p /opt/gh-aw/safeoutputs mkdir -p /opt/gh-aw/safeoutputs
@ -317,22 +304,12 @@ jobs:
GH_AW_SAFE_OUTPUTS: ${{ env.GH_AW_SAFE_OUTPUTS }} GH_AW_SAFE_OUTPUTS: ${{ env.GH_AW_SAFE_OUTPUTS }}
GITHUB_MCP_LOCKDOWN: ${{ steps.determine-automatic-lockdown.outputs.lockdown == 'true' && '1' || '0' }} GITHUB_MCP_LOCKDOWN: ${{ steps.determine-automatic-lockdown.outputs.lockdown == 'true' && '1' || '0' }}
GITHUB_MCP_SERVER_TOKEN: ${{ secrets.GH_AW_GITHUB_MCP_SERVER_TOKEN || secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} GITHUB_MCP_SERVER_TOKEN: ${{ secrets.GH_AW_GITHUB_MCP_SERVER_TOKEN || secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: | run: |
mkdir -p /tmp/gh-aw/mcp-config mkdir -p /tmp/gh-aw/mcp-config
mkdir -p /home/runner/.copilot mkdir -p /home/runner/.copilot
cat > /home/runner/.copilot/mcp-config.json << EOF cat > /home/runner/.copilot/mcp-config.json << EOF
{ {
"mcpServers": { "mcpServers": {
"agentic_workflows": {
"type": "local",
"command": "gh",
"args": ["aw", "mcp-server"],
"tools": ["*"],
"env": {
"GITHUB_TOKEN": "\${GITHUB_TOKEN}"
}
},
"github": { "github": {
"type": "local", "type": "local",
"command": "docker", "command": "docker",
@ -343,9 +320,11 @@ jobs:
"-e", "-e",
"GITHUB_PERSONAL_ACCESS_TOKEN", "GITHUB_PERSONAL_ACCESS_TOKEN",
"-e", "-e",
"GITHUB_READ_ONLY=1",
"-e",
"GITHUB_LOCKDOWN_MODE=$GITHUB_MCP_LOCKDOWN", "GITHUB_LOCKDOWN_MODE=$GITHUB_MCP_LOCKDOWN",
"-e", "-e",
"GITHUB_TOOLSETS=context,repos,issues,pull_requests,actions", "GITHUB_TOOLSETS=context,repos,issues,pull_requests",
"ghcr.io/github/github-mcp-server:v0.27.0" "ghcr.io/github/github-mcp-server:v0.27.0"
], ],
"tools": ["*"], "tools": ["*"],
@ -447,69 +426,57 @@ jobs:
## Your Task ## Your Task
1. **Find recent build logs** from GitHub Actions workflows 1. **Pick a random build workflow and build Z3 directly**
Target these build workflows which run regularly and may contain warnings: Available build workflows that you can randomly choose from:
- `msvc-static-build-clang-cl.yml` - Clang-CL MSVC static builds (runs every 2 days) - `wip.yml` - Ubuntu CMake Debug build (simple, good default choice)
- `msvc-static-build.yml` - MSVC static builds - `cross-build.yml` - Cross-compilation builds (aarch64, riscv64, powerpc64)
- `Windows.yml` - Windows builds - `coverage.yml` - Code coverage build with Clang
- `wip.yml` - Open issues workflow with Ubuntu builds
- Check for other active build workflows with `list_workflows`
**Recommended Approach: Use the agentic-workflows tool** **Steps to build Z3 directly:**
The easiest way to analyze workflow logs is using the `agentic-workflows` tool which provides high-level commands: a. **Pick ONE workflow randomly** from the list above. Use bash to generate a random choice if needed.
``` b. **Read the workflow file** to understand its build configuration:
To download and analyze logs from a workflow: - Use `view` to read the `.github/workflows/<workflow-name>.yml` file
- Tool: agentic-workflows - Identify the build steps, cmake flags, compiler settings, and environment variables
- Command: logs - Note the runner type (ubuntu-latest, windows-latest, etc.)
- Parameters: workflow_name: "msvc-static-build-clang-cl" (without .yml extension)
c. **Execute the build directly** using bash:
- Run the same cmake configuration commands from the workflow
- Capture the full build output including warnings
- Use `2>&1` to capture both stdout and stderr
- Save output to a log file for analysis
Example for wip.yml workflow:
```bash
# Configure
cmake -B build -DCMAKE_BUILD_TYPE=Debug 2>&1 | tee build-config.log
# Build and capture output
cmake --build build --config Debug 2>&1 | tee build-output.log
``` ```
This will download recent workflow run logs and provide structured analysis including: Example for cross-build.yml workflow (pick one arch):
- Error messages and warnings ```bash
- Token usage and costs # Pick one architecture randomly
- Execution times ARCH=aarch64 # or riscv64, or powerpc64
- Success/failure patterns
**Alternative: Use GitHub Actions MCP tools directly** # Configure
mkdir build && cd build
cmake -DCMAKE_CXX_COMPILER=${ARCH}-linux-gnu-g++-11 ../ 2>&1 | tee ../build-config.log
You can also use the GitHub Actions tools for more granular control: # Build and capture output
make -j$(nproc) 2>&1 | tee ../build-output.log
Step 1: List workflows
```
Tool: github-mcp-server-actions_list (or actions_list)
Parameters:
- method: "list_workflows"
- owner: "Z3Prover"
- repo: "z3"
``` ```
Step 2: List recent runs d. **Install any necessary dependencies** before building:
``` - For cross-build: `apt update && apt install -y ninja-build cmake python3 g++-11-aarch64-linux-gnu` (or other arch)
Tool: github-mcp-server-actions_list (or actions_list) - For coverage: `apt-get install -y gcovr ninja-build llvm clang`
Parameters:
- method: "list_workflow_runs"
- owner: "Z3Prover"
- repo: "z3"
- resource_id: "msvc-static-build-clang-cl.yml"
- per_page: 5
```
Step 3: Get job logs
```
Tool: github-mcp-server-get_job_logs (or get_job_logs)
Parameters:
- owner: "Z3Prover"
- repo: "z3"
- run_id: <from step 2>
- failed_only: false
- return_content: true
- tail_lines: 2000
```
2. **Extract compiler warnings** from the build logs: 2. **Extract compiler warnings** from the direct build output:
- Analyze the build-output.log file you created
- Use `grep` or `bash` to search for warning patterns
- Look for C++ compiler warnings (gcc, clang, MSVC patterns) - Look for C++ compiler warnings (gcc, clang, MSVC patterns)
- Common warning patterns: - Common warning patterns:
- `-Wunused-variable`, `-Wunused-parameter` - `-Wunused-variable`, `-Wunused-parameter`
@ -544,10 +511,10 @@ jobs:
6. **Create a pull request** with your fixes: 6. **Create a pull request** with your fixes:
- Use the `create-pull-request` safe output - Use the `create-pull-request` safe output
- Title: "Fix build warnings detected in CI" - Title: "Fix build warnings detected in direct build"
- Body should include: - Body should include:
- Which workflow configuration was used for the build
- List of warnings fixed - List of warnings fixed
- Which build logs triggered this fix
- Explanation of each change - Explanation of each change
- Note that this is an automated fix requiring human review - Note that this is an automated fix requiring human review
@ -703,7 +670,7 @@ jobs:
# --allow-tool safeoutputs # --allow-tool safeoutputs
# --allow-tool shell # --allow-tool shell
# --allow-tool write # --allow-tool write
timeout-minutes: 30 timeout-minutes: 60
run: | run: |
set -o pipefail set -o pipefail
sudo -E awf --env-all --container-workdir "${GITHUB_WORKSPACE}" --mount /tmp:/tmp:rw --mount "${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE}:rw" --mount /usr/bin/date:/usr/bin/date:ro --mount /usr/bin/gh:/usr/bin/gh:ro --mount /usr/bin/yq:/usr/bin/yq:ro --mount /usr/local/bin/copilot:/usr/local/bin/copilot:ro --mount /home/runner/.copilot:/home/runner/.copilot:rw --mount /opt/gh-aw:/opt/gh-aw:ro --allow-domains api.business.githubcopilot.com,api.enterprise.githubcopilot.com,api.github.com,api.githubcopilot.com,api.individual.githubcopilot.com,github.com,host.docker.internal,raw.githubusercontent.com,registry.npmjs.org --log-level info --proxy-logs-dir /tmp/gh-aw/sandbox/firewall/logs --image-tag 0.8.2 \ sudo -E awf --env-all --container-workdir "${GITHUB_WORKSPACE}" --mount /tmp:/tmp:rw --mount "${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE}:rw" --mount /usr/bin/date:/usr/bin/date:ro --mount /usr/bin/gh:/usr/bin/gh:ro --mount /usr/bin/yq:/usr/bin/yq:ro --mount /usr/local/bin/copilot:/usr/local/bin/copilot:ro --mount /home/runner/.copilot:/home/runner/.copilot:rw --mount /opt/gh-aw:/opt/gh-aw:ro --allow-domains api.business.githubcopilot.com,api.enterprise.githubcopilot.com,api.github.com,api.githubcopilot.com,api.individual.githubcopilot.com,github.com,host.docker.internal,raw.githubusercontent.com,registry.npmjs.org --log-level info --proxy-logs-dir /tmp/gh-aw/sandbox/firewall/logs --image-tag 0.8.2 \
@ -950,7 +917,7 @@ jobs:
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
env: env:
WORKFLOW_NAME: "Build Warning Fixer" WORKFLOW_NAME: "Build Warning Fixer"
WORKFLOW_DESCRIPTION: "Automatically analyzes build warnings from CI runs and creates PRs with fixes" WORKFLOW_DESCRIPTION: "Automatically builds Z3 directly and fixes detected build warnings"
HAS_PATCH: ${{ needs.agent.outputs.has_patch }} HAS_PATCH: ${{ needs.agent.outputs.has_patch }}
with: with:
script: | script: |

104
.github/workflows/build-warning-fixer.md vendored
View file

@ -1,14 +1,10 @@
--- ---
description: Automatically analyzes build warnings from CI runs and creates PRs with fixes description: Automatically builds Z3 directly and fixes detected build warnings
on: on:
schedule: daily schedule: daily
workflow_dispatch: workflow_dispatch:
permissions: read-all permissions: read-all
tools: tools:
github:
toolsets: [default, actions]
read-only: false
agentic-workflows:
view: {} view: {}
grep: {} grep: {}
glob: {} glob: {}
@ -19,7 +15,7 @@ safe-outputs:
if-no-changes: ignore if-no-changes: ignore
missing-tool: missing-tool:
create-issue: true create-issue: true
timeout-minutes: 30 timeout-minutes: 60
--- ---
# Build Warning Fixer # Build Warning Fixer
@ -28,69 +24,57 @@ You are an AI agent that automatically detects and fixes build warnings in the Z
## Your Task ## Your Task
1. **Find recent build logs** from GitHub Actions workflows 1. **Pick a random build workflow and build Z3 directly**
Target these build workflows which run regularly and may contain warnings: Available build workflows that you can randomly choose from:
- `msvc-static-build-clang-cl.yml` - Clang-CL MSVC static builds (runs every 2 days) - `wip.yml` - Ubuntu CMake Debug build (simple, good default choice)
- `msvc-static-build.yml` - MSVC static builds - `cross-build.yml` - Cross-compilation builds (aarch64, riscv64, powerpc64)
- `Windows.yml` - Windows builds - `coverage.yml` - Code coverage build with Clang
- `wip.yml` - Open issues workflow with Ubuntu builds
- Check for other active build workflows with `list_workflows`
**Recommended Approach: Use the agentic-workflows tool** **Steps to build Z3 directly:**
The easiest way to analyze workflow logs is using the `agentic-workflows` tool which provides high-level commands: a. **Pick ONE workflow randomly** from the list above. Use bash to generate a random choice if needed.
``` b. **Read the workflow file** to understand its build configuration:
To download and analyze logs from a workflow: - Use `view` to read the `.github/workflows/<workflow-name>.yml` file
- Tool: agentic-workflows - Identify the build steps, cmake flags, compiler settings, and environment variables
- Command: logs - Note the runner type (ubuntu-latest, windows-latest, etc.)
- Parameters: workflow_name: "msvc-static-build-clang-cl" (without .yml extension)
c. **Execute the build directly** using bash:
- Run the same cmake configuration commands from the workflow
- Capture the full build output including warnings
- Use `2>&1` to capture both stdout and stderr
- Save output to a log file for analysis
Example for wip.yml workflow:
```bash
# Configure
cmake -B build -DCMAKE_BUILD_TYPE=Debug 2>&1 | tee build-config.log
# Build and capture output
cmake --build build --config Debug 2>&1 | tee build-output.log
``` ```
This will download recent workflow run logs and provide structured analysis including: Example for cross-build.yml workflow (pick one arch):
- Error messages and warnings ```bash
- Token usage and costs # Pick one architecture randomly
- Execution times ARCH=aarch64 # or riscv64, or powerpc64
- Success/failure patterns
**Alternative: Use GitHub Actions MCP tools directly** # Configure
mkdir build && cd build
cmake -DCMAKE_CXX_COMPILER=${ARCH}-linux-gnu-g++-11 ../ 2>&1 | tee ../build-config.log
You can also use the GitHub Actions tools for more granular control: # Build and capture output
make -j$(nproc) 2>&1 | tee ../build-output.log
Step 1: List workflows
```
Tool: github-mcp-server-actions_list (or actions_list)
Parameters:
- method: "list_workflows"
- owner: "Z3Prover"
- repo: "z3"
``` ```
Step 2: List recent runs d. **Install any necessary dependencies** before building:
``` - For cross-build: `apt update && apt install -y ninja-build cmake python3 g++-11-aarch64-linux-gnu` (or other arch)
Tool: github-mcp-server-actions_list (or actions_list) - For coverage: `apt-get install -y gcovr ninja-build llvm clang`
Parameters:
- method: "list_workflow_runs"
- owner: "Z3Prover"
- repo: "z3"
- resource_id: "msvc-static-build-clang-cl.yml"
- per_page: 5
```
Step 3: Get job logs
```
Tool: github-mcp-server-get_job_logs (or get_job_logs)
Parameters:
- owner: "Z3Prover"
- repo: "z3"
- run_id: <from step 2>
- failed_only: false
- return_content: true
- tail_lines: 2000
```
2. **Extract compiler warnings** from the build logs: 2. **Extract compiler warnings** from the direct build output:
- Analyze the build-output.log file you created
- Use `grep` or `bash` to search for warning patterns
- Look for C++ compiler warnings (gcc, clang, MSVC patterns) - Look for C++ compiler warnings (gcc, clang, MSVC patterns)
- Common warning patterns: - Common warning patterns:
- `-Wunused-variable`, `-Wunused-parameter` - `-Wunused-variable`, `-Wunused-parameter`
@ -125,10 +109,10 @@ You are an AI agent that automatically detects and fixes build warnings in the Z
6. **Create a pull request** with your fixes: 6. **Create a pull request** with your fixes:
- Use the `create-pull-request` safe output - Use the `create-pull-request` safe output
- Title: "Fix build warnings detected in CI" - Title: "Fix build warnings detected in direct build"
- Body should include: - Body should include:
- Which workflow configuration was used for the build
- List of warnings fixed - List of warnings fixed
- Which build logs triggered this fix
- Explanation of each change - Explanation of each change
- Note that this is an automated fix requiring human review - Note that this is an automated fix requiring human review