mirror of
https://github.com/Z3Prover/z3
synced 2026-04-15 08:44:10 +00:00
Fix Ostrich Benchmark workflow: allow NuGet and guarantee safe output (#9267)
* Initial plan * fix ostrich-benchmark: add api.nuget.org to network allowlist and ensure safe output is always produced Agent-Logs-Url: https://github.com/Z3Prover/z3/sessions/7eb3a93e-e81b-4b79-b84b-080a7bacfec0 Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com> Co-authored-by: Nikolaj Bjorner <nbjorner@microsoft.com>
This commit is contained in:
parent
2ce410d45e
commit
d29a1ebd38
2 changed files with 16 additions and 2 deletions
2
.github/workflows/ostrich-benchmark.lock.yml
generated
vendored
2
.github/workflows/ostrich-benchmark.lock.yml
generated
vendored
|
|
@ -90,7 +90,7 @@ jobs:
|
|||
GH_AW_INFO_EXPERIMENTAL: "false"
|
||||
GH_AW_INFO_SUPPORTS_TOOLS_ALLOWLIST: "true"
|
||||
GH_AW_INFO_STAGED: "false"
|
||||
GH_AW_INFO_ALLOWED_DOMAINS: '["defaults"]'
|
||||
GH_AW_INFO_ALLOWED_DOMAINS: '["defaults","api.nuget.org"]'
|
||||
GH_AW_INFO_FIREWALL_ENABLED: "true"
|
||||
GH_AW_INFO_AWF_VERSION: "v0.25.18"
|
||||
GH_AW_INFO_AWMG_VERSION: ""
|
||||
|
|
|
|||
16
.github/workflows/ostrich-benchmark.md
vendored
16
.github/workflows/ostrich-benchmark.md
vendored
|
|
@ -8,7 +8,10 @@ on:
|
|||
|
||||
permissions: read-all
|
||||
|
||||
network: defaults
|
||||
network:
|
||||
allowed:
|
||||
- defaults
|
||||
- api.nuget.org
|
||||
|
||||
tools:
|
||||
bash: true
|
||||
|
|
@ -402,3 +405,14 @@ Post the Markdown report as a new GitHub Discussion using the `create-discussion
|
|||
- **Handle build failures gracefully**: If Z3 fails to build, report the error and create a brief discussion noting the build failure. If ZIPT fails to build, continue with only the seq/nseq columns and note `n/a` for ZIPT results.
|
||||
- **Large report**: Always put the per-file table in a `<details>` collapsible section since there may be many files.
|
||||
- **Progress logging**: Print a line per file as you run it (e.g., `[N] [filename] seq=...`) so the workflow log shows progress even for large benchmark sets.
|
||||
|
||||
## Safe Output Guarantee
|
||||
|
||||
You **MUST** call either `create_discussion` or `noop` before the workflow ends, regardless of what happened during execution:
|
||||
|
||||
- **Build succeeded, benchmarks ran**: Call `create_discussion` with the full report.
|
||||
- **Build succeeded, benchmarks partially ran**: Call `create_discussion` with whatever results were collected and a note about what could not be completed.
|
||||
- **Z3 build failed**: Call `noop` with a brief message describing the build error.
|
||||
- **No benchmarks could be run**: Call `noop` with a summary of what failed and why.
|
||||
|
||||
Failing to produce any safe output triggers an automatic workflow-failure issue that clutters the repository.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue