From cd2915ff3c09433752ad61d520c948c743e6fbbf Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Tue, 23 Jun 2026 19:56:19 -0600 Subject: [PATCH] Remove in-workflow Pyodide builds from nightly and release pipelines (#9935) Nightly and release workflows were still building Pyodide wheels inline, despite Pyodide now being handled by a dedicated workflow. This change removes duplicate Pyodide build work from those pipelines and aligns artifact assembly with the new split. - **Workflow graph cleanup** - Removed the `pyodide-python` job from: - `.github/workflows/nightly.yml` - `.github/workflows/release.yml` - **Packaging dependency updates** - Updated `python-package.needs` in both workflows to drop `pyodide-python`, so packaging no longer waits on an in-workflow Pyodide build. - **Artifact collection updates** - Removed `Download Pyodide Build` steps from both `python-package` jobs, eliminating references to `PyodidePythonBuild`. ```yaml python-package: needs: - mac-build-x64 - mac-build-arm64 - windows-build-x64 - windows-build-x86 - windows-build-arm64 - manylinux-python-amd64 - manylinux-python-arm64 - manylinux-python-riscv64 ``` Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> --- .github/workflows/nightly.yml | 60 +---------------------------------- .github/workflows/release.yml | 60 +---------------------------------- 2 files changed, 2 insertions(+), 118 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 8675d3da8..d2febd8e8 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -483,58 +483,6 @@ jobs: path: src/api/python/wheelhouse/*.whl retention-days: 2 - pyodide-python: - name: "Python bindings (Pyodide)" - runs-on: ubuntu-24.04 - timeout-minutes: 90 - steps: - - name: Checkout code - uses: actions/checkout@v7.0.0 - - - name: Setup packages - run: sudo apt-get update && sudo apt-get install -y python3-dev python3-pip python3-venv - - - name: Create venv - run: python3 -m venv ~/env - - - name: Install pyodide - run: ~/env/bin/pip install pyodide-build pyodide-cli - - - name: Configure Emscripten - run: | - git clone https://github.com/emscripten-core/emsdk.git ~/emsdk - cd ~/emsdk - PYODIDE_EMSCRIPTEN_VERSION=$(~/env/bin/pyodide config get emscripten_version) - ./emsdk install ${PYODIDE_EMSCRIPTEN_VERSION} - ./emsdk activate ${PYODIDE_EMSCRIPTEN_VERSION} - - - name: Build wheel - run: | - source ~/emsdk/emsdk_env.sh - cd src/api/python - # Exception/longjmp/bigint flags are declared in pyproject.toml and - # combined with Pyodide's -fwasm-exceptions defaults. Passing the - # legacy JS-EH -fexceptions flags here conflicts with the wasm-EH ABI. - ~/env/bin/pyodide build --exports whole_archive - - - name: Setup env-pyodide - run: | - source ~/env/bin/activate - source ~/emsdk/emsdk_env.sh - pyodide venv ~/env-pyodide - - - name: Test wheel - run: | - ~/env-pyodide/bin/pip install src/api/python/dist/*.whl - ~/env-pyodide/bin/python src/api/python/z3test.py z3 - - - name: Upload artifact - uses: actions/upload-artifact@v7 - with: - name: PyodidePythonBuild - path: src/api/python/dist/*.whl - retention-days: 2 - windows-build-x64: name: "Windows x64 build" runs-on: windows-latest @@ -742,7 +690,7 @@ jobs: python-package: name: "Python packaging" - needs: [mac-build-x64, mac-build-arm64, windows-build-x64, windows-build-x86, windows-build-arm64, manylinux-python-amd64, manylinux-python-arm64, manylinux-python-riscv64, pyodide-python] + needs: [mac-build-x64, mac-build-arm64, windows-build-x64, windows-build-x86, windows-build-arm64, manylinux-python-amd64, manylinux-python-arm64, manylinux-python-riscv64] runs-on: ubuntu-24.04 steps: - name: Checkout code @@ -801,12 +749,6 @@ jobs: name: ManyLinuxPythonBuildRiscv64 path: artifacts - - name: Download Pyodide Build - uses: actions/download-artifact@v8.0.1 - with: - name: PyodidePythonBuild - path: artifacts - - name: Extract builds run: | cd artifacts diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6dd385122..07387885b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -493,58 +493,6 @@ jobs: path: src/api/python/wheelhouse/*.whl retention-days: 7 - pyodide-python: - name: "Python bindings (Pyodide)" - runs-on: ubuntu-24.04 - timeout-minutes: 90 - steps: - - name: Checkout code - uses: actions/checkout@v7.0.0 - - - name: Setup packages - run: sudo apt-get update && sudo apt-get install -y python3-dev python3-pip python3-venv - - - name: Create venv - run: python3 -m venv ~/env - - - name: Install pyodide - run: ~/env/bin/pip install pyodide-build pyodide-cli - - - name: Configure Emscripten - run: | - git clone https://github.com/emscripten-core/emsdk.git ~/emsdk - cd ~/emsdk - PYODIDE_EMSCRIPTEN_VERSION=$(~/env/bin/pyodide config get emscripten_version) - ./emsdk install ${PYODIDE_EMSCRIPTEN_VERSION} - ./emsdk activate ${PYODIDE_EMSCRIPTEN_VERSION} - - - name: Build wheel - run: | - source ~/emsdk/emsdk_env.sh - cd src/api/python - # Exception/longjmp/bigint flags are declared in pyproject.toml and - # combined with Pyodide's -fwasm-exceptions defaults. Passing the - # legacy JS-EH -fexceptions flags here conflicts with the wasm-EH ABI. - ~/env/bin/pyodide build --exports whole_archive - - - name: Setup env-pyodide - run: | - source ~/env/bin/activate - source ~/emsdk/emsdk_env.sh - pyodide venv ~/env-pyodide - - - name: Test wheel - run: | - ~/env-pyodide/bin/pip install src/api/python/dist/*.whl - ~/env-pyodide/bin/python src/api/python/z3test.py z3 - - - name: Upload artifact - uses: actions/upload-artifact@v7 - with: - name: PyodidePythonBuild - path: src/api/python/dist/*.whl - retention-days: 7 - windows-build-x64: name: "Windows x64 build" runs-on: windows-latest @@ -752,7 +700,7 @@ jobs: python-package: name: "Python packaging" - needs: [mac-build-x64, mac-build-arm64, windows-build-x64, windows-build-x86, windows-build-arm64, manylinux-python-amd64, manylinux-python-arm64, manylinux-python-riscv64, pyodide-python] + needs: [mac-build-x64, mac-build-arm64, windows-build-x64, windows-build-x86, windows-build-arm64, manylinux-python-amd64, manylinux-python-arm64, manylinux-python-riscv64] runs-on: ubuntu-24.04 steps: - name: Checkout code @@ -811,12 +759,6 @@ jobs: name: ManyLinuxPythonBuildRiscv64 path: artifacts - - name: Download Pyodide Build - uses: actions/download-artifact@v8.0.1 - with: - name: PyodidePythonBuild - path: artifacts - - name: Extract builds run: | cd artifacts