From cc12b1ebce229f1ca21052580d594a8df78a987f Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Mon, 28 Mar 2016 23:10:23 +0100 Subject: [PATCH] [CMake] The bug in mono that causes the ``gacutil`` utility to crash if the assembly was compiled with ``/platform:x64`` has now been reported so update the comments to reflect this. --- contrib/cmake/src/api/dotnet/CMakeLists.txt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/contrib/cmake/src/api/dotnet/CMakeLists.txt b/contrib/cmake/src/api/dotnet/CMakeLists.txt index a087c3a72..f077b57ce 100644 --- a/contrib/cmake/src/api/dotnet/CMakeLists.txt +++ b/contrib/cmake/src/api/dotnet/CMakeLists.txt @@ -188,9 +188,12 @@ list(APPEND CSC_FLAGS "$<$>:/optimize+>" ) -# FIXME: Mono's gacutil crashes if we set the platform. This bug should -# be reported and fixed. However for Mono the platform flag is ignored -# so it shouldn't matter in practice. +# Mono's gacutil crashes when trying to install an assembly if we set the +# platform in some cases, so only set it on Windows. This bug has been +# reported at https://bugzilla.xamarin.com/show_bug.cgi?id=39955 . However mono +# ignores the platform of an assembly when running it ( +# http://lists.ximian.com/pipermail/mono-devel-list/2015-November/043370.html ) +# so this shouldn't matter in practice. if (DOTNET_TOOLCHAIN_IS_WINDOWS) # Set platform for assembly if ("${TARGET_ARCHITECTURE}" STREQUAL "x86_64")