mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-08-03 04:33:28 +00:00
Code Activity

test: replace SASSERT with ENSURE, remove Windows-only guards (#10086)

Browse source 
Unit tests relied on `SASSERT()` which is a no-op in release builds
(`DEBUG_CODE` wrapper), silently skipping all assertions outside debug
mode. Several test files were also gated behind `#ifdef _WINDOWS`,
making them dead code on Linux/macOS CI.

## Changes

- **`SASSERT` → `ENSURE` in 20 test files (200 occurrences)**: `ENSURE`
maps to `VERIFY` and always executes regardless of build type, ensuring
test assertions are active in both debug and release builds.

- **`src/test/diff_logic.cpp`**: Removed `#ifdef _WINDOWS` wrapping the
entire file. No Windows-specific APIs were used; the guard only
prevented compilation on non-Windows platforms.

- **`src/test/dl_product_relation.cpp`**: Removed `#ifdef _WINDOWS`
guard around `tst_dl_product_relation()`. The function body has no
platform dependencies.

- **`src/test/sat_local_search.cpp`**: Replaced `sscanf_s`
(MSVC-specific) with portable `sscanf`; added return-value check to
detect malformed input. Previously, `build_instance()` unconditionally
returned `false` on non-Windows, making the SAT local search test a
no-op on Linux/macOS.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This commit is contained in:
Copilot 2026-07-11 21:14:59 -07:00 • committed by GitHub
parent b0a77d2a58
commit c4b0fe33bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
23 changed files with 205 additions and 219 deletions
Download patch file Download diff file Expand all files Collapse all files

42
src/test/scoped_vector.cpp
View file

@ -7,9 +7,9 @@ void test_push_back_and_access() {
sv.push_back(20);
SASSERT(sv.size() == 2);
SASSERT(sv[0] == 10);
SASSERT(sv[1] == 20);
ENSURE(sv.size() == 2);
ENSURE(sv[0] == 10);
ENSURE(sv[1] == 20);
std::cout << "test_push_back_and_access passed." << std::endl;
}
@ -23,16 +23,16 @@ void test_scopes() {
sv.push_back(30);
sv.push_back(40);
SASSERT(sv.size() == 4);
SASSERT(sv[2] == 30);
SASSERT(sv[3] == 40);
ENSURE(sv.size() == 4);
ENSURE(sv[2] == 30);
ENSURE(sv[3] == 40);
sv.pop_scope(1);
std::cout << "test_scopes passed." << std::endl;
SASSERT(sv.size() == 2);
SASSERT(sv[0] == 10);
SASSERT(sv[1] == 20);
ENSURE(sv.size() == 2);
ENSURE(sv[0] == 10);
ENSURE(sv[1] == 20);
std::cout << "test_scopes passed." << std::endl;
}
@ -45,15 +45,15 @@ void test_set() {
sv.set(0, 30);
sv.set(1, 40);
SASSERT(sv.size() == 2);
SASSERT(sv[0] == 30);
SASSERT(sv[1] == 40);
ENSURE(sv.size() == 2);
ENSURE(sv[0] == 30);
ENSURE(sv[1] == 40);
sv.push_scope();
sv.set(0, 50);
SASSERT(sv[0] == 50);
ENSURE(sv[0] == 50);
sv.pop_scope(1);
SASSERT(sv[0] == 30);
ENSURE(sv[0] == 30);
std::cout << "test_set passed." << std::endl;
}
@ -63,12 +63,12 @@ void test_pop_back() {
sv.push_back(10);
sv.push_back(20);
SASSERT(sv.size() == 2);
ENSURE(sv.size() == 2);
sv.pop_back();
SASSERT(sv.size() == 1);
SASSERT(sv[0] == 10);
ENSURE(sv.size() == 1);
ENSURE(sv[0] == 10);
sv.pop_back();
SASSERT(sv.size() == 0);
ENSURE(sv.size() == 0);
std::cout << "test_pop_back passed." << std::endl;
}
@ -81,9 +81,9 @@ void test_erase_and_swap() {
sv.erase_and_swap(1);
SASSERT(sv.size() == 2);
SASSERT(sv[0] == 10);
SASSERT(sv[1] == 30);
ENSURE(sv.size() == 2);
ENSURE(sv[0] == 10);
ENSURE(sv[1] == 30);
std::cout << "test_erase_and_swap passed." << std::endl;
}