mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-04-24 09:35:32 +00:00
Code Activity

cleanning solver initialization, and fixing named assertion support

Browse source 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
This commit is contained in:
Leonardo de Moura 2012-11-02 16:35:08 -07:00
parent 181bdb6815
commit b70687acc9
13 changed files with 268 additions and 155 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/solver/solver.h
View file

@ -64,19 +64,20 @@ public:
/**
\brief Enable/Disable proof production for this solver object.
It is invoked after init(m, logic).
It is invoked before init(m, logic).
*/
virtual void set_produce_proofs(bool f) {}
/**
\brief Enable/Disable model generation for this solver object.
It is invoked after init(m, logic).
It is invoked before init(m, logic).
The user may optionally invoke it after init(m, logic).
*/
virtual void set_produce_models(bool f) {}
/**
\brief Enable/Disable unsat core generation for this solver object.
It is invoked after init(m, logic).
It is invoked before init(m, logic).
*/
virtual void set_produce_unsat_cores(bool f) {}

236
src/solver/strategic_solver.cpp
View file

@ -25,7 +25,13 @@ Notes:
// minimum verbosity level for portfolio verbose messages
#define PS_VB_LVL 15
strategic_solver_core::strategic_solver_core():
strategic_solver::ctx::ctx(ast_manager & m):
m_assertions(m),
m_assertion_names(m) {
}
strategic_solver::strategic_solver():
m_manager(0),
m_fparams(0),
m_force_tactic(false),
@ -37,6 +43,7 @@ strategic_solver_core::strategic_solver_core():
m_default_fct(0),
m_curr_tactic(0),
m_proof(0),
m_core(0),
m_callback(0) {
m_use_inc_solver_results = false;
DEBUG_CODE(m_num_scopes = 0;);
@ -45,7 +52,7 @@ strategic_solver_core::strategic_solver_core():
m_produce_unsat_cores = false;
}
strategic_solver_core::~strategic_solver_core() {
strategic_solver::~strategic_solver() {
SASSERT(!m_curr_tactic);
dictionary<tactic_factory*>::iterator it = m_logic2fct.begin();
dictionary<tactic_factory*>::iterator end = m_logic2fct.end();
@ -54,9 +61,11 @@ strategic_solver_core::~strategic_solver_core() {
}
if (m_proof)
m().dec_ref(m_proof);
if (m_core)
m().dec_ref(m_core);
}
bool strategic_solver_core::has_quantifiers() const {
bool strategic_solver::has_quantifiers() const {
unsigned sz = get_num_assertions();
for (unsigned i = 0; i < sz; i++) {
if (::has_quantifiers(get_assertion(i)))
@ -68,7 +77,7 @@ bool strategic_solver_core::has_quantifiers() const {
/**
\brief Return true if a tactic should be used when the incremental solver returns unknown.
*/
bool strategic_solver_core::use_tactic_when_undef() const {
bool strategic_solver::use_tactic_when_undef() const {
switch (m_inc_unknown_behavior) {
case IUB_RETURN_UNDEF: return false;
case IUB_USE_TACTIC_IF_QF: return !has_quantifiers();
@ -79,7 +88,7 @@ bool strategic_solver_core::use_tactic_when_undef() const {
}
}
void strategic_solver_core::set_inc_solver(solver * s) {
void strategic_solver::set_inc_solver(solver * s) {
SASSERT(m_inc_solver == 0);
SASSERT(m_num_scopes == 0);
m_inc_solver = s;
@ -87,7 +96,7 @@ void strategic_solver_core::set_inc_solver(solver * s) {
m_inc_solver->set_progress_callback(m_callback);
}
void strategic_solver_core::updt_params(params_ref const & p) {
void strategic_solver::updt_params(params_ref const & p) {
if (m_inc_solver)
m_inc_solver->updt_params(p);
if (m_fparams)
@ -95,7 +104,7 @@ void strategic_solver_core::updt_params(params_ref const & p) {
}
void strategic_solver_core::collect_param_descrs(param_descrs & r) {
void strategic_solver::collect_param_descrs(param_descrs & r) {
if (m_inc_solver)
m_inc_solver->collect_param_descrs(r);
}
@ -105,7 +114,7 @@ void strategic_solver_core::collect_param_descrs(param_descrs & r) {
timeout == UINT_MAX means infinite
After the timeout a strategy is used.
*/
void strategic_solver_core::set_inc_solver_timeout(unsigned timeout) {
void strategic_solver::set_inc_solver_timeout(unsigned timeout) {
m_inc_solver_timeout = timeout;
}
@ -113,14 +122,14 @@ void strategic_solver_core::set_inc_solver_timeout(unsigned timeout) {
\brief Set the default tactic factory.
It is used if there is no tactic for a given logic.
*/
void strategic_solver_core::set_default_tactic(tactic_factory * fct) {
void strategic_solver::set_default_tactic(tactic_factory * fct) {
m_default_fct = fct;
}
/**
\brief Set a tactic factory for a given logic.
*/
void strategic_solver_core::set_tactic_for(symbol const & logic, tactic_factory * fct) {
void strategic_solver::set_tactic_for(symbol const & logic, tactic_factory * fct) {
tactic_factory * old_fct;
if (m_logic2fct.find(logic, old_fct)) {
dealloc(old_fct);
@ -128,31 +137,77 @@ void strategic_solver_core::set_tactic_for(symbol const & logic, tactic_factory
m_logic2fct.insert(logic, fct);
}
void strategic_solver_core::init_core(ast_manager & m, symbol const & logic) {
void strategic_solver::init(ast_manager & m, symbol const & logic) {
m_manager = &m;
m_logic = logic;
if (m_inc_mode) {
SASSERT(m_inc_solver);
m_inc_solver->init(m, logic);
}
m_ctx = alloc(ctx, m);
TRACE("strategic_solver", tout << "strategic_solver was initialized.\n";);
}
unsigned strategic_solver::get_num_assertions() const {
if (m_ctx == 0)
return 0;
return m_ctx->m_assertions.size();
}
expr * strategic_solver::get_assertion(unsigned idx) const {
SASSERT(m_ctx);
return m_ctx->m_assertions.get(idx);
}
expr * strategic_solver::get_assertion_name(unsigned idx) const {
SASSERT(m_ctx);
SASSERT(m_produce_unsat_cores);
return m_ctx->m_assertion_names.get(idx);
}
void strategic_solver::set_produce_proofs(bool f) {
m_produce_proofs = f;
// do not need to propagate to inc_solver since flag cannot be changed after initialization
}
void strategic_solver::set_produce_models(bool f) {
m_produce_models = f;
if (m_inc_solver)
m_inc_solver->set_produce_models(f);
}
void strategic_solver::set_produce_unsat_cores(bool f) {
m_produce_unsat_cores = f;
// do not need to propagate to inc_solver since flag cannot be changed after initialization
}
// delayed inc solver initialization
void strategic_solver_core::init_inc_solver() {
void strategic_solver::init_inc_solver() {
if (m_inc_mode)
return; // solver was already initialized
if (!m_inc_solver)
return; // inc solver was not installed
m_inc_mode = true;
m_inc_solver->set_produce_proofs(m_produce_proofs);
m_inc_solver->set_produce_models(m_produce_models);
m_inc_solver->set_produce_unsat_cores(m_produce_unsat_cores);
m_inc_solver->set_front_end_params(*m_fparams);
m_inc_solver->init(m(), m_logic);
unsigned sz = get_num_assertions();
for (unsigned i = 0; i < sz; i++) {
m_inc_solver->assert_expr(get_assertion(i));
if (m_produce_unsat_cores) {
SASSERT(m_ctx->m_assertions.size() == m_ctx->m_assertion_names.size());
for (unsigned i = 0; i < sz; i++) {
m_inc_solver->assert_expr(get_assertion(i), get_assertion_name(i));
}
}
else {
for (unsigned i = 0; i < sz; i++) {
m_inc_solver->assert_expr(get_assertion(i));
}
}
}
void strategic_solver_core::collect_statistics(statistics & st) const {
void strategic_solver::collect_statistics(statistics & st) const {
if (m_use_inc_solver_results) {
SASSERT(m_inc_solver);
m_inc_solver->collect_statistics(st);
@ -165,7 +220,8 @@ void strategic_solver_core::collect_statistics(statistics & st) const {
}
}
void strategic_solver_core::reset_core() {
void strategic_solver::reset() {
m_ctx = 0;
m_logic = symbol::null;
m_inc_mode = false;
m_check_sat_executed = false;
@ -176,18 +232,22 @@ void strategic_solver_core::reset_core() {
reset_results();
}
void strategic_solver_core::reset_results() {
void strategic_solver::reset_results() {
m_use_inc_solver_results = false;
m_model = 0;
if (m_proof) {
m().dec_ref(m_proof);
m_proof = 0;
}
if (m_core) {
m().dec_ref(m_core);
m_core = 0;
}
m_reason_unknown.clear();
m_stats.reset();
}
void strategic_solver_core::assert_expr(expr * t) {
void strategic_solver::assert_expr(expr * t) {
if (m_check_sat_executed && !m_inc_mode) {
// a check sat was already executed --> switch to incremental mode
init_inc_solver();
@ -197,16 +257,37 @@ void strategic_solver_core::assert_expr(expr * t) {
SASSERT(m_inc_solver);
m_inc_solver->assert_expr(t);
}
SASSERT(m_ctx);
m_ctx->m_assertions.push_back(t);
if (m_produce_unsat_cores)
m_ctx->m_assertion_names.push_back(0);
}
void strategic_solver_core::push_core() {
void strategic_solver::assert_expr(expr * t, expr * a) {
if (m_check_sat_executed && !m_inc_mode) {
// a check sat was already executed --> switch to incremental mode
init_inc_solver();
SASSERT(m_inc_solver == 0 || m_inc_mode);
}
if (m_inc_mode) {
SASSERT(m_inc_solver);
m_inc_solver->assert_expr(t, a);
}
SASSERT(m_ctx);
m_ctx->m_assertions.push_back(t);
if (m_produce_unsat_cores)
m_ctx->m_assertion_names.push_back(a);
}
void strategic_solver::push() {
DEBUG_CODE(m_num_scopes++;);
init_inc_solver();
if (m_inc_solver)
m_inc_solver->push();
m_ctx->m_scopes.push_back(m_ctx->m_assertions.size());
}
void strategic_solver_core::pop_core(unsigned n) {
void strategic_solver::pop(unsigned n) {
DEBUG_CODE({
SASSERT(n <= m_num_scopes);
m_num_scopes -= n;
@ -214,6 +295,20 @@ void strategic_solver_core::pop_core(unsigned n) {
init_inc_solver();
if (m_inc_solver)
m_inc_solver->pop(n);
SASSERT(m_ctx);
unsigned new_lvl = m_ctx->m_scopes.size() - n;
unsigned old_sz = m_ctx->m_scopes[new_lvl];
m_ctx->m_assertions.shrink(old_sz);
if (m_produce_unsat_cores)
m_ctx->m_assertion_names.shrink(old_sz);
m_ctx->m_scopes.shrink(new_lvl);
}
unsigned strategic_solver::get_scope_level() const {
if (m_ctx == 0)
return 0;
return m_ctx->m_assertions.size();
}
struct aux_timeout_eh : public event_handler {
@ -226,10 +321,10 @@ struct aux_timeout_eh : public event_handler {
}
};
struct strategic_solver_core::mk_tactic {
strategic_solver_core * m_solver;
struct strategic_solver::mk_tactic {
strategic_solver * m_solver;
mk_tactic(strategic_solver_core * s, tactic_factory * f):m_solver(s) {
mk_tactic(strategic_solver * s, tactic_factory * f):m_solver(s) {
ast_manager & m = s->m();
params_ref p;
front_end_params2params(*s->m_fparams, p);
@ -252,14 +347,14 @@ struct strategic_solver_core::mk_tactic {
}
};
tactic_factory * strategic_solver_core::get_tactic_factory() const {
tactic_factory * strategic_solver::get_tactic_factory() const {
tactic_factory * f = 0;
if (m_logic2fct.find(m_logic, f))
return f;
return m_default_fct.get();
}
lbool strategic_solver_core::check_sat_with_assumptions(unsigned num_assumptions, expr * const * assumptions) {
lbool strategic_solver::check_sat_with_assumptions(unsigned num_assumptions, expr * const * assumptions) {
if (!m_inc_solver) {
IF_VERBOSE(PS_VB_LVL, verbose_stream() << "incremental solver was not installed, returning unknown...\n";);
m_use_inc_solver_results = false;
@ -268,15 +363,16 @@ lbool strategic_solver_core::check_sat_with_assumptions(unsigned num_assumptions
}
init_inc_solver();
m_use_inc_solver_results = true;
TRACE("solver_na2as", tout << "invoking inc_solver with " << num_assumptions << " assumptions\n";);
TRACE("strategic_solver", tout << "invoking inc_solver with " << num_assumptions << " assumptions\n";);
return m_inc_solver->check_sat(num_assumptions, assumptions);
}
lbool strategic_solver_core::check_sat_core(unsigned num_assumptions, expr * const * assumptions) {
TRACE("solver_na2as", tout << "assumptions at strategic_solver_core:\n";
lbool strategic_solver::check_sat(unsigned num_assumptions, expr * const * assumptions) {
TRACE("strategic_solver", tout << "assumptions at strategic_solver:\n";
for (unsigned i = 0; i < num_assumptions; i++) {
tout << mk_ismt2_pp(assumptions[i], m()) << "\n";
});
}
tout << "m_produce_unsat_cores: " << m_produce_unsat_cores << ", m_inc_mode: " << m_inc_mode << "\n";);
reset_results();
m_check_sat_executed = true;
if (num_assumptions > 0 || // assumptions were provided
@ -331,10 +427,18 @@ lbool strategic_solver_core::check_sat_core(unsigned num_assumptions, expr * con
goal_ref g = alloc(goal, m(), m_produce_proofs, m_produce_models, m_produce_unsat_cores);
unsigned sz = get_num_assertions();
for (unsigned i = 0; i < sz; i++) {
g->assert_expr(get_assertion(i));
if (m_produce_unsat_cores) {
SASSERT(m_ctx->m_assertions.size() == m_ctx->m_assertion_names.size());
for (unsigned i = 0; i < sz; i++)
g->assert_expr(get_assertion(i), get_assertion_name(i));
}
else {
for (unsigned i = 0; i < sz; i++)
g->assert_expr(get_assertion(i));
}
expr_dependency_ref core(m());
TRACE("strategic_solver", tout << "using goal...\n"; g->display_with_dependencies(tout););
mk_tactic tct_maker(this, factory);
SASSERT(m_curr_tactic);
@ -346,10 +450,14 @@ lbool strategic_solver_core::check_sat_core(unsigned num_assumptions, expr * con
m_proof = pr;
m().inc_ref(m_proof);
}
if (core) {
m_core = core;
m().inc_ref(m_core);
}
return r;
}
void strategic_solver_core::set_cancel(bool f) {
void strategic_solver::set_cancel(bool f) {
if (m_inc_solver)
m_inc_solver->set_cancel(f);
#pragma omp critical (strategic_solver)
@ -359,15 +467,18 @@ void strategic_solver_core::set_cancel(bool f) {
}
}
void strategic_solver_core::get_unsat_core(ptr_vector<expr> & r) {
TRACE("solver_na2as", tout << "get_unsat_core, m_use_inc_solver_results: " << m_use_inc_solver_results << "\n";);
void strategic_solver::get_unsat_core(ptr_vector<expr> & r) {
TRACE("strategic_solver", tout << "get_unsat_core, m_use_inc_solver_results: " << m_use_inc_solver_results << "\n";);
if (m_use_inc_solver_results) {
SASSERT(m_inc_solver);
m_inc_solver->get_unsat_core(r);
}
else {
m().linearize(m_core, r);
}
}
void strategic_solver_core::get_model(model_ref & m) {
void strategic_solver::get_model(model_ref & m) {
if (m_use_inc_solver_results) {
SASSERT(m_inc_solver);
m_inc_solver->get_model(m);
@ -377,7 +488,7 @@ void strategic_solver_core::get_model(model_ref & m) {
}
}
proof * strategic_solver_core::get_proof() {
proof * strategic_solver::get_proof() {
if (m_use_inc_solver_results) {
SASSERT(m_inc_solver);
return m_inc_solver->get_proof();
@ -387,7 +498,7 @@ proof * strategic_solver_core::get_proof() {
}
}
std::string strategic_solver_core::reason_unknown() const {
std::string strategic_solver::reason_unknown() const {
if (m_use_inc_solver_results) {
SASSERT(m_inc_solver);
return m_inc_solver->reason_unknown();
@ -395,20 +506,20 @@ std::string strategic_solver_core::reason_unknown() const {
return m_reason_unknown;
}
void strategic_solver_core::get_labels(svector<symbol> & r) {
void strategic_solver::get_labels(svector<symbol> & r) {
if (m_use_inc_solver_results) {
SASSERT(m_inc_solver);
m_inc_solver->get_labels(r);
}
}
void strategic_solver_core::set_progress_callback(progress_callback * callback) {
void strategic_solver::set_progress_callback(progress_callback * callback) {
m_callback = callback;
if (m_inc_solver)
m_inc_solver->set_progress_callback(callback);
}
void strategic_solver_core::display(std::ostream & out) const {
void strategic_solver::display(std::ostream & out) const {
if (m_manager) {
unsigned num = get_num_assertions();
out << "(solver";
@ -423,50 +534,7 @@ void strategic_solver_core::display(std::ostream & out) const {
}
strategic_solver::ctx::ctx(ast_manager & m):m_assertions(m) {
}
void strategic_solver::init_core(ast_manager & m, symbol const & logic) {
strategic_solver_core::init_core(m, logic);
m_ctx = alloc(ctx, m);
}
unsigned strategic_solver::get_num_assertions() const {
if (m_ctx == 0)
return 0;
return m_ctx->m_assertions.size();
}
expr * strategic_solver::get_assertion(unsigned idx) const {
SASSERT(m_ctx);
return m_ctx->m_assertions.get(idx);
}
void strategic_solver::assert_expr(expr * t) {
SASSERT(m_ctx);
strategic_solver_core::assert_expr(t);
m_ctx->m_assertions.push_back(t);
}
void strategic_solver::push_core() {
SASSERT(m_ctx);
strategic_solver_core::push_core();
m_ctx->m_scopes.push_back(m_ctx->m_assertions.size());
}
void strategic_solver::pop_core(unsigned n) {
SASSERT(m_ctx);
unsigned new_lvl = m_ctx->m_scopes.size() - n;
unsigned old_sz = m_ctx->m_scopes[new_lvl];
m_ctx->m_assertions.shrink(old_sz);
m_ctx->m_scopes.shrink(new_lvl);
strategic_solver_core::pop_core(n);
}
void strategic_solver::reset_core() {
m_ctx = 0;
strategic_solver_core::reset_core();
}

68
src/solver/strategic_solver.h
View file

@ -19,7 +19,7 @@ Notes:
#ifndef _STRATEGIC_SOLVER_H_
#define _STRATEGIC_SOLVER_H_
#include"solver_na2as.h"
#include"solver.h"
#include"tactic.h"
class progress_callback;
@ -46,7 +46,7 @@ struct front_end_params;
It goes back to non_incremental mode when:
- reset is invoked.
*/
class strategic_solver_core : public solver_na2as {
class strategic_solver : public solver {
public:
// Behavior when the incremental solver returns unknown.
enum inc_unknown_behavior {
@ -73,9 +73,18 @@ private:
bool m_use_inc_solver_results;
model_ref m_model;
proof * m_proof;
expr_dependency * m_core;
std::string m_reason_unknown;
statistics m_stats;
struct ctx {
expr_ref_vector m_assertions;
expr_ref_vector m_assertion_names;
unsigned_vector m_scopes;
ctx(ast_manager & m);
};
scoped_ptr<ctx> m_ctx;
#ifdef Z3DEBUG
unsigned m_num_scopes;
#endif
@ -97,8 +106,8 @@ private:
bool use_tactic_when_undef() const;
public:
strategic_solver_core();
~strategic_solver_core();
strategic_solver();
~strategic_solver();
ast_manager & m() const { SASSERT(m_manager); return *m_manager; }
@ -114,22 +123,25 @@ public:
virtual void updt_params(params_ref const & p);
virtual void collect_param_descrs(param_descrs & r);
virtual void set_produce_proofs(bool f) { m_produce_proofs = f; }
virtual void set_produce_models(bool f) { m_produce_models = f; }
virtual void set_produce_unsat_cores(bool f) { m_produce_unsat_cores = f; }
virtual void set_produce_proofs(bool f);
virtual void set_produce_models(bool f);
virtual void set_produce_unsat_cores(bool f);
unsigned get_num_assertions() const;
expr * get_assertion(unsigned idx) const;
expr * get_assertion_name(unsigned idx) const;
virtual unsigned get_num_assertions() const = 0;
virtual expr * get_assertion(unsigned idx) const = 0;
virtual void display(std::ostream & out) const;
virtual void init_core(ast_manager & m, symbol const & logic);
virtual void init(ast_manager & m, symbol const & logic);
virtual void collect_statistics(statistics & st) const;
virtual void reset_core();
virtual void reset();
virtual void assert_expr(expr * t);
virtual void push_core();
virtual void pop_core(unsigned n);
virtual lbool check_sat_core(unsigned num_assumptions, expr * const * assumptions);
virtual void assert_expr(expr * t, expr * a);
virtual void push();
virtual void pop(unsigned n);
virtual unsigned get_scope_level() const;
virtual lbool check_sat(unsigned num_assumptions, expr * const * assumptions);
virtual void get_unsat_core(ptr_vector<expr> & r);
virtual void get_model(model_ref & m);
virtual proof * get_proof();
@ -139,30 +151,4 @@ public:
virtual void set_progress_callback(progress_callback * callback);
};
/**
\brief Default implementation of strategic_solver_core
*/
class strategic_solver : public strategic_solver_core {
struct ctx {
expr_ref_vector m_assertions;
unsigned_vector m_scopes;
ctx(ast_manager & m);
};
scoped_ptr<ctx> m_ctx;
public:
strategic_solver() {}
virtual void init_core(ast_manager & m, symbol const & logic);
virtual void assert_expr(expr * t);
virtual void push_core();
virtual void pop_core(unsigned n);
virtual void reset_core();
virtual unsigned get_num_assertions() const;
virtual expr * get_assertion(unsigned idx) const;
};
#endif