mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-05-30 21:57:46 +00:00
Code Activity

add review

Browse source 
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
This commit is contained in:
Nikolaj Bjorner 2026-03-21 10:14:34 -07:00
parent a39ff701c7
commit aa210882c5
1 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/smt/seq/seq_nielsen.cpp
View file

@ -17,6 +17,12 @@ Author:
Clemens Eisenhofer 2026-03-02 Clemens Eisenhofer 2026-03-02
Nikolaj Bjorner (nbjorner) 2026-03-02 Nikolaj Bjorner (nbjorner) 2026-03-02
NSB review:
ostrich\substring2b.smt2, ostrich\substring.smt2
- We are missing rewrites for unit(x) = unit('a') that would eliminate x by a.
--*/ --*/
#include "smt/seq/seq_nielsen.h" #include "smt/seq/seq_nielsen.h"
@ -2524,22 +2530,24 @@ namespace seq {
bool nielsen_graph::apply_det_modifier(nielsen_node* node) { bool nielsen_graph::apply_det_modifier(nielsen_node* node) {
for (str_eq const& eq : node->str_eqs()) { for (str_eq const& eq : node->str_eqs()) {
SASSERT(!eq.is_trivial()); // We should have simplified it away before SASSERT(!eq.is_trivial()); // We should have simplified it away before
if (!eq.m_lhs || !eq.m_rhs) auto l = eq.m_lhs, r = eq.m_rhs;
if (!l || !r)
continue; continue;
// variable definition: x = t where x is a single var and x ∉ vars(t) // variable definition: x = t where x is a single var and x ∉ vars(t)
// → deterministically substitute x → t throughout the node // → deterministically substitute x → t throughout the node
euf::snode* var = nullptr; euf::snode* var = nullptr;
euf::snode* def; euf::snode* def;
if (eq.m_lhs->is_var() && !snode_contains_var(eq.m_rhs, eq.m_lhs)) { if (l->is_var() && !snode_contains_var(r, l)) {
var = eq.m_lhs; var = l;
def = eq.m_rhs; def = r;
} }
else if (eq.m_rhs->is_var() && !snode_contains_var(eq.m_lhs, eq.m_rhs)) { else if (r->is_var() && !snode_contains_var(l, r)) {
var = eq.m_rhs; var = r;
def = eq.m_lhs; def = l;
} }
if (var) { if (var) {
nielsen_node* child = mk_child(node); nielsen_node* child = mk_child(node);
nielsen_edge* e = mk_edge(node, child, true); nielsen_edge* e = mk_edge(node, child, true);