From 9a09b10ceab184ef755201575176908182a2e4cf Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Tue, 16 Dec 2025 23:14:55 +0000 Subject: [PATCH] Fix docs.yml workflow: remove conflicting native build step (#8091) * Initial plan * Fix docs.yml workflow to properly build and deploy documentation - Remove `no-install: true` from setup-emsdk step to properly install emscripten - Remove `working-directory: src/api/js` from setup-emsdk step (not needed) - Remove manual emsdk install/activate/source commands from Build wasm step - Remove redundant native Z3 build step that conflicted with wasm build - Simplify Generate Documentation step by removing redundant source command The main issue was that the native Z3 build was creating a Makefile in the build/ directory before the wasm build ran. The wasm build script then saw the Makefile existed and skipped the emconfigure step, but the native Makefile doesn't have a libz3.a target, causing the build to fail. Removing the native build allows the wasm build to properly configure its own build with emscripten. Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com> --- .github/workflows/docs.yml | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 5d66c81c9..0d010e6a6 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -37,9 +37,7 @@ jobs: - name: Setup emscripten uses: mymindstorm/setup-emsdk@v14 - working-directory: src/api/js with: - no-install: true version: ${{env.EM_VERSION}} actions-cache-folder: "emsdk-cache" @@ -53,25 +51,11 @@ jobs: - name: Build wasm working-directory: src/api/js - run: | - emsdk install ${EM_VERSION} - emsdk activate ${EM_VERSION} - source $(dirname $(which emsdk))/emsdk_env.sh - which node - which clang++ - npm run build:wasm - - - name: Build Z3 for ubuntu-latest x64 - run: | - python3 scripts/mk_make.py - cd build - make -j$(nproc) + run: npm run build:wasm - name: Generate Documentation (from doc directory) working-directory: doc - run: | - source $(dirname $(which emsdk))/emsdk_env.sh - python3 mk_api_doc.py --js --output-dir=api + run: python3 mk_api_doc.py --js --output-dir=api - name: Setup Pages uses: actions/configure-pages@v5