diff --git a/src/util/mpz.h b/src/util/mpz.h index 555b5e1de..51f1e0d68 100644 --- a/src/util/mpz.h +++ b/src/util/mpz.h @@ -99,8 +99,9 @@ private: static constexpr int SMALL_BITS = sizeof(uintptr_t) * 8 - 1; // Maximum and minimum values that can be stored as small integers - static constexpr int64_t SMALL_INT_MAX = (static_cast(1) << (SMALL_BITS - 1)) - 1; - static constexpr int64_t SMALL_INT_MIN = -(static_cast(1) << (SMALL_BITS - 1)); + // Use unsigned arithmetic to avoid undefined behavior on left shift + static constexpr int64_t SMALL_INT_MAX = (static_cast(1) << (SMALL_BITS - 1)) - 1; + static constexpr int64_t SMALL_INT_MIN = -(static_cast(static_cast(1) << (SMALL_BITS - 1))); static bool fits_in_small(int64_t v) { return v >= SMALL_INT_MIN && v <= SMALL_INT_MAX;