mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-06-06 06:03:23 +00:00
Code Activity

fix #4744

Browse source
This commit is contained in:
Nikolaj Bjorner 2020-10-29 15:09:13 -07:00
parent 9026ff28bc
commit 91511f73a0
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/math/lp/nla_basics_lemmas.cpp
View file

@ -586,11 +586,11 @@ bool basics::can_create_lemma_for_mon_neutral_from_factors_to_monic_model_based(
for (auto j : f) { for (auto j : f) {
TRACE("nla_solver_bl", tout << "j = "; c().print_factor_with_vars(j, tout);); TRACE("nla_solver_bl", tout << "j = "; c().print_factor_with_vars(j, tout););
auto v = val(j); auto v = val(j);
if (v == rational(1)) {
continue;
}
if (v == -rational(1)) { if (v.is_one())
continue;
if (v.is_minus_one()) {
sign = -sign; sign = -sign;
continue; continue;
} }
@ -627,11 +627,18 @@ bool basics::can_create_lemma_for_mon_neutral_from_factors_to_monic_model_based(
or or
/\ f_j = val(f_j) => m = sign if all factors evaluate to +/- 1 /\ f_j = val(f_j) => m = sign if all factors evaluate to +/- 1
Note:
The routine can_create_lemma_for_mon_neutral_from_factors_to_monic_model_based does
not check the signs of factors. Factors have signs. It works assuming all factors have
positive signs.
*/ */
bool basics::basic_lemma_for_mon_neutral_from_factors_to_monic_model_based(const monic& m, const factorization& f) { bool basics::basic_lemma_for_mon_neutral_from_factors_to_monic_model_based(const monic& m, const factorization& f) {
lpvar not_one; rational sign; lpvar not_one; rational sign;
if (!can_create_lemma_for_mon_neutral_from_factors_to_monic_model_based(m, f, not_one, sign)) if (!can_create_lemma_for_mon_neutral_from_factors_to_monic_model_based(m, f, not_one, sign))
return false; return false;
for (auto j : f)
if (j.sign())
return false;
TRACE("nla_solver_bl", tout << "not_one = " << not_one << "\n";); TRACE("nla_solver_bl", tout << "not_one = " << not_one << "\n";);
new_lemma lemma(c(), __FUNCTION__); new_lemma lemma(c(), __FUNCTION__);