diff --git a/src/math/polysat/solver.cpp b/src/math/polysat/solver.cpp index d4ef01329..281492a62 100644 --- a/src/math/polysat/solver.cpp +++ b/src/math/polysat/solver.cpp @@ -82,7 +82,7 @@ namespace polysat { pvar v = m_value.size(); m_value.push_back(rational::zero()); m_justification.push_back(justification::unassigned()); - m_viable.push(); + m_viable.push(sz); m_cjust.push_back(constraints()); m_watch.push_back(ptr_vector()); m_activity.push_back(0); diff --git a/src/math/polysat/viable.cpp b/src/math/polysat/viable.cpp index 0f1954fc0..ef691d841 100644 --- a/src/math/polysat/viable.cpp +++ b/src/math/polysat/viable.cpp @@ -1,7 +1,21 @@ +/*++ +Copyright (c) 2021 Microsoft Corporation + +Module Name: + + maintain viable domains + +Author: + + Nikolaj Bjorner (nbjorner) 2021-03-19 + Jakob Rath 2021-04-6 + +--*/ #include "math/polysat/viable.h" #include "math/polysat/solver.h" + namespace polysat { viable::viable(solver& s): @@ -10,19 +24,35 @@ namespace polysat { {} void viable::push_viable(pvar v) { +#if NEW_VIABLE + +#else s.m_trail.push_back(trail_instr_t::viable_i); m_viable_trail.push_back(std::make_pair(v, m_viable_bdd[v])); +#endif } void viable::pop_viable() { +#if NEW_VIABLE + +#else auto p = m_viable_trail.back(); LOG_V("Undo viable_i"); m_viable_bdd[p.first] = p.second; m_viable_trail.pop_back(); +#endif } // a*v + b == 0 or a*v + b != 0 void viable::intersect_eq(rational const& a, pvar v, rational const& b, bool is_positive) { + +#if NEW_VIABLE + save_viable(v); + m_viable[v].intersect_eq(a, b, is_positive); + if (m_viable[v].is_empty()) + set_conflict(v); +#else + bddv const& x = var2bits(v).var(); if (b == 0 && a.is_odd()) { // hacky test optimizing special case. @@ -44,9 +74,16 @@ namespace polysat { bdd xs = is_positive ? lhs.all0() : !lhs.all0(); intersect_viable(v, xs); } +#endif } void viable::intersect_ule(pvar v, rational const& a, rational const& b, rational const& c, rational const& d, bool is_positive) { +#if NEW_VIABLE + save_viable(v); + m_viable[v].intersect_ule(a, b, c, d, is_positive); + if (m_viable[v].is_empty()) + set_conflict(v); +#else bddv const& x = var2bits(v).var(); // hacky special case if (a == 1 && b == 0 && c == 0 && d == 0) @@ -59,21 +96,37 @@ namespace polysat { bdd xs = is_positive ? (l <= r) : (l > r); intersect_viable(v, xs); } +#endif } bool viable::has_viable(pvar v) { +#if NEW_VIABLE + return !m_viable[v].is_empty(); +#else return !m_viable_bdd[v].is_false(); +#endif } bool viable::is_viable(pvar v, rational const& val) { +#if NEW_VIABLE + return m_viable[v].contains(val); +#else return var2bits(v).contains(m_viable_bdd[v], val); +#endif } void viable::add_non_viable(pvar v, rational const& val) { +#if NEW_VIABLE + save_viable(v); + m_viable[v].set_ne(val); + if (m_viable[v].is_empty()) + set_conflict(); +#else LOG("pvar " << v << " /= " << val); SASSERT(is_viable(v, val)); auto const& bits = var2bits(v); intersect_viable(v, bits.var() != val); +#endif } void viable::intersect_viable(pvar v, bdd vals) { @@ -84,7 +137,11 @@ namespace polysat { } dd::find_t viable::find_viable(pvar v, rational & val) { +#if NEW_VIABLE + return m_viable[v].find_hint(s.m_value[v], val); +#else return var2bits(v).find_hint(m_viable_bdd[v], s.m_value[v], val); +#endif } dd::fdd const& viable::sz2bits(unsigned sz) { diff --git a/src/math/polysat/viable.h b/src/math/polysat/viable.h index f8a51f470..158691dd5 100644 --- a/src/math/polysat/viable.h +++ b/src/math/polysat/viable.h @@ -20,6 +20,8 @@ Author: #include "math/interval/mod_interval.h" #include "math/polysat/types.h" +#define NEW_VIABLE 0 + namespace polysat { class solver; @@ -32,15 +34,18 @@ namespace polysat { class viable_set : public mod_interval { unsigned m_num_bits; tbv* m_tbv = nullptr; - public: - viable_set(unsigned num_bits): m_num_bits(num_bits) {} - bool is_singleton(rational& val) const; // all bits in tbv are fixed and !is_empty() for mod_interval void set_lo(rational const& lo); void set_hi(rational const& hi); void set_eq(rational const& val); void seq_ne(rational const& val); void set_ule(rational const& a, rational const& b, rational const& c, rational const& d); void set_ugt(rational const& a, rational const& b, rational const& c, rational const& d); + + public: + viable_set(unsigned num_bits): m_num_bits(num_bits) {} + bool is_singleton(rational& val) const; // all bits in tbv are fixed and !is_empty() for mod_interval + void intersect_eq(rational const& a, rational const& b, bool is_positive) {} + void intersect_ule(rational const& a, rational const& b, rational const& c, rational const& d, bool is_positive) {} }; class viable { @@ -66,8 +71,15 @@ namespace polysat { public: viable(solver& s); - void push() { m_viable_bdd.push_back(m_bdd.mk_true()); } - void pop() { m_viable_bdd.pop_back(); } + void push(unsigned num_bits) { + m_viable_bdd.push_back(m_bdd.mk_true()); + m_viable.push_back(viable_set(num_bits)); + } + + void pop() { + m_viable_bdd.pop_back(); + m_viable.pop_back(); + } void push_viable(pvar v); @@ -87,7 +99,7 @@ namespace polysat { */ bool has_viable(pvar v); - bool is_false(pvar v) { return m_viable_bdd[v].is_false(); } + bool is_false(pvar v) { return !has_viable(v); } /** * check if value is viable according to m_viable.