mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-02-18 14:44:21 +00:00
Code Activity

Fix implicit conversion warnings: use UINT_MAX instead of -1 for unsi… (#8342)

Browse source 
* Fix implicit conversion warnings: use UINT_MAX instead of -1 for unsigned variables

Replace implicit conversion from negative literal to unsigned type
with explicit UINT_MAX constant to eliminate compiler warnings.

Fixed 10 instances across 6 files:
- src/ast/rewriter/bv_rewriter.cpp: 1 instance
- src/ast/sls/sls_bv_tracker.h: 2 instances
- src/math/lp/dioph_eq.cpp: 3 instances
- src/math/lp/lp_primal_core_solver.h: 2 instances
- src/muz/transforms/dl_mk_array_instantiation.cpp: 1 instance
- src/muz/transforms/dl_mk_synchronize.cpp: 1 instance

These changes preserve the exact same runtime behavior (UINT_MAX
equals the wrapped value of -1 for unsigned types) while making
the code more explicit and warning-free.

* Update bv_rewriter.cpp

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Nikolaj Bjorner 2026-01-25 22:35:43 -08:00 • committed by GitHub
parent 023377f3c8
commit 8a0207700c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ast/sls/sls_bv_tracker.h
View file

@ -1037,7 +1037,7 @@ public:
}
m_temp_constants.reset();
unsigned pos = -1;
unsigned pos = UINT_MAX;
if (m_ucb)
{
double max = -1.0;
@ -1090,7 +1090,7 @@ public:
return nullptr;
m_temp_constants.reset();
unsigned cnt_unsat = 0, pos = -1;
unsigned cnt_unsat = 0, pos = UINT_MAX;
for (unsigned i = 0; i < sz; ++i)
if ((i != m_last_pos) && m_mpz_manager.neq(get_value(as[i]), m_one) && (get_random_uint(16) % ++cnt_unsat == 0)) pos = i;