From 893265ce945b0a5c5f318498659ad055f3a1715d Mon Sep 17 00:00:00 2001
From: Nikolaj Bjorner <nbjorner@microsoft.com>
Date: Thu, 30 Apr 2020 14:47:15 -0700
Subject: [PATCH] fix #4166

---
 src/smt/smt_setup.cpp       |  2 +-
 src/smt/theory_datatype.cpp | 15 +++++++++------
 src/smt/theory_datatype.h   |  5 ++---
 3 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/smt/smt_setup.cpp b/src/smt/smt_setup.cpp
index 1e16b9e12..7b760d635 100644
--- a/src/smt/smt_setup.cpp
+++ b/src/smt/smt_setup.cpp
@@ -877,7 +877,7 @@ namespace smt {
 
     void setup::setup_datatypes() {
         TRACE("datatype", tout << "registering theory datatype...\n";);
-        m_context.register_plugin(alloc(theory_datatype, m_manager, m_params));
+        m_context.register_plugin(alloc(theory_datatype, m_manager));
     }
 
     void setup::setup_recfuns() {
diff --git a/src/smt/theory_datatype.cpp b/src/smt/theory_datatype.cpp
index ab5d1923c..f427396ef 100644
--- a/src/smt/theory_datatype.cpp
+++ b/src/smt/theory_datatype.cpp
@@ -75,7 +75,7 @@ namespace smt {
 
 
     theory* theory_datatype::mk_fresh(context* new_ctx) { 
-        return alloc(theory_datatype, new_ctx->get_manager(), m_params); 
+        return alloc(theory_datatype, new_ctx->get_manager());
     }
 
     /**
@@ -286,7 +286,7 @@ namespace smt {
                 assert_is_constructor_axiom(n, c, null_literal);
             }
             else {
-                if (m_params.m_dt_lazy_splits == 0 || (m_params.m_dt_lazy_splits == 1 && !s->is_infinite()))
+                if (params().m_dt_lazy_splits == 0 || (params().m_dt_lazy_splits == 1 && !s->is_infinite()))
                     mk_split(r);
             }
         }
@@ -487,7 +487,7 @@ namespace smt {
                     // return...
                     return FC_CONTINUE;
                 }
-                if (m_params.m_dt_lazy_splits > 0) {
+                if (params().m_dt_lazy_splits > 0) {
                     // using lazy case splits...
                     var_data * d = m_var_data[v];
                     if (d->m_constructor == nullptr) {
@@ -694,9 +694,12 @@ namespace smt {
         return false;
     }
 
-    theory_datatype::theory_datatype(ast_manager & m, theory_datatype_params & p):
+    theory_datatype_params const& theory_datatype::params() const { 
+        return get_context().get_fparams(); 
+    }
+
+    theory_datatype::theory_datatype(ast_manager & m):
         theory(m.mk_family_id("datatype")),
-        m_params(p),
         m_util(m),
         m_autil(m),
         m_find(*this),
@@ -932,7 +935,7 @@ namespace smt {
         else {
             // there are more than 2 unassigned recognizers...
             // if eager splits are enabled... create new case split
-            if (m_params.m_dt_lazy_splits == 0 || (!dt->is_infinite() && m_params.m_dt_lazy_splits == 1))
+            if (params().m_dt_lazy_splits == 0 || (!dt->is_infinite() && params().m_dt_lazy_splits == 1))
                 mk_split(v);
         }
     }
diff --git a/src/smt/theory_datatype.h b/src/smt/theory_datatype.h
index 44f64f160..4052bf867 100644
--- a/src/smt/theory_datatype.h
+++ b/src/smt/theory_datatype.h
@@ -45,9 +45,7 @@ namespace smt {
             void reset() { memset(this, 0, sizeof(stats)); }
             stats() { reset(); }
         };
-
         
-        theory_datatype_params &  m_params;
         datatype_util             m_util;
         array_util                m_autil;
         ptr_vector<var_data>      m_var_data;
@@ -130,8 +128,9 @@ namespace smt {
         void reset_eh() override;
         void restart_eh() override { m_util.reset(); }
         bool is_shared(theory_var v) const override;
+        theory_datatype_params const& params() const;
     public:
-        theory_datatype(ast_manager & m, theory_datatype_params & p);
+        theory_datatype(ast_manager & m);
         ~theory_datatype() override;
         theory * mk_fresh(context * new_ctx) override;
         void display(std::ostream & out) const override;