From 137fd735f5cb31b6fbd0da10aaae66f7c36792c4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 1 Mar 2026 01:49:00 +0000 Subject: [PATCH 1/2] Initial plan From 23d194502a91f20cd50e78d3b8f1a94689acd5cf Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 1 Mar 2026 02:10:19 +0000 Subject: [PATCH 2/2] Simplify def_ref smart pointer: default ctor, init list, clearer bool, remove extra semicolon Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com> --- src/math/simplex/model_based_opt.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/math/simplex/model_based_opt.h b/src/math/simplex/model_based_opt.h index 0d1f9117b..bc89ea4b7 100644 --- a/src/math/simplex/model_based_opt.h +++ b/src/math/simplex/model_based_opt.h @@ -117,9 +117,9 @@ namespace opt { class def_ref { def* m_def = nullptr; public: - def_ref(def* d) { - if (d) d->inc_ref(); - m_def = d; + def_ref() = default; + def_ref(def* d) : m_def(d) { + if (m_def) m_def->inc_ref(); } def_ref(def_ref const& other) : m_def(other.m_def) { if (m_def) m_def->inc_ref(); @@ -155,9 +155,9 @@ namespace opt { def& operator*() { return *m_def; } def* operator->() { return m_def; } def const& operator*() const { return *m_def; } - operator bool() const { return !!m_def; } + operator bool() const { return m_def != nullptr; } - ~def_ref() { if (m_def) m_def->dec_ref(); }; + ~def_ref() { if (m_def) m_def->dec_ref(); } }; struct add_def : public def { def* x, *y;