3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2025-04-23 09:05:31 +00:00

Use = delete to delete special methods.

This provides a better experience than just marking them as
private and leaving them as undefined symbols.
This commit is contained in:
Bruce Mitchener 2022-08-01 22:45:50 +07:00 committed by Nikolaj Bjorner
parent 059b795faa
commit 82d853e5f8
9 changed files with 24 additions and 30 deletions

View file

@ -80,10 +80,8 @@ namespace datalog {
bool passes_output_thresholds(context & ctx) const;
void output_profile(std::ostream & out) const;
private:
//private and undefined copy constructor and operator= to avoid the default ones
accounted_object(const accounted_object &);
accounted_object& operator=(const accounted_object &);
accounted_object(const accounted_object &) = delete;
accounted_object& operator=(const accounted_object &) = delete;
};

View file

@ -25,10 +25,6 @@ Revision History:
namespace datalog {
class rule_subsumption_index {
//private and undefined copy constroctor
rule_subsumption_index(rule_subsumption_index const&);
//private and undefined operator=
rule_subsumption_index& operator=(rule_subsumption_index const&);
typedef obj_hashtable<app> app_set;
@ -53,6 +49,8 @@ namespace datalog {
reset_dealloc_values(m_unconditioned_heads);
}
rule_subsumption_index(rule_subsumption_index const&) = delete;
rule_subsumption_index& operator=(rule_subsumption_index const&) = delete;
void add(rule * r);
bool is_subsumed(rule * r);
bool is_subsumed(app * query);

View file

@ -180,10 +180,9 @@ namespace datalog {
public:
base_fn() = default;
virtual ~base_fn() {}
private:
//private and undefined copy constructor and operator= to avoid copying
base_fn(const base_fn &);
base_fn& operator=(const base_fn &);
base_fn(const base_fn &) = delete;
base_fn& operator=(const base_fn &) = delete;
};
class join_fn : public base_fn {
@ -1098,6 +1097,9 @@ namespace datalog {
iterator_core() : m_ref_cnt(0) {}
virtual ~iterator_core() {}
iterator_core(const iterator_core &) = delete;
iterator_core & operator=(const iterator_core &) = delete;
void inc_ref() { m_ref_cnt++; }
void dec_ref() {
SASSERT(m_ref_cnt>0);
@ -1116,10 +1118,6 @@ namespace datalog {
//the equality with the end() iterator
return is_finished() && it.is_finished();
}
private:
//private and undefined copy constructor and assignment operator
iterator_core(const iterator_core &);
iterator_core & operator=(const iterator_core &);
};
struct row_iterator_core {
@ -1128,6 +1126,9 @@ namespace datalog {
row_iterator_core() : m_ref_cnt(0) {}
virtual ~row_iterator_core() {}
row_iterator_core(const row_iterator_core &) = delete;
row_iterator_core & operator=(const row_iterator_core &) = delete;
void inc_ref() { m_ref_cnt++; }
void dec_ref() {
SASSERT(m_ref_cnt>0);
@ -1146,10 +1147,6 @@ namespace datalog {
//the equality with the end() iterator
return is_finished() && it.is_finished();
}
private:
//private and undefined copy constructor and assignment operator
row_iterator_core(const row_iterator_core &);
row_iterator_core & operator=(const row_iterator_core &);
};
public:

View file

@ -56,6 +56,7 @@ namespace datalog {
pair_info() {}
pair_info & operator=(const pair_info &) = delete;
bool can_be_joined() const {
return m_consumers > 0;
}
@ -110,8 +111,6 @@ namespace datalog {
SASSERT(!m_rules.empty() || m_consumers == 0);
return m_rules.empty();
}
private:
pair_info & operator=(const pair_info &); //to avoid the implicit one
};
typedef std::pair<app*, app*> app_pair;
typedef pair_hash<obj_ptr_hash<app>, obj_ptr_hash<app> > app_pair_hash;

View file

@ -111,8 +111,6 @@ namespace datalog {
rule_unifier m_unifier;
slice_proof_converter(slice_proof_converter const& other);
void init_form2rule() {
if (!m_sliceform2rule.empty()) {
return;
@ -271,6 +269,8 @@ namespace datalog {
m_renaming.insert(orig_rule, unsigned_vector(sz, renaming));
}
slice_proof_converter(slice_proof_converter const& other) = delete;
proof_ref operator()(ast_manager& m, unsigned num_source, proof * const * source) override {
SASSERT(num_source == 1);
proof_ref result(source[0], m);