From 8263d20e0d2ea0c4ff6214247fb41c91ef711aa8 Mon Sep 17 00:00:00 2001 From: Nikolaj Bjorner Date: Tue, 20 Apr 2021 11:30:25 -0700 Subject: [PATCH] add code review comment --- src/ast/seq_decl_plugin.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ast/seq_decl_plugin.cpp b/src/ast/seq_decl_plugin.cpp index c16071cdf..9a7b53946 100644 --- a/src/ast/seq_decl_plugin.cpp +++ b/src/ast/seq_decl_plugin.cpp @@ -1492,6 +1492,7 @@ seq_util::rex::info seq_util::rex::info::orelse(seq_util::rex::info const& i) co seq_util::rex::info seq_util::rex::info::loop(unsigned lower, unsigned upper) const { if (is_known()) { unsigned m = min_length * lower; + // Code review: this is not a complete overflow check. if (m > 0 && (m < min_length || m < lower)) m = UINT_MAX; lbool loop_nullable = (nullable == l_true || lower == 0 ? l_true : nullable);