From 80c0c4f66362d7815e6062c391be2d68b80a6f11 Mon Sep 17 00:00:00 2001
From: Dan Liew <daniel.liew@imperial.ac.uk>
Date: Sat, 24 Jun 2017 15:15:27 +0100
Subject: [PATCH] [CMake] Fix detection of git description and hash for CMake
 2.8.12

---
 CMakeLists.txt        | 4 ++--
 cmake/git_utils.cmake | 8 ++++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8ed5c7d5e..c8ecb5295 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -109,7 +109,7 @@ if (EXISTS "${GIT_DIR}")
       endif()
       message(STATUS "Using Git hash in version output: ${Z3GITHASH}")
       # This mimics the behaviour of the old build system.
-      string(APPEND Z3_FULL_VERSION_STR " ${Z3GITHASH}")
+      set(Z3_FULL_VERSION_STR "${Z3_FULL_VERSION_STR} ${Z3GITHASH}")
     else()
       message(STATUS "Not using Git hash in version output")
       unset(Z3GITHASH) # Used in configure_file()
@@ -122,7 +122,7 @@ if (EXISTS "${GIT_DIR}")
       endif()
       message(STATUS "Using Git description in version output: ${Z3_GIT_DESCRIPTION}")
       # This mimics the behaviour of the old build system.
-      string(APPEND Z3_FULL_VERSION_STR " ${Z3_GIT_DESCRIPTION}")
+      set(Z3_FULL_VERSION_STR "${Z3_FULL_VERSION_STR} ${Z3_GIT_DESCRIPTION}")
     else()
       message(STATUS "Not including git descrption in version")
     endif()
diff --git a/cmake/git_utils.cmake b/cmake/git_utils.cmake
index aa7f38825..f98aca205 100644
--- a/cmake/git_utils.cmake
+++ b/cmake/git_utils.cmake
@@ -99,7 +99,9 @@ function(get_git_head_hash GIT_DIR OUTPUT_VAR)
     message(FATAL_ERROR \""${GIT_DIR}\" is not an absolute path")
   endif()
   find_package(Git)
-  if (NOT Git_FOUND)
+  # NOTE: Use `GIT_FOUND` rather than `Git_FOUND` which was only
+  # available in CMake >= 3.5
+  if (NOT GIT_FOUND)
     set(${OUTPUT_VAR} "GIT-NOTFOUND" PARENT_SCOPE)
     return()
   endif()
@@ -146,7 +148,9 @@ function(get_git_head_describe GIT_DIR OUTPUT_VAR)
     message(FATAL_ERROR \""${GIT_DIR}\" is not an absolute path")
   endif()
   find_package(Git)
-  if (NOT Git_FOUND)
+  # NOTE: Use `GIT_FOUND` rather than `Git_FOUND` which was only
+  # available in CMake >= 3.5
+  if (NOT GIT_FOUND)
     set(${OUTPUT_VAR} "GIT-NOTFOUND" PARENT_SCOPE)
     return()
   endif()