From 7efcda2674d06ef9ff084602d7727e263c5829f4 Mon Sep 17 00:00:00 2001 From: Nikolaj Bjorner Date: Mon, 15 Sep 2025 09:38:17 -0700 Subject: [PATCH] Update polynomial.cpp --- src/math/polynomial/polynomial.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/math/polynomial/polynomial.cpp b/src/math/polynomial/polynomial.cpp index eb8a0a4ff..05ef4ed60 100644 --- a/src/math/polynomial/polynomial.cpp +++ b/src/math/polynomial/polynomial.cpp @@ -2334,7 +2334,8 @@ namespace polynomial { // Buffer for multiplying large polynomials. // It delays internalizing monomials, and uses sorted vectors instead of hash tables. // this implementation is 10x slower on results up to 10K monomials - // it also has a bug as entries are not properly sorted. + // it also has a bug as entries are not properly sorted and therefore + // the same monomial can appear several times. // perf tuning and debugging is required if this is to be used. // it is possible this can be faster for very large polynomials by ensuring cache locality. // at this point there are several cache misses: such as m_powers are pointers inside of m_monomial.