diff --git a/src/nlsat/levelwise.cpp b/src/nlsat/levelwise.cpp index a2e527981..d728f40a0 100644 --- a/src/nlsat/levelwise.cpp +++ b/src/nlsat/levelwise.cpp @@ -1108,8 +1108,8 @@ namespace nlsat { add_projection_for_poly(p, m_level, witness, true, true); // section poly: full projection else if (has_roots.find(i) == has_roots.end()) add_projection_for_poly(p, m_level, witness, true, true); // no roots: need LC+disc for delineability - else if (witness && !is_const(witness)) - request_factorized(witness); // has roots: witness only + else + add_projection_for_poly(p, m_level, witness, false, true); } } diff --git a/src/test/nlsat.cpp b/src/test/nlsat.cpp index 9a650e56d..2380d07a7 100644 --- a/src/test/nlsat.cpp +++ b/src/test/nlsat.cpp @@ -134,6 +134,34 @@ static bool is_point_inside_cell( return true; } +// Helper: verify that counter_as has a different sign than sample_as on at least +// one polynomial in polys. Only polynomials whose max_var is assigned in BOTH +// assignments are checked. Returns true when at least one sign differs. +static bool has_different_sign( + anum_manager& am, + polynomial::manager& pm, + polynomial_ref_vector const& polys, + nlsat::assignment const& sample_as, + nlsat::assignment const& counter_as) +{ + for (unsigned i = 0; i < polys.size(); ++i) { + polynomial_ref p(polys.get(i), pm); + polynomial::var mv = pm.max_var(p); + if (mv == polynomial::null_var) // constant polynomial + continue; + if (!sample_as.is_assigned(mv) || !counter_as.is_assigned(mv)) + continue; + sign s_sign = am.eval_sign_at(p, sample_as); + sign c_sign = am.eval_sign_at(p, counter_as); + if (s_sign != c_sign) { + std::cout << " p" << i << " has different sign: sample=" << s_sign + << ", counter=" << c_sign << "\n"; + return true; + } + } + return false; +} + nlsat::interval_set_ref tst_interval(nlsat::interval_set_ref const & s1, nlsat::interval_set_ref const & s2, unsigned expected_num_intervals, @@ -167,7 +195,7 @@ nlsat::interval_set_ref tst_interval(nlsat::interval_set_ref const & s1, } static void tst3() { - enable_trace("nlsat_interval"); + // enable_trace("nlsat_interval"); reslimit rl; unsynch_mpq_manager qm; anum_manager am(rl, qm); @@ -353,7 +381,7 @@ static void check_subset_result(nlsat::interval_set_ref const & s1, } static void tst4() { - enable_trace("nlsat_interval"); + // enable_trace("nlsat_interval"); reslimit rl; unsynch_mpq_manager qm; anum_manager am(rl, qm); @@ -1168,7 +1196,7 @@ static void tst_nullified_polynomial() { // Test case for unsound lemma lws2380 - comparing standard projection vs levelwise // The issue: x7 is unconstrained in levelwise output but affects the section polynomial static void tst_unsound_lws2380() { - enable_trace("nlsat_explain"); + // enable_trace("nlsat_explain"); auto run_test = [](bool use_lws) { std::cout << "=== tst_unsound_lws2380: " << (use_lws ? "Levelwise" : "Standard") << " projection (lws=" << use_lws << ") ===\n"; @@ -1337,14 +1365,7 @@ static void tst_unsound_lws_x3() { polynomial_ref p4(pm); p4 = _x3 + _x1 + _x0; - std::cout << "p0: " << p0 << "\n"; - std::cout << "p1: " << p1 << "\n"; - std::cout << "p2: " << p2 << "\n"; - std::cout << "p3: " << p3 << "\n"; - std::cout << "p4: " << p4 << "\n\n"; - - // Set sample: x0=-7, x1=-1, x2=1, x3=? (need to pick a value in the cell) - // For the sample, we need an x3 value. Let's use x3=8 (which is > -x0 = 7, so p0 > 0) + // Set sample: x0=-7, x1=-1, x2=1, x3=8 scoped_anum val(am); am.set(val, -7); sample_as.set(x0, val); am.set(val, -1); sample_as.set(x1, val); @@ -1357,29 +1378,7 @@ static void tst_unsound_lws_x3() { am.set(val, 5); counter_as.set(x2, val); am.set(val, 6); counter_as.set(x3, val); - std::cout << "Sample point: x0=-7, x1=-1, x2=1, x3=8\n"; - std::cout << "Counterexample: x0=-4, x1=-8, x2=5, x3=6\n\n"; - - // Evaluate polynomials at sample - std::cout << "Polynomial signs at SAMPLE:\n"; - std::cout << " p0 sign: " << am.eval_sign_at(p0, sample_as) << "\n"; - std::cout << " p1 sign: " << am.eval_sign_at(p1, sample_as) << "\n"; - std::cout << " p2 sign: " << am.eval_sign_at(p2, sample_as) << "\n"; - std::cout << " p3 sign: " << am.eval_sign_at(p3, sample_as) << "\n"; - std::cout << " p4 sign: " << am.eval_sign_at(p4, sample_as) << "\n\n"; - - // Evaluate polynomials at counterexample - std::cout << "Polynomial signs at COUNTEREXAMPLE:\n"; - std::cout << " p0 sign: " << am.eval_sign_at(p0, counter_as) << "\n"; - std::cout << " p1 sign: " << am.eval_sign_at(p1, counter_as) << "\n"; - std::cout << " p2 sign: " << am.eval_sign_at(p2, counter_as) << "\n"; - std::cout << " p3 sign: " << am.eval_sign_at(p3, counter_as) << "\n"; - std::cout << " p4 sign: " << am.eval_sign_at(p4, counter_as) << "\n\n"; - - // Set solver assignment for levelwise (without x3) - am.set(val, -7); sample_as.set(x0, val); - am.set(val, -1); sample_as.set(x1, val); - am.set(val, 1); sample_as.set(x2, val); + // Set solver assignment for levelwise s.set_rvalues(sample_as); // Build polynomial vector @@ -1391,162 +1390,16 @@ static void tst_unsound_lws_x3() { polys.push_back(p4); unsigned max_x = x3; - - // Print roots of each polynomial at sample - std::cout << "Roots of polynomials at sample (in x3):\n"; - for (unsigned i = 0; i < polys.size(); ++i) { - polynomial_ref p(polys.get(i), pm); - if (pm.max_var(p) != x3) { - std::cout << " p" << i << ": max_var is not x3, skipping\n"; - continue; - } - scoped_anum_vector roots(am); - am.isolate_roots(p, nlsat::undef_var_assignment(sample_as, x3), roots); - std::cout << " p" << i << " roots: "; - if (roots.empty()) { - std::cout << "(none)"; - } else { - for (unsigned j = 0; j < roots.size(); ++j) { - if (j > 0) std::cout << ", "; - am.display_decimal(std::cout, roots[j], 5); - } - } - std::cout << "\n"; - } - std::cout << "\n"; - - // Compute and evaluate resultant of p3 and p4 - std::cout << "Resultant of p3 and p4 (in x3):\n"; - polynomial_ref res_p3_p4(pm); - { - pm.resultant(p3, p4, x3, res_p3_p4); - std::cout << " Res(p3, p4) = "; - pm.display(std::cout, res_p3_p4); - std::cout << "\n"; - std::cout << " Sign at sample (x0=-7, x1=-1, x2=1): " << am.eval_sign_at(res_p3_p4, sample_as) << "\n"; - std::cout << " Sign at counter (x0=-4, x1=-8, x2=5): " << am.eval_sign_at(res_p3_p4, counter_as) << "\n"; - - // Check roots of the resultant at x2 level (parametric in x0, x1) - std::cout << " Roots at sample x0,x1 (in x2): "; - scoped_anum_vector res_roots(am); - nlsat::assignment partial_sample(am); - scoped_anum val(am); - am.set(val, -7); partial_sample.set(x0, val); - am.set(val, -1); partial_sample.set(x1, val); - am.isolate_roots(res_p3_p4, nlsat::undef_var_assignment(partial_sample, x2), res_roots); - for (unsigned j = 0; j < res_roots.size(); ++j) { - if (j > 0) std::cout << ", "; - am.display_decimal(std::cout, res_roots[j], 5); - } - std::cout << "\n"; - - // Check roots at counterexample x0,x1 - std::cout << " Roots at counter x0,x1 (in x2): "; - nlsat::assignment partial_counter(am); - am.set(val, -4); partial_counter.set(x0, val); - am.set(val, -8); partial_counter.set(x1, val); - scoped_anum_vector res_roots_counter(am); - am.isolate_roots(res_p3_p4, nlsat::undef_var_assignment(partial_counter, x2), res_roots_counter); - for (unsigned j = 0; j < res_roots_counter.size(); ++j) { - if (j > 0) std::cout << ", "; - am.display_decimal(std::cout, res_roots_counter[j], 5); - } - std::cout << "\n"; - - // Compute and check discriminant of Res(p3,p4) in x2 - std::cout << "\n Discriminant of Res(p3,p4) in x2:\n"; - polynomial_ref disc_res(pm); - pm.discriminant(res_p3_p4, x2, disc_res); - std::cout << " Disc = "; - pm.display(std::cout, disc_res); - std::cout << "\n"; - std::cout << " Sign at sample (x0=-7, x1=-1): " << am.eval_sign_at(disc_res, sample_as) << "\n"; - std::cout << " Sign at counter (x0=-4, x1=-8): " << am.eval_sign_at(disc_res, counter_as) << "\n"; - } - std::cout << "\n"; - - std::cout << "Running levelwise with max_x = x3\n"; // Run levelwise nlsat::levelwise lws(s, polys, max_x, s.sample(), pm, am, cache); auto cell = lws.single_cell(); - - std::cout << "Cell intervals (count=" << cell.size() << "):\n"; - for (auto const& interval : cell) { - nlsat::display(std::cout << " ", s, interval) << "\n"; - } - // Evaluate cell bounds at counterexample to check if counterexample is in cell - std::cout << "\n--- Checking if counterexample is in cell ---\n"; - std::cout << "For a SECTOR (lower_root, upper_root), variable x satisfies:\n"; - std::cout << " x > lower_root AND x < upper_root\n\n"; - - // For univariate evaluation, we need to substitute lower vars - // Level 0: x0 interval, evaluate at x0=-4 - // Level 1: x1 interval (parametric in x0), evaluate at (x0=-4, x1=-8) - // Level 2: x2 interval (parametric in x0,x1), evaluate at (x0=-4,x1=-8,x2=5) - - bool counterexample_outside_cell = false; - - for (unsigned i = 0; i < cell.size(); ++i) { - auto const& interval = cell[i]; - nlsat::var level = i; - std::cout << "Level " << level << ":\n"; - - // Build assignment up to this level (exclusive) for root isolation - nlsat::assignment partial_as(am); - scoped_anum val(am); - if (level > 0) { am.set(val, -4); partial_as.set(x0, val); } - if (level > 1) { am.set(val, -8); partial_as.set(x1, val); } - if (level > 2) { am.set(val, 5); partial_as.set(x2, val); } - - scoped_anum counter_val(am); - if (level == 0) am.set(counter_val, -4); - else if (level == 1) am.set(counter_val, -8); - else if (level == 2) am.set(counter_val, 5); - - if (interval.is_section()) { - std::cout << " Section case\n"; - } else { - // Isolate roots and check bounds - if (!interval.l_inf()) { - polynomial_ref lower_p(interval.l, pm); - scoped_anum_vector lower_roots(am); - am.isolate_roots(lower_p, nlsat::undef_var_assignment(partial_as, level), lower_roots); - if (lower_roots.size() >= interval.l_index) { - std::cout << " Lower root (root[" << interval.l_index << "]): "; - am.display_decimal(std::cout, lower_roots[interval.l_index - 1], 10); - std::cout << "\n"; - std::cout << " Counter x" << level << " = "; - am.display_decimal(std::cout, counter_val, 10); - int cmp = am.compare(counter_val, lower_roots[interval.l_index - 1]); - std::cout << " -> " << (cmp > 0 ? "ABOVE" : (cmp < 0 ? "BELOW" : "EQUAL")) << " lower bound\n"; - if (cmp <= 0) counterexample_outside_cell = true; - } - } - if (!interval.u_inf()) { - polynomial_ref upper_p(interval.u, pm); - scoped_anum_vector upper_roots(am); - am.isolate_roots(upper_p, nlsat::undef_var_assignment(partial_as, level), upper_roots); - if (upper_roots.size() >= interval.u_index) { - std::cout << " Upper root (root[" << interval.u_index << "]): "; - am.display_decimal(std::cout, upper_roots[interval.u_index - 1], 10); - std::cout << "\n"; - std::cout << " Counter x" << level << " = "; - am.display_decimal(std::cout, counter_val, 10); - int cmp = am.compare(counter_val, upper_roots[interval.u_index - 1]); - std::cout << " -> " << (cmp > 0 ? "ABOVE" : (cmp < 0 ? "BELOW" : "EQUAL")) << " upper bound\n"; - if (cmp >= 0) counterexample_outside_cell = true; - } - } - } - std::cout << "\n"; - } + // Sanity-check: the counterexample must truly be a counterexample + ENSURE(has_different_sign(am, pm, polys, sample_as, counter_as)); - // The counterexample has different polynomial signs than the sample. - // For a sound cell, the counterexample must be OUTSIDE the cell. - ENSURE(counterexample_outside_cell); - std::cout << "SUCCESS: Counterexample is OUTSIDE the cell (cell is sound)\n"; + // Counterexample must be OUTSIDE the cell + ENSURE(!is_point_inside_cell(am, pm, cell, counter_as)); std::cout << "=== END tst_unsound_lws_x3 ===\n\n"; } @@ -1629,16 +1482,9 @@ static void tst_unsound_lws_n46() { polynomial_ref p4(pm); p4 = _x2 * _x6 * _x7 - 2; - std::cout << "Input polynomials:\n"; - std::cout << " p0: " << p0 << "\n"; - std::cout << " p1: " << p1 << "\n"; - std::cout << " p2: " << p2 << "\n"; - std::cout << " p3: " << p3 << "\n"; - std::cout << " p4: " << p4 << "\n\n"; - // Set sample point: x0=1, x1=2, x2=1, x3=-1, x4=-1, x5=1, x6=7/8 scoped_anum val(am); - rational q(7, 8); // 0.875 = 7/8 + rational q(7, 8); am.set(val, 1); sample_as.set(x0, val); am.set(val, 2); sample_as.set(x1, val); am.set(val, 1); sample_as.set(x2, val); @@ -1647,8 +1493,6 @@ static void tst_unsound_lws_n46() { am.set(val, 1); sample_as.set(x5, val); am.set(val, q.to_mpq()); sample_as.set(x6, val); - std::cout << "Sample point: x0=1, x1=2, x2=1, x3=-1, x4=-1, x5=1, x6=7/8\n"; - // Set counterexample: x0=1, x2=1, x3=0, x4=-9, x5=0, x6=5, x7=0 am.set(val, 1); counter_as.set(x0, val); am.set(val, 0); counter_as.set(x1, val); @@ -1659,8 +1503,6 @@ static void tst_unsound_lws_n46() { am.set(val, 5); counter_as.set(x6, val); am.set(val, 0); counter_as.set(x7, val); - std::cout << "Counterexample: x0=1, x2=1, x3=0, x4=-9, x5=0, x6=5, x7=0\n\n"; - // Set solver assignment for levelwise s.set_rvalues(sample_as); @@ -1675,85 +1517,19 @@ static void tst_unsound_lws_n46() { nlsat::var max_x = x7; // Run levelwise - std::cout << "Running levelwise with max_x = x7...\n"; nlsat::levelwise lws(s, polys, max_x, s.sample(), pm, am, cache); auto cell = lws.single_cell(); - std::cout << "Cell intervals:\n"; - for (unsigned i = 0; i < cell.size(); ++i) { - std::cout << " Level " << i << ": "; - nlsat::display(std::cout, s, cell[i]) << "\n"; - } - - // Print the lemma produced by levelwise - std::cout << "\n--- LEMMA from levelwise ---\n"; - for (unsigned i = 0; i < cell.size(); ++i) { - auto const& interval = cell[i]; - if (interval.section) { - std::cout << "!(x" << i << " = root[" << interval.l_index << "]("; - pm.display(std::cout, interval.l) << "))\n"; - } else { - if (!interval.l_inf()) { - std::cout << "!(x" << i << " > root[" << interval.l_index << "]("; - pm.display(std::cout, interval.l) << "))\n"; - } - if (!interval.u_inf()) { - std::cout << "!(x" << i << " < root[" << interval.u_index << "]("; - pm.display(std::cout, interval.u) << "))\n"; - } - } - } - std::cout << "--- END LEMMA ---\n\n"; - - // Test for the discriminant projection fix: - // - // BUG: When p1 = (x6-1)^2 at the sample (a double root), the discriminant of p1 - // is zero. The function compute_omit_disc_for_same_boundary() incorrectly omitted - // this discriminant because it only checked if p1(sample) != 0, not if disc(p1) = 0. - // - // FIX: Now we also check if disc(p) = 0 at sample, and if so, we keep the discriminant. - // This causes the discriminant's root polynomial (x2*x4 + x0) to be projected, - // creating a section at level 4 that excludes the counterexample. - - std::cout << "=== Verifying discriminant projection fix ===\n"; - - // Check 1: Level 4 should now be a SECTION (not a sector as before the fix) - // The discriminant of p1 w.r.t. x6 has a factor (x2*x4 + x0) that becomes the section + // Verify discriminant projection fix: + // Level 4 should be a SECTION (disc of p1 w.r.t. x6 has factor x2*x4+x0) ENSURE(cell.size() > 4); - ENSURE(cell[4].section); // Level 4 must be a section after the fix - std::cout << "Level 4 is a section: " << (cell[4].section ? "YES (FIX WORKING)" : "NO (BUG!)") << "\n"; + ENSURE(cell[4].section); - // Check 2: The section polynomial at level 4 should be x2*x4 + x0 (or equivalent) - // At sample: x2=1, x0=1, so root is x4 = -x0/x2 = -1 (matches sample x4=-1) - polynomial_ref section_poly(cell[4].l, pm); - std::cout << "Level 4 section polynomial: " << section_poly << "\n"; + // Sanity-check: the counterexample must truly be a counterexample + ENSURE(has_different_sign(am, pm, polys, sample_as, counter_as)); - // Check 3: Verify the counterexample is OUTSIDE the cell - // At counterexample: x2=1, x0=1, so section root is x4 = -1 - // But counterexample has x4 = -9, which is NOT equal to -1 - // Therefore the literal !(x4 = root[1](...)) is TRUE, making the lemma sound - - polynomial_ref x4_section(pm); - x4_section = _x2 * _x4 + _x0; // Expected section polynomial - scoped_anum_vector roots_x4(am); - am.isolate_roots(x4_section, nlsat::undef_var_assignment(counter_as, x4), roots_x4); - - std::cout << "At counterexample:\n"; - std::cout << " Section polynomial: x2*x4 + x0 = x4 + 1\n"; - std::cout << " Section root: x4 = "; - if (!roots_x4.empty()) am.display_decimal(std::cout, roots_x4[0], 6); - std::cout << "\n"; - std::cout << " Counterexample x4 = -9\n"; - - bool x4_at_section = !roots_x4.empty() && am.eq(counter_as.value(x4), roots_x4[0]); - std::cout << " Is x4=-9 equal to section root? " << (x4_at_section ? "YES" : "NO") << "\n"; - - // The fix ensures x4_at_section is FALSE, meaning the counterexample is OUTSIDE the cell - ENSURE(!x4_at_section); // Counterexample must NOT satisfy the section constraint - - std::cout << "\n=== FIX VERIFIED: Counterexample is outside the cell ===\n"; - std::cout << "The lemma literal !(x4 = root[1](x2*x4 + x0)) is TRUE at counterexample.\n"; - std::cout << "Therefore the lemma is SOUND (disjunction has a true literal).\n"; + // Counterexample must be OUTSIDE the cell + ENSURE(!is_point_inside_cell(am, pm, cell, counter_as)); std::cout << "=== END tst_unsound_lws_n46 ===\n\n"; } @@ -1817,11 +1593,6 @@ static void tst_unsound_lws_et4() { polynomial_ref p3(pm); p3 = _x5 - 9; - std::cout << "p0: " << p0 << "\n"; - std::cout << "p1: " << p1 << "\n"; - std::cout << "p2: " << p2 << "\n"; - std::cout << "p3: " << p3 << "\n\n"; - // Sample: x0=4, x1=5, x2=3.5, x3=-8, x4=5 scoped_anum val(am); am.set(val, 4); sample_as.set(x0, val); @@ -1834,18 +1605,13 @@ static void tst_unsound_lws_et4() { // Counterexample: x0=5, x3=3, x4=0, x5=0 am.set(val, 5); counter_as.set(x0, val); - am.set(val, 5); counter_as.set(x1, val); // use same as sample - am.set(val, q.to_mpq()); counter_as.set(x2, val); // use same as sample + am.set(val, 5); counter_as.set(x1, val); + am.set(val, q.to_mpq()); counter_as.set(x2, val); am.set(val, 3); counter_as.set(x3, val); am.set(val, 0); counter_as.set(x4, val); am.set(val, 0); counter_as.set(x5, val); - std::cout << "Sample point: x0=4, x1=5, x2=3.5, x3=-8, x4=5\n"; - std::cout << "Counterexample: x0=5, x3=3, x4=0, x5=0\n\n"; - - // Evaluate polynomials at sample (need to set x5 for evaluation) - scoped_anum sample_x5(am); - am.set(sample_x5, 0); // pick some value in the cell + // sample_full includes x5=0 for sign evaluation nlsat::assignment sample_full(am); am.set(val, 4); sample_full.set(x0, val); am.set(val, 5); sample_full.set(x1, val); @@ -1853,19 +1619,6 @@ static void tst_unsound_lws_et4() { am.set(val, -8); sample_full.set(x3, val); am.set(val, 5); sample_full.set(x4, val); am.set(val, 0); sample_full.set(x5, val); - - std::cout << "Polynomial signs at SAMPLE (with x5=0):\n"; - std::cout << " p0 sign: " << am.eval_sign_at(p0, sample_full) << "\n"; - std::cout << " p1 sign: " << am.eval_sign_at(p1, sample_full) << "\n"; - std::cout << " p2 sign: " << am.eval_sign_at(p2, sample_full) << "\n"; - std::cout << " p3 sign: " << am.eval_sign_at(p3, sample_full) << "\n\n"; - - // Evaluate polynomials at counterexample - std::cout << "Polynomial signs at COUNTEREXAMPLE:\n"; - std::cout << " p0 sign: " << am.eval_sign_at(p0, counter_as) << "\n"; - std::cout << " p1 sign: " << am.eval_sign_at(p1, counter_as) << "\n"; - std::cout << " p2 sign: " << am.eval_sign_at(p2, counter_as) << "\n"; - std::cout << " p3 sign: " << am.eval_sign_at(p3, counter_as) << "\n\n"; // Set solver assignment for levelwise (without x5) s.set_rvalues(sample_as); @@ -1878,110 +1631,16 @@ static void tst_unsound_lws_et4() { polys.push_back(p3); unsigned max_x = x5; - - // Print roots of each polynomial at sample - std::cout << "Roots of polynomials at sample (in x5):\n"; - for (unsigned i = 0; i < polys.size(); ++i) { - polynomial_ref p(polys.get(i), pm); - if (pm.max_var(p) != x5) { - std::cout << " p" << i << ": max_var is not x5, skipping\n"; - continue; - } - scoped_anum_vector roots(am); - am.isolate_roots(p, nlsat::undef_var_assignment(sample_as, x5), roots); - std::cout << " p" << i << " roots: "; - if (roots.empty()) { - std::cout << "(none)"; - } else { - for (unsigned j = 0; j < roots.size(); ++j) { - if (j > 0) std::cout << ", "; - am.display_decimal(std::cout, roots[j], 5); - } - } - std::cout << "\n"; - } - std::cout << "\n"; - - std::cout << "Running levelwise with max_x = x5\n"; // Run levelwise nlsat::levelwise lws(s, polys, max_x, s.sample(), pm, am, cache); auto cell = lws.single_cell(); - - std::cout << "Cell intervals (count=" << cell.size() << "):\n"; - for (auto const& interval : cell) { - nlsat::display(std::cout << " ", s, interval) << "\n"; - } - // Evaluate cell bounds at counterexample to check if counterexample is in cell - std::cout << "\n--- Checking if counterexample is in cell ---\n"; - - bool counterexample_outside_cell = false; - - for (unsigned i = 0; i < cell.size(); ++i) { - auto const& interval = cell[i]; - nlsat::var level = i; - std::cout << "Level " << level << " (x" << level << "):\n"; - - // Build assignment up to this level (exclusive) for root isolation - nlsat::assignment partial_as(am); - scoped_anum val(am); - if (level > 0) { am.set(val, 5); partial_as.set(x0, val); } // counter x0 - if (level > 1) { am.set(val, 5); partial_as.set(x1, val); } - if (level > 2) { am.set(val, q.to_mpq()); partial_as.set(x2, val); } - if (level > 3) { am.set(val, 3); partial_as.set(x3, val); } // counter x3 - if (level > 4) { am.set(val, 0); partial_as.set(x4, val); } // counter x4 - - scoped_anum counter_val(am); - if (level == 0) am.set(counter_val, 5); // x0 - else if (level == 1) am.set(counter_val, 5); - else if (level == 2) am.set(counter_val, q.to_mpq()); - else if (level == 3) am.set(counter_val, 3); // x3 - else if (level == 4) am.set(counter_val, 0); // x4 - else if (level == 5) am.set(counter_val, 0); // x5 - - if (interval.is_section()) { - std::cout << " Section case\n"; - } else { - // Isolate roots and check bounds - if (!interval.l_inf()) { - polynomial_ref lower_p(interval.l, pm); - scoped_anum_vector lower_roots(am); - am.isolate_roots(lower_p, nlsat::undef_var_assignment(partial_as, level), lower_roots); - if (lower_roots.size() >= interval.l_index) { - std::cout << " Lower root (root[" << interval.l_index << "]): "; - am.display_decimal(std::cout, lower_roots[interval.l_index - 1], 10); - std::cout << "\n"; - std::cout << " Counter x" << level << " = "; - am.display_decimal(std::cout, counter_val, 10); - int cmp = am.compare(counter_val, lower_roots[interval.l_index - 1]); - std::cout << " -> " << (cmp > 0 ? "ABOVE" : (cmp < 0 ? "BELOW" : "EQUAL")) << " lower bound\n"; - if (cmp <= 0) counterexample_outside_cell = true; - } - } - if (!interval.u_inf()) { - polynomial_ref upper_p(interval.u, pm); - scoped_anum_vector upper_roots(am); - am.isolate_roots(upper_p, nlsat::undef_var_assignment(partial_as, level), upper_roots); - if (upper_roots.size() >= interval.u_index) { - std::cout << " Upper root (root[" << interval.u_index << "]): "; - am.display_decimal(std::cout, upper_roots[interval.u_index - 1], 10); - std::cout << "\n"; - std::cout << " Counter x" << level << " = "; - am.display_decimal(std::cout, counter_val, 10); - int cmp = am.compare(counter_val, upper_roots[interval.u_index - 1]); - std::cout << " -> " << (cmp > 0 ? "ABOVE" : (cmp < 0 ? "BELOW" : "EQUAL")) << " upper bound\n"; - if (cmp >= 0) counterexample_outside_cell = true; - } - } - } - std::cout << "\n"; - } + // Sanity-check: the counterexample must truly be a counterexample + ENSURE(has_different_sign(am, pm, polys, sample_full, counter_as)); - // The counterexample has different polynomial signs than the sample. - // For a sound cell, the counterexample must be OUTSIDE the cell. - ENSURE(counterexample_outside_cell); - std::cout << "SUCCESS: Counterexample is OUTSIDE the cell (cell is sound)\n"; + // Counterexample must be OUTSIDE the cell + ENSURE(!is_point_inside_cell(am, pm, cell, counter_as)); std::cout << "=== END tst_unsound_lws_et4 ===\n\n"; } @@ -2154,6 +1813,10 @@ static void tst_unsound_lws_disc_zero() { // For a sound cell, if polynomial signs differ, counter MUST be outside the cell // The fix (projecting p0's discriminant) should create bounds that exclude the counterexample + // Sanity-check: the counterexample must truly be a counterexample, + // i.e. at least one input polynomial has a different sign. + ENSURE(has_different_sign(am, pm, polys, sample_as, counter_as)); + if (p0_sample != p0_counter) { std::cout << "\nPoly signs differ between sample and counter.\n"; std::cout << "For cell to be sound, counter must be OUTSIDE the cell.\n"; @@ -2309,25 +1972,9 @@ static void tst_unsound_lws_ppblockterm() { std::cout << "--- END LEMMA ---\n\n"; - // Check polynomial signs at sample and counterexample - int p0_sample = am.eval_sign_at(p0, sample_as); - int p1_sample = am.eval_sign_at(p1, sample_as); - int p2_sample = am.eval_sign_at(p2, sample_as); - int p3_sample = am.eval_sign_at(p3, sample_as); - - int p0_counter = am.eval_sign_at(p0, counter_as); - int p1_counter = am.eval_sign_at(p1, counter_as); - int p2_counter = am.eval_sign_at(p2, counter_as); - int p3_counter = am.eval_sign_at(p3, counter_as); - - bool signs_differ = (p0_sample != p0_counter) || (p1_sample != p1_counter) || - (p2_sample != p2_counter) || (p3_sample != p3_counter); - - if (signs_differ) { - std::cout << "Polynomial signs DIFFER between sample and counterexample.\n"; - } else { - std::cout << "Polynomial signs match between sample and counterexample.\n"; - } + // Sanity-check: the counterexample must truly be a counterexample, + // i.e. at least one input polynomial has a different sign. + ENSURE(has_different_sign(am, pm, polys, sample_as, counter_as)); // Verify that the counterexample is OUTSIDE the cell (cell is sound) std::cout << "\nChecking if counterexample is inside cell:\n"; @@ -2671,74 +2318,7 @@ static void tst_unsound_lws_p6236() { // Check if counterexample is inside the cell std::cout << "\n--- Checking if counterexample is in cell ---\n"; - bool counterexample_outside_cell = false; - - // Counter values for each level - int counter_vals[] = {0, -1, 1, -1, 1, 0, 0, 0, 0, 1, 0, 3, 1, 0, 0, 0}; - - for (unsigned i = 0; i < cell.size(); ++i) { - auto const& interval = cell[i]; - nlsat::var level = i; - std::cout << "Level " << level << " (x" << level << "):\n"; - - // Build assignment up to this level (exclusive) using counterexample values - nlsat::assignment partial_as(am); - scoped_anum pval(am); - for (unsigned j = 0; j < level; ++j) { - am.set(pval, counter_vals[j]); - partial_as.set(j, pval); - } - // Special case: x11 at counter is 3 (integer, handled above) - - scoped_anum counter_val(am); - am.set(counter_val, counter_vals[level]); - - if (interval.is_section()) { - // Section: counterexample must be at the root - polynomial_ref sec_p(interval.l, pm); - scoped_anum_vector roots(am); - am.isolate_roots(sec_p, nlsat::undef_var_assignment(partial_as, level), roots); - if (roots.size() >= interval.l_index) { - bool at_root = am.eq(counter_val, roots[interval.l_index - 1]); - std::cout << " Section root[" << interval.l_index << "]: "; - am.display_decimal(std::cout, roots[interval.l_index - 1], 10); - std::cout << ", counter = "; - am.display_decimal(std::cout, counter_val, 10); - std::cout << " -> " << (at_root ? "AT ROOT" : "NOT AT ROOT") << "\n"; - if (!at_root) counterexample_outside_cell = true; - } - } else { - if (!interval.l_inf()) { - polynomial_ref lower_p(interval.l, pm); - scoped_anum_vector lower_roots(am); - am.isolate_roots(lower_p, nlsat::undef_var_assignment(partial_as, level), lower_roots); - if (lower_roots.size() >= interval.l_index) { - int cmp = am.compare(counter_val, lower_roots[interval.l_index - 1]); - std::cout << " Lower root[" << interval.l_index << "]: "; - am.display_decimal(std::cout, lower_roots[interval.l_index - 1], 10); - std::cout << ", counter = "; - am.display_decimal(std::cout, counter_val, 10); - std::cout << " -> " << (cmp > 0 ? "ABOVE" : (cmp < 0 ? "BELOW" : "EQUAL")) << "\n"; - if (cmp <= 0) counterexample_outside_cell = true; - } - } - if (!interval.u_inf()) { - polynomial_ref upper_p(interval.u, pm); - scoped_anum_vector upper_roots(am); - am.isolate_roots(upper_p, nlsat::undef_var_assignment(partial_as, level), upper_roots); - if (upper_roots.size() >= interval.u_index) { - int cmp = am.compare(counter_val, upper_roots[interval.u_index - 1]); - std::cout << " Upper root[" << interval.u_index << "]: "; - am.display_decimal(std::cout, upper_roots[interval.u_index - 1], 10); - std::cout << ", counter = "; - am.display_decimal(std::cout, counter_val, 10); - std::cout << " -> " << (cmp > 0 ? "ABOVE" : (cmp < 0 ? "BELOW" : "EQUAL")) << "\n"; - if (cmp >= 0) counterexample_outside_cell = true; - } - } - } - std::cout << "\n"; - } + bool counterexample_outside_cell = is_point_inside_cell(am, pm, cell, counter_as); // For a sound cell, the counterexample must be OUTSIDE the cell. ENSURE(counterexample_outside_cell);