mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-08-01 11:44:02 +00:00
Code Activity

pyodide wheel: skip z3 shell executable for emscripten builds (#10238)

Browse source 
The `build-pyodide` CI job has been failing consistently because
`_copy_bins()` cannot find the z3 executable after a successful cmake
build.

**Root cause**: `pyproject.toml`'s `[tool.pyodide.build]` sets `ldflags
= "... -sSIDE_MODULE=1"`. pyodide-build injects this into the
environment `LDFLAGS`, which cmake propagates to
`CMAKE_EXE_LINKER_FLAGS`. The z3 shell target is therefore linked as a
WASM side-module — emscripten emits a `.wasm` file whose name doesn't
match any of the expected paths (`z3.wasm`, `z3.js.wasm`, `z3`):

```
error: Could not find any executable in build directory. Tried:
- .../build/z3.wasm
- .../build/z3.js.wasm
- .../build/z3
```

**Fix** — `src/api/python/setup.py`:

- **`_configure_z3()`**: pass `Z3_BUILD_EXECUTABLE=FALSE` to cmake when
`IS_PYODIDE`, so the shell target is never built
- **`_copy_bins()`**: guard BINS_DIR creation and executable copy behind
`if not IS_PYODIDE`
- **`setup()`**: set `data_files=[]` for Pyodide builds (no executable
to package)

The z3 CLI isn't usable in a Pyodide environment anyway — Python users
only need `libz3.so` via ctypes, which continues to be built and
packaged correctly. Non-Pyodide builds (Linux/macOS/Windows) are
unaffected.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This commit is contained in:
Copilot 2026-07-27 08:22:19 -07:00 • committed by GitHub
parent f7fe461eb8
commit 77372b6aed
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 22 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

36
src/api/python/setup.py
View file

@ -163,7 +163,13 @@ def _configure_z3():
'Z3_BUILD_PYTHON_BINDINGS' : True,
# Build Options
'CMAKE_BUILD_TYPE' : 'Release',
'Z3_BUILD_EXECUTABLE' : True,
# For Pyodide/emscripten builds, skip the z3 shell executable. The
# pyodide ldflags include -sSIDE_MODULE=1 which cmake propagates to
# CMAKE_EXE_LINKER_FLAGS, causing the shell to be linked as a WASM
# side-module whose output name cannot be predicted reliably. Python
# users only need libz3.so (loaded via ctypes); the CLI is not usable
# inside a Pyodide environment anyway.
'Z3_BUILD_EXECUTABLE' : not IS_PYODIDE,
'Z3_BUILD_LIBZ3_SHARED' : True,
'Z3_LINK_TIME_OPTIMIZATION' : ENABLE_LTO,
'WARNINGS_AS_ERRORS' : 'SERIOUS_ONLY',
@ -226,20 +232,22 @@ def _copy_bins():
# STEP 2: Copy the shared library, the executable and the headers
os.mkdir(LIBS_DIR)
os.mkdir(BINS_DIR)
os.mkdir(HEADERS_DIR)
shutil.copy(os.path.join(BUILD_DIR, LIBRARY_FILE), LIBS_DIR)
executable_src = None
executable_names = (EXECUTABLE_FILE,) + tuple(EXECUTABLE_FILE_FALLBACKS)
for executable_name in executable_names:
executable_src_candidate = os.path.join(BUILD_DIR, executable_name)
if os.path.exists(executable_src_candidate):
executable_src = executable_src_candidate
break
if executable_src is None:
attempted_files = "\n- ".join(os.path.join(BUILD_DIR, executable_name) for executable_name in executable_names)
raise FileNotFoundError(f"Could not find any executable in build directory. Tried:\n- {attempted_files}")
shutil.copy(executable_src, os.path.join(BINS_DIR, EXECUTABLE_FILE))
if not IS_PYODIDE:
# The shell executable is not built for Pyodide (see _configure_z3).
os.mkdir(BINS_DIR)
executable_src = None
executable_names = (EXECUTABLE_FILE,) + tuple(EXECUTABLE_FILE_FALLBACKS)
for executable_name in executable_names:
executable_src_candidate = os.path.join(BUILD_DIR, executable_name)
if os.path.exists(executable_src_candidate):
executable_src = executable_src_candidate
break
if executable_src is None:
attempted_files = "\n- ".join(os.path.join(BUILD_DIR, executable_name) for executable_name in executable_names)
raise FileNotFoundError(f"Could not find any executable in build directory. Tried:\n- {attempted_files}")
shutil.copy(executable_src, os.path.join(BINS_DIR, EXECUTABLE_FILE))
path1 = glob.glob(os.path.join(BUILD_DIR, "msvcp*"))
path2 = glob.glob(os.path.join(BUILD_DIR, "vcomp*"))
path3 = glob.glob(os.path.join(BUILD_DIR, "vcrun*"))
@ -385,6 +393,6 @@ setup(
package_data={
'z3': [os.path.join('lib', '*'), os.path.join('include', '*.h'), os.path.join('include', 'c++', '*.h')]
},
data_files=[('bin',[os.path.join('bin',EXECUTABLE_FILE)])],
data_files=[('bin',[os.path.join('bin',EXECUTABLE_FILE)])] if not IS_PYODIDE else [],
cmdclass={'build': build, 'develop': develop, 'sdist': sdist, 'bdist_wheel': bdist_wheel},
)