mirrors/z3
3
0
Fork 0
mirror of https://github.com/Z3Prover/z3 synced 2026-01-28 21:08:43 +00:00
Code Activity

Remove std::optional from Code Conventions Analyzer workflow (#8360)

Browse source 
* Initial plan

* Remove std::optional from Code Conventions Analysis workflow

- Remove std::optional from Exception Control Flow alternatives
- Remove std::optional from Prioritize safety guidelines
- Recompile workflow to update lock file

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-27 10:30:24 -08:00 • committed by GitHub
parent cd774b6fdb
commit 75096354f1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/code-conventions-analyzer.md vendored
View file

@ -442,7 +442,7 @@ Identify opportunities specific to Z3's architecture and coding patterns:
**Exception Control Flow:**
- Using exceptions for normal control flow
- Alternatives: `std::expected`, `std::optional`, error codes
- Alternatives: `std::expected`, error codes
- Performance and clarity improvements
**Inefficient Stream Output:**
@ -977,7 +977,7 @@ Do NOT perpetuate resolved issues in the cache. Always verify before storing.
- **Quantify when possible**: Use numbers to show prevalence of patterns
- **Consider backward compatibility**: Z3 is a mature project with many users
- **Measure size improvements**: Use `static_assert` and `sizeof` to verify memory layout optimizations
- **Prioritize safety**: Smart pointers, `std::optional`, and `std::span` improve type safety
- **Prioritize safety**: Smart pointers and `std::span` improve type safety
- **Consider performance**: Hash table optimizations and AST caching have measurable impact
- **Keep cache current**: Remove resolved issues from cache, only store verified unresolved items