Replace empty destructors with = default for compiler optimization (#8189)

* Initial plan

* Replace empty destructors with = default

Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>

src/ast/sls/sat_ddfw.cpp

@@ -32,9 +32,6 @@
 
 namespace sat {
 
-    ddfw::~ddfw() {
-    }
-
     lbool ddfw::check(unsigned sz, literal const* assumptions) {
         init(sz, assumptions);   
         if (m_plugin)

src/ast/sls/sat_ddfw.h

@@ -35,7 +35,7 @@ namespace sat {
 
     class local_search_plugin {
     public:
-        virtual ~local_search_plugin() {}
+        virtual ~local_search_plugin() = default;
         virtual void on_rescale() = 0;
         virtual lbool on_save_model() = 0;
         virtual void on_restart() = 0;
@@ -225,7 +225,7 @@ namespace sat {
 
         ddfw() {}
 
-        ~ddfw();
+        ~ddfw() = default;
 
         void set_plugin(local_search_plugin* p) { m_plugin = p; }
 

src/ast/sls/sls_arith_base.h

@@ -348,7 +348,7 @@ namespace sls {
         bool update_num(var_t v, num_t const& delta);
     public:
         arith_base(context& ctx);
-        ~arith_base() override {}        
+        ~arith_base() override = default;
         void register_term(expr* e) override;
         bool set_value(expr* e, expr* v) override;
         expr_ref get_value(expr* e) override;

src/ast/sls/sls_arith_plugin.h

@@ -29,7 +29,7 @@ namespace sls {
         void init_backup();
     public:
         arith_plugin(context& ctx);
-        ~arith_plugin() override {}
+        ~arith_plugin() override = default;
         void register_term(expr* e) override;
         expr_ref get_value(expr* e) override;
         void start_propagation() override;

src/ast/sls/sls_array_plugin.h

@@ -115,7 +115,7 @@ namespace sls {
         
     public:
         array_plugin(context& ctx);
-        ~array_plugin() override {}
+        ~array_plugin() override = default;
         void register_term(expr* e) override { if (a.is_array(e->get_sort())) m_has_arrays = true; }
         expr_ref get_value(expr* e) override;
         void initialize() override { m_g = nullptr; }

src/ast/sls/sls_basic_plugin.h

@@ -36,7 +36,7 @@ namespace sls {
             plugin(ctx) { 
             m_fid = basic_family_id;
         }
-        ~basic_plugin() override {}
+        ~basic_plugin() override = default;
         void register_term(expr* e) override;
         expr_ref get_value(expr* e) override;
         void initialize() override;

src/ast/sls/sls_bv_plugin.h

@@ -38,7 +38,7 @@ namespace sls {
 
     public:
         bv_plugin(context& ctx);
-        ~bv_plugin() override {}
+        ~bv_plugin() override = default;
         void register_term(expr* e) override;
         expr_ref get_value(expr* e) override;
         void start_propagation() override;

src/ast/sls/sls_context.h

@@ -38,7 +38,7 @@ namespace sls {
         family_id m_fid;
     public:
         plugin(context& c);
-        virtual ~plugin() {}
+        virtual ~plugin() = default;
         virtual family_id fid() { return m_fid; }
         virtual void register_term(expr* e) = 0;
         virtual expr_ref get_value(expr* e) = 0;
@@ -65,7 +65,7 @@ namespace sls {
 
     class sat_solver_context {
     public:
-        virtual ~sat_solver_context() {}
+        virtual ~sat_solver_context() = default;
         virtual vector<sat::clause_info> const& clauses() const = 0;
         virtual sat::clause_info const& get_clause(unsigned idx) const = 0;
         virtual ptr_iterator<unsigned> get_use_list(sat::literal lit) = 0;

src/ast/sls/sls_datatype_plugin.cpp

@@ -91,8 +91,6 @@ namespace sls {
         m_eval(m) {
         m_fid = dt.get_family_id();
     }
-    
-    datatype_plugin::~datatype_plugin() {}
 
     void datatype_plugin::collect_path_axioms() {
         expr* t = nullptr, *z = nullptr;

src/ast/sls/sls_datatype_plugin.h

@@ -81,7 +81,7 @@ namespace sls {
 
     public:
         datatype_plugin(context& c);
-        ~datatype_plugin() override;
+        ~datatype_plugin() override = default;
         family_id fid() override { return m_fid; }
         expr_ref get_value(expr* e) override;
         void initialize() override;

src/ast/sls/sls_euf_plugin.cpp

@@ -33,8 +33,6 @@ namespace sls {
         m_values(8U, value_hash(*this), value_eq(*this)) {
         m_fid = user_sort_family_id;
     }
-    
-    euf_plugin::~euf_plugin() {}
 
     void euf_plugin::initialize() {
     }

src/ast/sls/sls_euf_plugin.h

@@ -60,7 +60,7 @@ namespace sls {
 
     public:
         euf_plugin(context& c);
-        ~euf_plugin() override;
+        ~euf_plugin() override = default;
         expr_ref get_value(expr* e) override;
         void initialize() override;
         void start_propagation() override;

src/ast/sls/sls_seq_plugin.h

@@ -169,7 +169,7 @@ namespace sls {
         bool is_value(expr* e);
     public:
         seq_plugin(context& c);
-        ~seq_plugin() override {}
+        ~seq_plugin() override = default;
         expr_ref get_value(expr* e) override;
         void initialize() override;
         void start_propagation() override {}

src/ast/sls/sls_smt_plugin.h

@@ -27,7 +27,7 @@ namespace sls {
 
     class smt_context {
     public:
-        virtual ~smt_context() {}
+        virtual ~smt_context() = default;
         virtual ast_manager& get_manager() = 0;
         virtual params_ref get_params() = 0;
         virtual void set_value(expr* t, expr* v) = 0;

src/ast/sls/sls_smt_solver.cpp

@@ -140,10 +140,7 @@ namespace sls {
 
         m_solver_ctx->updt_params(p);
     }
-    
-    smt_solver::~smt_solver() {        
-    }
-    
+
     void smt_solver::assert_expr(expr* e) {
         if (m.is_and(e)) {
             for (expr* arg : *to_app(e))

src/ast/sls/sls_smt_solver.h

@@ -32,7 +32,7 @@ namespace sls {
         
     public:
         smt_solver(ast_manager& m, params_ref const& p);
-        ~smt_solver();
+        ~smt_solver() = default;
         void assert_expr(expr* e);
         lbool check();
         model_ref get_model();